diff options
| author | Andrew Cagney <cagney@redhat.com> | 2003-07-28 15:41:19 +0000 |
|---|---|---|
| committer | Andrew Cagney <cagney@redhat.com> | 2003-07-28 15:41:19 +0000 |
| commit | bb1db0499b61b476bf77418099aaaf981c0d9c39 (patch) | |
| tree | 1bf1694eec804eb01c258e20b2f4e6b392cab16c /gdb/regcache.c | |
| parent | 20e6603c81d023ee57bef42b5f1080d379c0325f (diff) | |
| download | gdb-bb1db0499b61b476bf77418099aaaf981c0d9c39.zip gdb-bb1db0499b61b476bf77418099aaaf981c0d9c39.tar.gz gdb-bb1db0499b61b476bf77418099aaaf981c0d9c39.tar.bz2 | |
2003-07-28 Andrew Cagney <cagney@redhat.com>
* regcache.c (struct regcache_descr): Update comments on
nr_raw_registers.
(init_legacy_regcache_descr): Don't set nr_raw_registers or
sizeof_raw_register_valid_p.
(init_regcache_descr): Set nr_raw_registers and
sizeof_raw_register_valid_p before calling
init_legacy_regcache_descr.
Diffstat (limited to 'gdb/regcache.c')
| -rw-r--r-- | gdb/regcache.c | 35 |
1 files changed, 15 insertions, 20 deletions
diff --git a/gdb/regcache.c b/gdb/regcache.c index 505f6ac..b66e06d 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -51,10 +51,11 @@ struct regcache_descr for raw and pseudo registers and allow access to both. */ int legacy_p; - /* The raw register cache. This should contain just [0 - .. NUM_RAW_REGISTERS). However, for older targets, it contains - space for the full [0 .. NUM_RAW_REGISTERS + - NUM_PSEUDO_REGISTERS). */ + /* The raw register cache. Each raw (or hard) register is supplied + by the target interface. The raw cache should not contain + redundant information - if the PC is constructed from two + registers then those regigisters and not the PC lives in the raw + cache. */ int nr_raw_registers; long sizeof_raw_registers; long sizeof_raw_register_valid_p; @@ -91,12 +92,6 @@ init_legacy_regcache_descr (struct gdbarch *gdbarch, ``gdbarch'' as a parameter. */ gdb_assert (gdbarch != NULL); - /* FIXME: cagney/2002-05-11: Shouldn't be including pseudo-registers - in the register cache. Unfortunatly some architectures still - rely on this and the pseudo_register_write() method. */ - descr->nr_raw_registers = descr->nr_cooked_registers; - descr->sizeof_raw_register_valid_p = descr->sizeof_cooked_register_valid_p; - /* Compute the offset of each register. Legacy architectures define REGISTER_BYTE() so use that. */ /* FIXME: cagney/2002-11-07: Instead of using REGISTER_BYTE() this @@ -176,6 +171,16 @@ init_regcache_descr (struct gdbarch *gdbarch) descr->register_type[i] = REGISTER_VIRTUAL_TYPE (i); /* OK */ } + /* Construct a strictly RAW register cache. Don't allow pseudo's + into the register cache. */ + descr->nr_raw_registers = NUM_REGS; + + /* FIXME: cagney/2002-08-13: Overallocate the register_valid_p + array. This pretects GDB from erant code that accesses elements + of the global register_valid_p[] array in the range [NUM_REGS + .. NUM_REGS + NUM_PSEUDO_REGS). */ + descr->sizeof_raw_register_valid_p = descr->sizeof_cooked_register_valid_p; + /* If an old style architecture, fill in the remainder of the register cache descriptor using the register macros. */ /* NOTE: cagney/2003-06-29: If either of REGISTER_BYTE or @@ -194,16 +199,6 @@ init_regcache_descr (struct gdbarch *gdbarch) return descr; } - /* Construct a strictly RAW register cache. Don't allow pseudo's - into the register cache. */ - descr->nr_raw_registers = NUM_REGS; - - /* FIXME: cagney/2002-08-13: Overallocate the register_valid_p - array. This pretects GDB from erant code that accesses elements - of the global register_valid_p[] array in the range [NUM_REGS - .. NUM_REGS + NUM_PSEUDO_REGS). */ - descr->sizeof_raw_register_valid_p = descr->sizeof_cooked_register_valid_p; - /* Lay out the register cache. NOTE: cagney/2002-05-22: Only register_type() is used when |