aboutsummaryrefslogtreecommitdiff
path: root/gdb/ravenscar-thread.h
diff options
context:
space:
mode:
authorTom Tromey <tromey@adacore.com>2019-02-05 03:08:02 -0700
committerTom Tromey <tromey@adacore.com>2019-02-15 13:53:42 -0700
commit7657f14df7c697792b626efbd24ac44ad5642485 (patch)
tree5b636873519efe4f620656be3368bbc0c249332e /gdb/ravenscar-thread.h
parent5b6ea500d554b173e63e1f8f0344d568ad347463 (diff)
downloadgdb-7657f14df7c697792b626efbd24ac44ad5642485.zip
gdb-7657f14df7c697792b626efbd24ac44ad5642485.tar.gz
gdb-7657f14df7c697792b626efbd24ac44ad5642485.tar.bz2
C++-ify ravenscar_arch_ops
This turns ravenscar_arch_ops into an abstract base class and updates all the places where it is used. This is an improvement because it avoids any possibility of forgetting to set one of the function pointers. It also makes clear that these functions aren't intended to be changed dynamically. This version of the patch removes the prepare_to_store method, as it is unused, and it is easy enough to add if it is ever needed. gdb/ChangeLog 2019-02-15 Tom Tromey <tromey@adacore.com> * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive from ravenscar_arch_ops. (sparc_ravenscar_ops::fetch_registers) (sparc_ravenscar_ops::store_registers): Now methods. (sparc_ravenscar_prepare_to_store): Remove. (sparc_ravenscar_ops): Redefine. * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual methods and destructor. Remove members. * ravenscar-thread.c (ravenscar_thread_target::fetch_registers) (ravenscar_thread_target::store_registers) (ravenscar_thread_target::prepare_to_store): Update. * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store): Remove. (struct ppc_ravenscar_powerpc_ops): Derive from ravenscar_arch_ops. (ppc_ravenscar_powerpc_ops::fetch_registers) (ppc_ravenscar_powerpc_ops::store_registers): Now methods. (ppc_ravenscar_powerpc_ops): Redefine. (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops. (ppc_ravenscar_e500_ops::fetch_registers) (ppc_ravenscar_e500_ops::store_registers): Now methods. (ppc_ravenscar_e500_ops): Redefine. * aarch64-ravenscar-thread.c (aarch64_ravenscar_generic_prepare_to_store): Remove. (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops. (aarch64_ravenscar_fetch_registers) (aarch64_ravenscar_store_registers): Now methods. (aarch64_ravenscar_ops): Redefine.
Diffstat (limited to 'gdb/ravenscar-thread.h')
-rw-r--r--gdb/ravenscar-thread.h9
1 files changed, 6 insertions, 3 deletions
diff --git a/gdb/ravenscar-thread.h b/gdb/ravenscar-thread.h
index 8aab0a1..add5553 100644
--- a/gdb/ravenscar-thread.h
+++ b/gdb/ravenscar-thread.h
@@ -24,9 +24,12 @@
struct ravenscar_arch_ops
{
- void (*to_fetch_registers) (struct regcache *, int);
- void (*to_store_registers) (struct regcache *, int);
- void (*to_prepare_to_store) (struct regcache *);
+ virtual ~ravenscar_arch_ops ()
+ {
+ }
+
+ virtual void fetch_registers (struct regcache *, int) = 0;
+ virtual void store_registers (struct regcache *, int) = 0;
};
#endif /* !defined (RAVENSCAR_THREAD_H) */