diff options
author | Pedro Alves <palves@redhat.com> | 2018-06-21 17:09:31 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2018-06-21 17:09:31 +0100 |
commit | 00431a78b28f913a9d5c912c49680e39cfd20847 (patch) | |
tree | a16c50ee1250317f71ff7e8be9d3275bee7f0ecf /gdb/python | |
parent | 33bab475a6984afedac8a036b3bb40b5555b4127 (diff) | |
download | gdb-00431a78b28f913a9d5c912c49680e39cfd20847.zip gdb-00431a78b28f913a9d5c912c49680e39cfd20847.tar.gz gdb-00431a78b28f913a9d5c912c49680e39cfd20847.tar.bz2 |
Use thread_info and inferior pointers more throughout
This is more preparation bits for multi-target support.
In a multi-target scenario, we need to address the case of different
processes/threads running on different targets that happen to have the
same PID/PTID. E.g., we can have both process 123 in target 1, and
process 123 in target 2, while they're in reality different processes
running on different machines. Or maybe we've loaded multiple
instances of the same core file. Etc.
To address this, in my WIP multi-target branch, threads and processes
are uniquely identified by the (process_stratum target_ops *, ptid_t)
and (process_stratum target_ops *, pid) tuples respectively. I.e.,
each process_stratum instance has its own thread/process number space.
As you can imagine, that requires passing around target_ops * pointers
in a number of functions where we're currently passing only a ptid_t
or an int. E.g., when we look up a thread_info object by ptid_t in
find_thread_ptid, the ptid_t alone isn't sufficient.
In many cases though, we already have the thread_info or inferior
pointer handy, but we "lose" it somewhere along the call stack, only
to look it up again by ptid_t/pid. Since thread_info or inferior
objects know their parent target, if we pass around thread_info or
inferior pointers when possible, we avoid having to add extra
target_ops parameters to many functions, and also, we eliminate a
number of by ptid_t/int lookups.
So that's what this patch does. In a bit more detail:
- Changes a number of functions and methods to take a thread_info or
inferior pointer instead of a ptid_t or int parameter.
- Changes a number of structure fields from ptid_t/int to inferior or
thread_info pointers.
- Uses the inferior_thread() function whenever possible instead of
inferior_ptid.
- Uses thread_info pointers directly when possible instead of the
is_running/is_stopped etc. routines that require a lookup.
- A number of functions are eliminated along the way, such as:
int valid_gdb_inferior_id (int num);
int pid_to_gdb_inferior_id (int pid);
int gdb_inferior_id_to_pid (int num);
int in_inferior_list (int pid);
- A few structures and places hold a thread_info pointer across
inferior execution, so now they take a strong reference to the
(refcounted) thread_info object to avoid the thread_info pointer
getting stale. This is done in enable_thread_stack_temporaries and
in the infcall.c code.
- Related, there's a spot in infcall.c where using a RAII object to
handle the refcount would be handy, so a gdb::ref_ptr specialization
for thread_info is added (thread_info_ref, in gdbthread.h), along
with a gdb_ref_ptr policy that works for all refcounted_object types
(in common/refcounted-object.h).
gdb/ChangeLog:
2018-06-21 Pedro Alves <palves@redhat.com>
* ada-lang.h (ada_get_task_number): Take a thread_info pointer
instead of a ptid_t. All callers adjusted.
* ada-tasks.c (ada_get_task_number): Likewise. All callers
adjusted.
(print_ada_task_info, display_current_task_id, task_command_1):
Adjust.
* breakpoint.c (watchpoint_in_thread_scope): Adjust to use
inferior_thread.
(breakpoint_kind): Adjust.
(remove_breakpoints_pid): Rename to ...
(remove_breakpoints_inf): ... this. Adjust to take an inferior
pointer. All callers adjusted.
(bpstat_clear_actions): Use inferior_thread.
(get_bpstat_thread): New.
(bpstat_do_actions): Use it.
(bpstat_check_breakpoint_conditions, bpstat_stop_status): Adjust
to take a thread_info pointer. All callers adjusted.
(set_longjmp_breakpoint_for_call_dummy, set_momentary_breakpoint)
(breakpoint_re_set_thread): Use inferior_thread.
* breakpoint.h (struct inferior): Forward declare.
(bpstat_stop_status): Update.
(remove_breakpoints_pid): Delete.
(remove_breakpoints_inf): New.
* bsd-uthread.c (bsd_uthread_target::wait)
(bsd_uthread_target::update_thread_list): Use find_thread_ptid.
* btrace.c (btrace_add_pc, btrace_enable, btrace_fetch)
(maint_btrace_packet_history_cmd)
(maint_btrace_clear_packet_history_cmd): Adjust.
(maint_btrace_clear_cmd, maint_info_btrace_cmd): Adjust to use
inferior_thread.
* cli/cli-interp.c: Include "inferior.h".
* common/refcounted-object.h (struct
refcounted_object_ref_policy): New.
* compile/compile-object-load.c: Include gdbthread.h.
(store_regs): Use inferior_thread.
* corelow.c (core_target::close): Use current_inferior.
(core_target_open): Adjust to use first_thread_of_inferior and use
the current inferior.
* ctf.c (ctf_target::close): Adjust to use current_inferior.
* dummy-frame.c (dummy_frame_id) <ptid>: Delete, replaced by ...
<thread>: ... this new field. All references adjusted.
(dummy_frame_pop, dummy_frame_discard, register_dummy_frame_dtor):
Take a thread_info pointer instead of a ptid_t.
* dummy-frame.h (dummy_frame_push, dummy_frame_pop)
(dummy_frame_discard, register_dummy_frame_dtor): Take a
thread_info pointer instead of a ptid_t.
* elfread.c: Include "inferior.h".
(elf_gnu_ifunc_resolver_stop, elf_gnu_ifunc_resolver_return_stop):
Use inferior_thread.
* eval.c (evaluate_subexp): Likewise.
* frame.c (frame_pop, has_stack_frames, find_frame_sal): Use
inferior_thread.
* gdb_proc_service.h (struct thread_info): Forward declare.
(struct ps_prochandle) <ptid>: Delete, replaced by ...
<thread>: ... this new field. All references adjusted.
* gdbarch.h, gdbarch.c: Regenerate.
* gdbarch.sh (get_syscall_number): Replace 'ptid' parameter with a
'thread' parameter. All implementations and callers adjusted.
* gdbthread.h (thread_info) <set_running>: New method.
(delete_thread, delete_thread_silent): Take a thread_info pointer
instead of a ptid.
(global_thread_id_to_ptid, ptid_to_global_thread_id): Delete.
(first_thread_of_process): Delete, replaced by ...
(first_thread_of_inferior): ... this new function. All callers
adjusted.
(any_live_thread_of_process): Delete, replaced by ...
(any_live_thread_of_inferior): ... this new function. All callers
adjusted.
(switch_to_thread, switch_to_no_thread): Declare.
(is_executing): Delete.
(enable_thread_stack_temporaries): Update comment.
<enable_thread_stack_temporaries>: Take a thread_info pointer
instead of a ptid_t. Incref the thread.
<~enable_thread_stack_temporaries>: Decref the thread.
<m_ptid>: Delete
<m_thr>: New.
(thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
(get_last_thread_stack_temporary)
(value_in_thread_stack_temporaries, can_access_registers_thread):
Take a thread_info pointer instead of a ptid_t. All callers
adjusted.
* infcall.c (get_call_return_value): Use inferior_thread.
(run_inferior_call): Work with thread pointers instead of ptid_t.
(call_function_by_hand_dummy): Work with thread pointers instead
of ptid_t. Use thread_info_ref.
* infcmd.c (proceed_thread_callback): Access thread's state
directly.
(ensure_valid_thread, ensure_not_running): Use inferior_thread,
access thread's state directly.
(continue_command): Use inferior_thread.
(info_program_command): Use find_thread_ptid and access thread
state directly.
(proceed_after_attach_callback): Use thread state directly.
(notice_new_inferior): Take a thread_info pointer instead of a
ptid_t. All callers adjusted.
(exit_inferior): Take an inferior pointer instead of a pid. All
callers adjusted.
(exit_inferior_silent): New.
(detach_inferior): Delete.
(valid_gdb_inferior_id, pid_to_gdb_inferior_id)
(gdb_inferior_id_to_pid, in_inferior_list): Delete.
(detach_inferior_command, kill_inferior_command): Use
find_inferior_id instead of valid_gdb_inferior_id and
gdb_inferior_id_to_pid.
(inferior_command): Use inferior and thread pointers.
* inferior.h (struct thread_info): Forward declare.
(notice_new_inferior): Take a thread_info pointer instead of a
ptid_t. All callers adjusted.
(detach_inferior): Delete declaration.
(exit_inferior, exit_inferior_silent): Take an inferior pointer
instead of a pid. All callers adjusted.
(gdb_inferior_id_to_pid, pid_to_gdb_inferior_id, in_inferior_list)
(valid_gdb_inferior_id): Delete.
* infrun.c (follow_fork_inferior, proceed_after_vfork_done)
(handle_vfork_child_exec_or_exit, follow_exec): Adjust.
(struct displaced_step_inferior_state) <pid>: Delete, replaced by
...
<inf>: ... this new field.
<step_ptid>: Delete, replaced by ...
<step_thread>: ... this new field.
(get_displaced_stepping_state): Take an inferior pointer instead
of a pid. All callers adjusted.
(displaced_step_in_progress_any_inferior): Adjust.
(displaced_step_in_progress_thread): Take a thread pointer instead
of a ptid_t. All callers adjusted.
(displaced_step_in_progress, add_displaced_stepping_state): Take
an inferior pointer instead of a pid. All callers adjusted.
(get_displaced_step_closure_by_addr): Adjust.
(remove_displaced_stepping_state): Take an inferior pointer
instead of a pid. All callers adjusted.
(displaced_step_prepare_throw, displaced_step_prepare)
(displaced_step_fixup): Take a thread pointer instead of a ptid_t.
All callers adjusted.
(start_step_over): Adjust.
(infrun_thread_ptid_changed): Remove bit updating ptids in the
displaced step queue.
(do_target_resume): Adjust.
(fetch_inferior_event): Use inferior_thread.
(context_switch, get_inferior_stop_soon): Take an
execution_control_state pointer instead of a ptid_t. All callers
adjusted.
(switch_to_thread_cleanup): Delete.
(stop_all_threads): Use scoped_restore_current_thread.
* inline-frame.c: Include "gdbthread.h".
(inline_state) <inline_state>: Take a thread pointer instead of a
ptid_t. All callers adjusted.
<ptid>: Delete, replaced by ...
<thread>: ... this new field.
(find_inline_frame_state): Take a thread pointer instead of a
ptid_t. All callers adjusted.
(skip_inline_frames, step_into_inline_frame)
(inline_skipped_frames, inline_skipped_symbol): Take a thread
pointer instead of a ptid_t. All callers adjusted.
* inline-frame.h (skip_inline_frames, step_into_inline_frame)
(inline_skipped_frames, inline_skipped_symbol): Likewise.
* linux-fork.c (delete_checkpoint_command): Adjust to use thread
pointers directly.
* linux-nat.c (get_detach_signal): Likewise.
* linux-thread-db.c (thread_from_lwp): New 'stopped' parameter.
(thread_db_notice_clone): Adjust.
(thread_db_find_new_threads_silently)
(thread_db_find_new_threads_2, thread_db_find_new_threads_1): Take
a thread pointer instead of a ptid_t. All callers adjusted.
* mi/mi-cmd-var.c: Include "inferior.h".
(mi_cmd_var_update_iter): Update to use thread pointers.
* mi/mi-interp.c (mi_new_thread): Update to use the thread's
inferior directly.
(mi_output_running_pid, mi_inferior_count): Delete, bits factored
out to ...
(mi_output_running): ... this new function.
(mi_on_resume_1): Adjust to use it.
(mi_user_selected_context_changed): Adjust to use inferior_thread.
* mi/mi-main.c (proceed_thread): Adjust to use thread pointers
directly.
(interrupt_thread_callback): : Adjust to use thread and inferior
pointers.
* proc-service.c: Include "gdbthread.h".
(ps_pglobal_lookup): Adjust to use the thread's inferior directly.
* progspace-and-thread.c: Include "inferior.h".
* progspace.c: Include "inferior.h".
* python/py-exitedevent.c (create_exited_event_object): Adjust to
hold a reference to an inferior_object.
* python/py-finishbreakpoint.c (bpfinishpy_init): Adjust to use
inferior_thread.
* python/py-inferior.c (struct inferior_object): Give the type a
tag name instead of a typedef.
(python_on_normal_stop): No need to check if the current thread is
listed.
(inferior_to_inferior_object): Change return type to
inferior_object. All callers adjusted.
(find_thread_object): Delete, bits factored out to ...
(thread_to_thread_object): ... this new function.
* python/py-infthread.c (create_thread_object): Use
inferior_to_inferior_object.
(thpy_is_stopped): Use thread pointer directly.
(gdbpy_selected_thread): Use inferior_thread.
* python/py-record-btrace.c (btpy_list_object) <ptid>: Delete
field, replaced with ...
<thread>: ... this new field. All users adjusted.
(btpy_insn_or_gap_new): Drop const.
(btpy_list_new): Take a thread pointer instead of a ptid_t. All
callers adjusted.
* python/py-record.c: Include "gdbthread.h".
(recpy_insn_new, recpy_func_new): Take a thread pointer instead of
a ptid_t. All callers adjusted.
(gdbpy_current_recording): Use inferior_thread.
* python/py-record.h (recpy_record_object) <ptid>: Delete
field, replaced with ...
<thread>: ... this new field. All users adjusted.
(recpy_element_object) <ptid>: Delete
field, replaced with ...
<thread>: ... this new field. All users adjusted.
(recpy_insn_new, recpy_func_new): Take a thread pointer instead of
a ptid_t. All callers adjusted.
* python/py-threadevent.c: Include "gdbthread.h".
(get_event_thread): Use thread_to_thread_object.
* python/python-internal.h (struct inferior_object): Forward
declare.
(find_thread_object, find_inferior_object): Delete declarations.
(thread_to_thread_object, inferior_to_inferior_object): New
declarations.
* record-btrace.c: Include "inferior.h".
(require_btrace_thread): Use inferior_thread.
(record_btrace_frame_sniffer)
(record_btrace_tailcall_frame_sniffer): Use inferior_thread.
(get_thread_current_frame): Use scoped_restore_current_thread and
switch_to_thread.
(get_thread_current_frame): Use thread pointer directly.
(record_btrace_replay_at_breakpoint): Use thread's inferior
pointer directly.
* record-full.c: Include "inferior.h".
* regcache.c: Include "gdbthread.h".
(get_thread_arch_regcache): Use the inferior's address space
directly.
(get_thread_regcache, registers_changed_thread): New.
* regcache.h (get_thread_regcache(thread_info *thread)): New
overload.
(registers_changed_thread): New.
(remote_target) <remote_detach_1>: Swap order of parameters.
(remote_add_thread): <remote_add_thread>: Return the new thread.
(get_remote_thread_info(ptid_t)): New overload.
(remote_target::remote_notice_new_inferior): Use thread pointers
directly.
(remote_target::process_initial_stop_replies): Use
thread_info::set_running.
(remote_target::remote_detach_1, remote_target::detach)
(extended_remote_target::detach): Adjust.
* stack.c (frame_show_address): Use inferior_thread.
* target-debug.h (target_debug_print_thread_info_pp): New.
* target-delegates.c: Regenerate.
* target.c (default_thread_address_space): Delete.
(memory_xfer_partial_1): Use current_inferior.
(target_detach): Use current_inferior.
(target_thread_address_space): Delete.
(generic_mourn_inferior): Use current_inferior.
* target.h (struct target_ops) <thread_address_space>: Delete.
(target_thread_address_space): Delete.
* thread.c (init_thread_list): Use ALL_THREADS_SAFE. Use thread
pointers directly.
(delete_thread_1, delete_thread, delete_thread_silent): Take a
thread pointer instead of a ptid_t. Adjust all callers.
(ptid_to_global_thread_id, global_thread_id_to_ptid): Delete.
(first_thread_of_process): Delete, replaced by ...
(first_thread_of_inferior): ... this new function. All callers
adjusted.
(any_thread_of_process): Rename to ...
(any_thread_of_inferior): ... this, and take an inferior pointer.
(any_live_thread_of_process): Rename to ...
(any_live_thread_of_inferior): ... this, and take an inferior
pointer.
(thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
(value_in_thread_stack_temporaries)
(get_last_thread_stack_temporary): Take a thread pointer instead
of a ptid_t. Adjust all callers.
(thread_info::set_running): New.
(validate_registers_access): Use inferior_thread.
(can_access_registers_ptid): Rename to ...
(can_access_registers_thread): ... this, and take a thread
pointer.
(print_thread_info_1): Adjust to compare thread pointers instead
of ptids.
(switch_to_no_thread, switch_to_thread): Make extern.
(scoped_restore_current_thread::~scoped_restore_current_thread):
Use m_thread pointer directly.
(scoped_restore_current_thread::scoped_restore_current_thread):
Use inferior_thread.
(thread_command): Use thread pointer directly.
(thread_num_make_value_helper): Use inferior_thread.
* top.c (execute_command): Use inferior_thread.
* tui/tui-interp.c: Include "inferior.h".
* varobj.c (varobj_create): Use inferior_thread.
(value_of_root_1): Use find_thread_global_id instead of
global_thread_id_to_ptid.
Diffstat (limited to 'gdb/python')
-rw-r--r-- | gdb/python/py-exitedevent.c | 4 | ||||
-rw-r--r-- | gdb/python/py-finishbreakpoint.c | 5 | ||||
-rw-r--r-- | gdb/python/py-inferior.c | 49 | ||||
-rw-r--r-- | gdb/python/py-infthread.c | 24 | ||||
-rw-r--r-- | gdb/python/py-record-btrace.c | 54 | ||||
-rw-r--r-- | gdb/python/py-record.c | 17 | ||||
-rw-r--r-- | gdb/python/py-record.h | 12 | ||||
-rw-r--r-- | gdb/python/py-threadevent.c | 5 | ||||
-rw-r--r-- | gdb/python/python-internal.h | 9 |
9 files changed, 91 insertions, 88 deletions
diff --git a/gdb/python/py-exitedevent.c b/gdb/python/py-exitedevent.c index 4f861e3..6a7c9f5 100644 --- a/gdb/python/py-exitedevent.c +++ b/gdb/python/py-exitedevent.c @@ -39,10 +39,10 @@ create_exited_event_object (const LONGEST *exit_code, struct inferior *inf) return NULL; } - gdbpy_ref<> inf_obj (inferior_to_inferior_object (inf)); + gdbpy_ref<inferior_object> inf_obj (inferior_to_inferior_object (inf)); if (inf_obj == NULL || evpy_add_attribute (exited_event.get (), "inferior", - inf_obj.get ()) < 0) + (PyObject *) inf_obj.get ()) < 0) return NULL; return exited_event.release (); diff --git a/gdb/python/py-finishbreakpoint.c b/gdb/python/py-finishbreakpoint.c index b3978f7..c33b7dd 100644 --- a/gdb/python/py-finishbreakpoint.c +++ b/gdb/python/py-finishbreakpoint.c @@ -221,14 +221,15 @@ bpfinishpy_init (PyObject *self, PyObject *args, PyObject *kwargs) if (PyErr_Occurred ()) return -1; - thread = ptid_to_global_thread_id (inferior_ptid); - if (thread == 0) + if (inferior_ptid == null_ptid) { PyErr_SetString (PyExc_ValueError, _("No thread currently selected.")); return -1; } + thread = inferior_thread ()->global_num; + if (internal) { internal_bp = PyObject_IsTrue (internal); diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c index d199aaa..9f09ae9 100644 --- a/gdb/python/py-inferior.c +++ b/gdb/python/py-inferior.c @@ -35,7 +35,7 @@ struct threadlist_entry { struct threadlist_entry *next; }; -typedef struct +struct inferior_object { PyObject_HEAD @@ -48,7 +48,7 @@ typedef struct /* Number of threads in the list. */ int nthreads; -} inferior_object; +}; extern PyTypeObject inferior_object_type CPYCHECKER_TYPE_OBJECT_FOR_TYPEDEF ("inferior_object"); @@ -207,7 +207,8 @@ python_new_objfile (struct objfile *objfile) representing INFERIOR. If the object has already been created, return it and increment the reference count, otherwise, create it. Return NULL on failure. */ -PyObject * + +inferior_object * inferior_to_inferior_object (struct inferior *inferior) { inferior_object *inf_obj; @@ -232,7 +233,7 @@ inferior_to_inferior_object (struct inferior *inferior) /* We are returning a new reference. */ Py_INCREF ((PyObject *)inf_obj); - return (PyObject *) inf_obj; + return inf_obj; } /* Called when a new inferior is created. Notifies any Python event @@ -248,7 +249,7 @@ python_new_inferior (struct inferior *inf) if (evregpy_no_listeners_p (gdb_py_events.new_inferior)) return; - gdbpy_ref<> inf_obj (inferior_to_inferior_object (inf)); + gdbpy_ref<inferior_object> inf_obj (inferior_to_inferior_object (inf)); if (inf_obj == NULL) { gdbpy_print_stack (); @@ -257,7 +258,8 @@ python_new_inferior (struct inferior *inf) gdbpy_ref<> event (create_event_object (&new_inferior_event_object_type)); if (event == NULL - || evpy_add_attribute (event.get (), "inferior", inf_obj.get ()) < 0 + || evpy_add_attribute (event.get (), "inferior", + (PyObject *) inf_obj.get ()) < 0 || evpy_emit_event (event.get (), gdb_py_events.new_inferior) < 0) gdbpy_print_stack (); } @@ -275,7 +277,7 @@ python_inferior_deleted (struct inferior *inf) if (evregpy_no_listeners_p (gdb_py_events.inferior_deleted)) return; - gdbpy_ref<> inf_obj (inferior_to_inferior_object (inf)); + gdbpy_ref<inferior_object> inf_obj (inferior_to_inferior_object (inf)); if (inf_obj == NULL) { gdbpy_print_stack (); @@ -284,7 +286,8 @@ python_inferior_deleted (struct inferior *inf) gdbpy_ref<> event (create_event_object (&inferior_deleted_event_object_type)); if (event == NULL - || evpy_add_attribute (event.get (), "inferior", inf_obj.get ()) < 0 + || evpy_add_attribute (event.get (), "inferior", + (PyObject *) inf_obj.get ()) < 0 || evpy_emit_event (event.get (), gdb_py_events.inferior_deleted) < 0) gdbpy_print_stack (); } @@ -298,28 +301,22 @@ find_inferior_object (int pid) struct inferior *inf = find_inferior_pid (pid); if (inf) - return inferior_to_inferior_object (inf); + return (PyObject *) inferior_to_inferior_object (inf); return NULL; } thread_object * -find_thread_object (ptid_t ptid) +thread_to_thread_object (thread_info *thr) { - int pid; - struct threadlist_entry *thread; - - pid = ptid_get_pid (ptid); - if (pid == 0) - return NULL; - - gdbpy_ref<> inf_obj (find_inferior_object (pid)); + gdbpy_ref<inferior_object> inf_obj (inferior_to_inferior_object (thr->inf)); if (inf_obj == NULL) return NULL; - for (thread = ((inferior_object *)(inf_obj.get ()))->threads; thread; + for (threadlist_entry *thread = inf_obj->threads; + thread != NULL; thread = thread->next) - if (ptid_equal (thread->thread_obj->thread->ptid, ptid)) + if (thread->thread_obj->thread == thr) return thread->thread_obj; return NULL; @@ -374,7 +371,7 @@ delete_thread_object (struct thread_info *tp, int ignore) gdbpy_enter enter_py (python_gdbarch, python_language); gdbpy_ref<inferior_object> inf_obj - ((inferior_object *) find_inferior_object (ptid_get_pid (tp->ptid))); + ((inferior_object *) inferior_to_inferior_object (tp->inf)); if (inf_obj == NULL) return; @@ -466,12 +463,12 @@ static int build_inferior_list (struct inferior *inf, void *arg) { PyObject *list = (PyObject *) arg; - gdbpy_ref<> inferior (inferior_to_inferior_object (inf)); + gdbpy_ref<inferior_object> inferior (inferior_to_inferior_object (inf)); - if (inferior == NULL) + if (inferior == NULL) return 0; - return PyList_Append (list, inferior.get ()) ? 1 : 0; + return PyList_Append (list, (PyObject *) inferior.get ()) ? 1 : 0; } /* Implementation of gdb.inferiors () -> (gdb.Inferior, ...). @@ -848,7 +845,7 @@ infpy_thread_from_thread_handle (PyObject *self, PyObject *args, PyObject *kw) thread_info = find_thread_by_handle (val, inf_obj->inferior); if (thread_info != NULL) { - result = (PyObject *) find_thread_object (thread_info->ptid); + result = (PyObject *) thread_to_thread_object (thread_info); if (result != NULL) Py_INCREF (result); } @@ -910,7 +907,7 @@ py_free_inferior (struct inferior *inf, void *datum) PyObject * gdbpy_selected_inferior (PyObject *self, PyObject *args) { - return inferior_to_inferior_object (current_inferior ()); + return (PyObject *) inferior_to_inferior_object (current_inferior ()); } int diff --git a/gdb/python/py-infthread.c b/gdb/python/py-infthread.c index 9ed18a3..9b90ad5 100644 --- a/gdb/python/py-infthread.c +++ b/gdb/python/py-infthread.c @@ -46,7 +46,7 @@ create_thread_object (struct thread_info *tp) return NULL; thread_obj->thread = tp; - thread_obj->inf_obj = find_inferior_object (ptid_get_pid (tp->ptid)); + thread_obj->inf_obj = (PyObject *) inferior_to_inferior_object (tp->inf); return thread_obj; } @@ -179,7 +179,7 @@ thpy_switch (PyObject *self, PyObject *args) TRY { - switch_to_thread (thread_obj->thread->ptid); + switch_to_thread (thread_obj->thread); } CATCH (except, RETURN_MASK_ALL) { @@ -200,7 +200,7 @@ thpy_is_stopped (PyObject *self, PyObject *args) THPY_REQUIRE_VALID (thread_obj); - if (is_stopped (thread_obj->thread->ptid)) + if (thread_obj->thread->state == THREAD_STOPPED) Py_RETURN_TRUE; Py_RETURN_FALSE; @@ -216,7 +216,7 @@ thpy_is_running (PyObject *self, PyObject *args) THPY_REQUIRE_VALID (thread_obj); - if (is_running (thread_obj->thread->ptid)) + if (thread_obj->thread->state == THREAD_RUNNING) Py_RETURN_TRUE; Py_RETURN_FALSE; @@ -232,7 +232,7 @@ thpy_is_exited (PyObject *self, PyObject *args) THPY_REQUIRE_VALID (thread_obj); - if (is_exited (thread_obj->thread->ptid)) + if (thread_obj->thread->state == THREAD_EXITED) Py_RETURN_TRUE; Py_RETURN_FALSE; @@ -283,13 +283,15 @@ gdbpy_create_ptid_object (ptid_t ptid) PyObject * gdbpy_selected_thread (PyObject *self, PyObject *args) { - PyObject *thread_obj; - - thread_obj = (PyObject *) find_thread_object (inferior_ptid); - if (thread_obj) + if (inferior_ptid != null_ptid) { - Py_INCREF (thread_obj); - return thread_obj; + PyObject *thread_obj + = (PyObject *) thread_to_thread_object (inferior_thread ()); + if (thread_obj != NULL) + { + Py_INCREF (thread_obj); + return thread_obj; + } } Py_RETURN_NONE; diff --git a/gdb/python/py-record-btrace.c b/gdb/python/py-record-btrace.c index d78df7f..057475e 100644 --- a/gdb/python/py-record-btrace.c +++ b/gdb/python/py-record-btrace.c @@ -43,7 +43,7 @@ typedef struct { PyObject_HEAD /* The thread this list belongs to. */ - ptid_t ptid; + thread_info *thread; /* The first index being part of this list. */ Py_ssize_t first; @@ -82,7 +82,7 @@ btrace_insn_from_recpy_insn (const PyObject * const pyobject) } obj = (const recpy_element_object *) pyobject; - tinfo = find_thread_ptid (obj->ptid); + tinfo = obj->thread; if (tinfo == NULL || btrace_is_empty (tinfo)) { @@ -125,7 +125,7 @@ btrace_func_from_recpy_func (const PyObject * const pyobject) } obj = (const recpy_element_object *) pyobject; - tinfo = find_thread_ptid (obj->ptid); + tinfo = obj->thread; if (tinfo == NULL || btrace_is_empty (tinfo)) { @@ -153,7 +153,7 @@ btrace_func_from_recpy_func (const PyObject * const pyobject) gdb.RecordInstruction or gdb.RecordGap object for it accordingly. */ static PyObject * -btpy_insn_or_gap_new (const thread_info *tinfo, Py_ssize_t number) +btpy_insn_or_gap_new (thread_info *tinfo, Py_ssize_t number) { btrace_insn_iterator iter; int err_code; @@ -172,13 +172,13 @@ btpy_insn_or_gap_new (const thread_info *tinfo, Py_ssize_t number) return recpy_gap_new (err_code, err_string, number); } - return recpy_insn_new (tinfo->ptid, RECORD_METHOD_BTRACE, number); + return recpy_insn_new (tinfo, RECORD_METHOD_BTRACE, number); } /* Create a new gdb.BtraceList object. */ static PyObject * -btpy_list_new (ptid_t ptid, Py_ssize_t first, Py_ssize_t last, Py_ssize_t step, +btpy_list_new (thread_info *thread, Py_ssize_t first, Py_ssize_t last, Py_ssize_t step, PyTypeObject *element_type) { btpy_list_object * const obj = PyObject_New (btpy_list_object, @@ -187,7 +187,7 @@ btpy_list_new (ptid_t ptid, Py_ssize_t first, Py_ssize_t last, Py_ssize_t step, if (obj == NULL) return NULL; - obj->ptid = ptid; + obj->thread = thread; obj->first = first; obj->last = last; obj->step = step; @@ -344,7 +344,7 @@ recpy_bt_func_level (PyObject *self, void *closure) if (func == NULL) return NULL; - tinfo = find_thread_ptid (((recpy_element_object *) self)->ptid); + tinfo = ((recpy_element_object *) self)->thread; return PyInt_FromLong (tinfo->btrace.level + func->level); } @@ -383,7 +383,7 @@ recpy_bt_func_instructions (PyObject *self, void *closure) if (len == 0) len = 1; - return btpy_list_new (((recpy_element_object *) self)->ptid, + return btpy_list_new (((recpy_element_object *) self)->thread, func->insn_offset, func->insn_offset + len, 1, &recpy_insn_type); } @@ -402,7 +402,7 @@ recpy_bt_func_up (PyObject *self, void *closure) if (func->up == 0) Py_RETURN_NONE; - return recpy_func_new (((recpy_element_object *) self)->ptid, + return recpy_func_new (((recpy_element_object *) self)->thread, RECORD_METHOD_BTRACE, func->up); } @@ -420,7 +420,7 @@ recpy_bt_func_prev (PyObject *self, void *closure) if (func->prev == 0) Py_RETURN_NONE; - return recpy_func_new (((recpy_element_object *) self)->ptid, + return recpy_func_new (((recpy_element_object *) self)->thread, RECORD_METHOD_BTRACE, func->prev); } @@ -438,7 +438,7 @@ recpy_bt_func_next (PyObject *self, void *closure) if (func->next == 0) Py_RETURN_NONE; - return recpy_func_new (((recpy_element_object *) self)->ptid, + return recpy_func_new (((recpy_element_object *) self)->thread, RECORD_METHOD_BTRACE, func->next); } @@ -474,9 +474,9 @@ btpy_list_item (PyObject *self, Py_ssize_t index) number = obj->first + (obj->step * index); if (obj->element_type == &recpy_insn_type) - return recpy_insn_new (obj->ptid, RECORD_METHOD_BTRACE, number); + return recpy_insn_new (obj->thread, RECORD_METHOD_BTRACE, number); else - return recpy_func_new (obj->ptid, RECORD_METHOD_BTRACE, number); + return recpy_func_new (obj->thread, RECORD_METHOD_BTRACE, number); } /* Implementation of BtraceList.__getitem__ (self, slice) -> BtraceList. */ @@ -506,7 +506,7 @@ btpy_list_slice (PyObject *self, PyObject *value) &step, &slicelength)) return NULL; - return btpy_list_new (obj->ptid, obj->first + obj->step * start, + return btpy_list_new (obj->thread, obj->first + obj->step * start, obj->first + obj->step * stop, obj->step * step, obj->element_type); } @@ -524,7 +524,7 @@ btpy_list_position (PyObject *self, PyObject *value) if (list_obj->element_type != Py_TYPE (value)) return -1; - if (!ptid_equal (list_obj->ptid, obj->ptid)) + if (list_obj->thread != obj->thread) return -1; if (index < list_obj->first || index > list_obj->last) @@ -590,7 +590,7 @@ btpy_list_richcompare (PyObject *self, PyObject *other, int op) switch (op) { case Py_EQ: - if (ptid_equal (obj1->ptid, obj2->ptid) + if (obj1->thread == obj2->thread && obj1->element_type == obj2->element_type && obj1->first == obj2->first && obj1->last == obj2->last @@ -600,7 +600,7 @@ btpy_list_richcompare (PyObject *self, PyObject *other, int op) Py_RETURN_FALSE; case Py_NE: - if (!ptid_equal (obj1->ptid, obj2->ptid) + if (obj1->thread != obj2->thread || obj1->element_type != obj2->element_type || obj1->first != obj2->first || obj1->last != obj2->last @@ -633,7 +633,7 @@ PyObject * recpy_bt_format (PyObject *self, void *closure) { const recpy_record_object * const record = (recpy_record_object *) self; - const struct thread_info * const tinfo = find_thread_ptid (record->ptid); + const struct thread_info * const tinfo = record->thread; const struct btrace_config * config; if (tinfo == NULL) @@ -654,7 +654,7 @@ PyObject * recpy_bt_replay_position (PyObject *self, void *closure) { const recpy_record_object * const record = (recpy_record_object *) self; - const struct thread_info * const tinfo = find_thread_ptid (record->ptid); + thread_info * tinfo = record->thread; if (tinfo == NULL) Py_RETURN_NONE; @@ -673,7 +673,7 @@ PyObject * recpy_bt_begin (PyObject *self, void *closure) { const recpy_record_object * const record = (recpy_record_object *) self; - struct thread_info * const tinfo = find_thread_ptid (record->ptid); + thread_info *const tinfo = record->thread; struct btrace_insn_iterator iterator; if (tinfo == NULL) @@ -695,7 +695,7 @@ PyObject * recpy_bt_end (PyObject *self, void *closure) { const recpy_record_object * const record = (recpy_record_object *) self; - struct thread_info * const tinfo = find_thread_ptid (record->ptid); + thread_info *const tinfo = record->thread; struct btrace_insn_iterator iterator; if (tinfo == NULL) @@ -717,7 +717,7 @@ PyObject * recpy_bt_instruction_history (PyObject *self, void *closure) { const recpy_record_object * const record = (recpy_record_object *) self; - struct thread_info * const tinfo = find_thread_ptid (record->ptid); + thread_info *const tinfo = record->thread; struct btrace_insn_iterator iterator; unsigned long first = 0; unsigned long last = 0; @@ -736,7 +736,7 @@ recpy_bt_instruction_history (PyObject *self, void *closure) btrace_insn_end (&iterator, &tinfo->btrace); last = btrace_insn_number (&iterator); - return btpy_list_new (record->ptid, first, last, 1, &recpy_insn_type); + return btpy_list_new (tinfo, first, last, 1, &recpy_insn_type); } /* Implementation of @@ -746,7 +746,7 @@ PyObject * recpy_bt_function_call_history (PyObject *self, void *closure) { const recpy_record_object * const record = (recpy_record_object *) self; - struct thread_info * const tinfo = find_thread_ptid (record->ptid); + thread_info *const tinfo = record->thread; struct btrace_call_iterator iterator; unsigned long first = 0; unsigned long last = 0; @@ -765,7 +765,7 @@ recpy_bt_function_call_history (PyObject *self, void *closure) btrace_call_end (&iterator, &tinfo->btrace); last = btrace_call_number (&iterator); - return btpy_list_new (record->ptid, first, last, 1, &recpy_func_type); + return btpy_list_new (tinfo, first, last, 1, &recpy_func_type); } /* Implementation of BtraceRecord.goto (self, BtraceInstruction) -> None. */ @@ -774,7 +774,7 @@ PyObject * recpy_bt_goto (PyObject *self, PyObject *args) { const recpy_record_object * const record = (recpy_record_object *) self; - struct thread_info * const tinfo = find_thread_ptid (record->ptid); + thread_info *const tinfo = record->thread; const recpy_element_object *obj; if (tinfo == NULL || btrace_is_empty (tinfo)) diff --git a/gdb/python/py-record.c b/gdb/python/py-record.c index 9437cfb..b203786 100644 --- a/gdb/python/py-record.c +++ b/gdb/python/py-record.c @@ -23,6 +23,7 @@ #include "py-record-btrace.h" #include "py-record-full.h" #include "target.h" +#include "gdbthread.h" /* Python Record type. */ @@ -176,7 +177,7 @@ recpy_end (PyObject *self, void* closure) /* Create a new gdb.RecordInstruction object. */ PyObject * -recpy_insn_new (ptid_t ptid, enum record_method method, Py_ssize_t number) +recpy_insn_new (thread_info *thread, enum record_method method, Py_ssize_t number) { recpy_element_object * const obj = PyObject_New (recpy_element_object, &recpy_insn_type); @@ -184,7 +185,7 @@ recpy_insn_new (ptid_t ptid, enum record_method method, Py_ssize_t number) if (obj == NULL) return NULL; - obj->ptid = ptid; + obj->thread = thread; obj->method = method; obj->number = number; @@ -272,7 +273,7 @@ recpy_insn_is_speculative (PyObject *self, void *closure) /* Create a new gdb.RecordFunctionSegment object. */ PyObject * -recpy_func_new (ptid_t ptid, enum record_method method, Py_ssize_t number) +recpy_func_new (thread_info *thread, enum record_method method, Py_ssize_t number) { recpy_element_object * const obj = PyObject_New (recpy_element_object, &recpy_func_type); @@ -280,7 +281,7 @@ recpy_func_new (ptid_t ptid, enum record_method method, Py_ssize_t number) if (obj == NULL) return NULL; - obj->ptid = ptid; + obj->thread = thread; obj->method = method; obj->number = number; @@ -405,7 +406,7 @@ recpy_element_richcompare (PyObject *self, PyObject *other, int op) switch (op) { case Py_EQ: - if (ptid_equal (obj1->ptid, obj2->ptid) + if (obj1->thread == obj2->thread && obj1->method == obj2->method && obj1->number == obj2->number) Py_RETURN_TRUE; @@ -413,7 +414,7 @@ recpy_element_richcompare (PyObject *self, PyObject *other, int op) Py_RETURN_FALSE; case Py_NE: - if (!ptid_equal (obj1->ptid, obj2->ptid) + if (obj1->thread != obj2->thread || obj1->method != obj2->method || obj1->number != obj2->number) Py_RETURN_TRUE; @@ -626,8 +627,8 @@ gdbpy_current_recording (PyObject *self, PyObject *args) Py_RETURN_NONE; ret = PyObject_New (recpy_record_object, &recpy_record_type); - ret->ptid = inferior_ptid; - ret->method = target_record_method (inferior_ptid); + ret->thread = inferior_thread (); + ret->method = target_record_method (ret->thread->ptid); return (PyObject *) ret; } diff --git a/gdb/python/py-record.h b/gdb/python/py-record.h index 254ba9e..a24916d 100644 --- a/gdb/python/py-record.h +++ b/gdb/python/py-record.h @@ -29,8 +29,8 @@ typedef struct { PyObject_HEAD - /* The ptid this object refers to. */ - ptid_t ptid; + /* The thread this object refers to. */ + thread_info *thread; /* The current recording method. */ enum record_method method; @@ -43,8 +43,8 @@ typedef struct { PyObject_HEAD - /* The ptid this object refers to. */ - ptid_t ptid; + /* The thread this object refers to. */ + thread_info *thread; /* The current recording method. */ enum record_method method; @@ -60,11 +60,11 @@ extern PyTypeObject recpy_insn_type; extern PyTypeObject recpy_func_type; /* Create a new gdb.RecordInstruction object. */ -extern PyObject *recpy_insn_new (ptid_t ptid, enum record_method method, +extern PyObject *recpy_insn_new (thread_info *thread, enum record_method method, Py_ssize_t number); /* Create a new gdb.RecordFunctionSegment object. */ -extern PyObject *recpy_func_new (ptid_t ptid, enum record_method method, +extern PyObject *recpy_func_new (thread_info *thread, enum record_method method, Py_ssize_t number); /* Create a new gdb.RecordGap object. */ diff --git a/gdb/python/py-threadevent.c b/gdb/python/py-threadevent.c index 968a157..d6aa946 100644 --- a/gdb/python/py-threadevent.c +++ b/gdb/python/py-threadevent.c @@ -18,6 +18,7 @@ #include "defs.h" #include "py-event.h" #include "infrun.h" +#include "gdbthread.h" /* thread events can either be thread specific or process wide. If gdb is running in non-stop mode then the event is thread specific, otherwise @@ -31,10 +32,10 @@ static PyObject *get_event_thread (void) static PyObject * get_event_thread (void) { - PyObject *thread = NULL; + PyObject *thread; if (non_stop) - thread = (PyObject *) find_thread_object (inferior_ptid); + thread = (PyObject *) thread_to_thread_object (inferior_thread ()); else thread = Py_None; diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 495655e..c4f0e21 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -440,6 +440,8 @@ typedef struct PyObject *inf_obj; } thread_object; +struct inferior_object; + extern struct cmd_list_element *set_python_list; extern struct cmd_list_element *show_python_list; @@ -532,10 +534,9 @@ PyObject *gdbpy_lookup_objfile (PyObject *self, PyObject *args, PyObject *kw); PyObject *gdbarch_to_arch_object (struct gdbarch *gdbarch); thread_object *create_thread_object (struct thread_info *tp); -thread_object *find_thread_object (ptid_t ptid) - CPYCHECKER_RETURNS_BORROWED_REF; -PyObject *find_inferior_object (int pid); -PyObject *inferior_to_inferior_object (struct inferior *inferior); +thread_object *thread_to_thread_object (thread_info *thr) + CPYCHECKER_RETURNS_BORROWED_REF; +inferior_object *inferior_to_inferior_object (inferior *inf); const struct block *block_object_to_block (PyObject *obj); struct symbol *symbol_object_to_symbol (PyObject *obj); |