aboutsummaryrefslogtreecommitdiff
path: root/gdb/python
diff options
context:
space:
mode:
authorKeith Seitz <keiths@redhat.com>2015-08-12 11:31:24 -0700
committerKeith Seitz <keiths@redhat.com>2015-08-12 11:31:24 -0700
commit59ecaff36145add82c315ba7a008c4a5db4a6f51 (patch)
treebda4ab3d9310049e75b80c0645ff23b1adbfb949 /gdb/python
parentb46824bd49648c575372e6d9bc6a6defeabd6ed5 (diff)
downloadgdb-59ecaff36145add82c315ba7a008c4a5db4a6f51.zip
gdb-59ecaff36145add82c315ba7a008c4a5db4a6f51.tar.gz
gdb-59ecaff36145add82c315ba7a008c4a5db4a6f51.tar.bz2
Initialize `location' in gdbpy_decode_line
BuildBot flagged an uninitialized variable coming from one of the patches in my recently committed locations/explicit patchset. The following patch fixes this. gdb/ChangeLog * python/python.c (gdbpy_decode_line): Initialize `location' to NULL and only call decode_line_1 when it is non-NULL. diff --git a/gdb/python/python.c b/gdb/python/python.c index c28f98b..14da62c 100644 --- a/gdb/python/python.c +++ b/gdb/python/python.c @@ -730,7 +730,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args) PyObject *result = NULL; PyObject *return_result = NULL; PyObject *unparsed = NULL; - struct event_location *location; + struct event_location *location = NULL; if (! PyArg_ParseTuple (args, "|s", &arg)) return NULL; @@ -747,7 +747,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args) TRY { - if (arg) + if (location != NULL) sals = decode_line_1 (location, 0, 0, 0); else {
Diffstat (limited to 'gdb/python')
-rw-r--r--gdb/python/python.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/python/python.c b/gdb/python/python.c
index c28f98b..14da62c 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -730,7 +730,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args)
PyObject *result = NULL;
PyObject *return_result = NULL;
PyObject *unparsed = NULL;
- struct event_location *location;
+ struct event_location *location = NULL;
if (! PyArg_ParseTuple (args, "|s", &arg))
return NULL;
@@ -747,7 +747,7 @@ gdbpy_decode_line (PyObject *self, PyObject *args)
TRY
{
- if (arg)
+ if (location != NULL)
sals = decode_line_1 (location, 0, 0, 0);
else
{