diff options
| author | Tom Tromey <tom@tromey.com> | 2019-09-24 17:36:07 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-09-25 09:37:56 -0600 |
| commit | 858f25f0dd3c7013e4c87b95fa8edac223d26156 (patch) | |
| tree | df6f8df78087efc82bda224864035a94ab03a5f8 /gdb/python | |
| parent | 9a24a2763daa773328a788988048a7b3f344a548 (diff) | |
| download | gdb-858f25f0dd3c7013e4c87b95fa8edac223d26156.zip gdb-858f25f0dd3c7013e4c87b95fa8edac223d26156.tar.gz gdb-858f25f0dd3c7013e4c87b95fa8edac223d26156.tar.bz2 | |
Remove make_hex_string
I noticed that make_hex_string does essentially the same thing as
bin2hex, and furthermore is only called in a single spot. This patch
removes make_hex_string.
Tested by the builtbot.
gdb/ChangeLog
2019-09-25 Tom Tromey <tom@tromey.com>
* python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
* utils.h (make_hex_string): Don't declare.
* utils.c (make_hex_string): Remove.
Diffstat (limited to 'gdb/python')
| -rw-r--r-- | gdb/python/py-objfile.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/gdb/python/py-objfile.c b/gdb/python/py-objfile.c index 2c54845..517ed56 100644 --- a/gdb/python/py-objfile.c +++ b/gdb/python/py-objfile.c @@ -141,10 +141,9 @@ objfpy_get_build_id (PyObject *self, void *closure) if (build_id != NULL) { - gdb::unique_xmalloc_ptr<char> hex_form - (make_hex_string (build_id->data, build_id->size)); + std::string hex_form = bin2hex (build_id->data, build_id->size); - return host_string_to_python_string (hex_form.get ()).release (); + return host_string_to_python_string (hex_form.c_str ()).release (); } Py_RETURN_NONE; |