diff options
| author | Tom Tromey <tom@tromey.com> | 2016-05-18 21:41:28 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2016-05-24 09:55:01 -0600 |
| commit | 1957f6b89f3db02d51e3e3361de6af073a03f19d (patch) | |
| tree | f16c22933c767d6a756ad2c08b0f0c486de66e82 /gdb/python | |
| parent | 224f10c1ae5d815b6d2efddb479052b79ea4d256 (diff) | |
| download | gdb-1957f6b89f3db02d51e3e3361de6af073a03f19d.zip gdb-1957f6b89f3db02d51e3e3361de6af073a03f19d.tar.gz gdb-1957f6b89f3db02d51e3e3361de6af073a03f19d.tar.bz2 | |
Fix PR python/17981
PR python/17981 notes that gdb.breakpoints() returns None when there
are no breakpoints; whereas an empty list or tuple would be more in
keeping with Python and the documentation.
This patch fixes the bug by changing the no-breakpoint return to make
an empty tuple.
Built and regtested on x86-64 Fedora 23.
2016-05-23 Tom Tromey <tom@tromey.com>
PR python/17981:
* python/py-breakpoint.c (gdbpy_breakpoints): Return a new tuple
when there are no breakpoints.
2016-05-23 Tom Tromey <tom@tromey.com>
* python.texi (Basic Python): Document gdb.breakpoints return.
2016-05-23 Tom Tromey <tom@tromey.com>
PR python/17981:
* gdb.python/py-breakpoint.exp (test_bkpt_basic): Add test for
no-breakpoint case.
Diffstat (limited to 'gdb/python')
| -rw-r--r-- | gdb/python/py-breakpoint.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index 611a41e..ed9cae6 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -746,13 +746,13 @@ gdbpy_breakpoints (PyObject *self, PyObject *args) PyObject *list, *tuple; if (bppy_live == 0) - Py_RETURN_NONE; + return PyTuple_New (0); list = PyList_New (0); if (!list) return NULL; - /* If iteratre_over_breakpoints returns non NULL it signals an error + /* If iterate_over_breakpoints returns non NULL it signals an error condition. In that case abandon building the list and return NULL. */ if (iterate_over_breakpoints (build_bp_list, list) != NULL) |