diff options
| author | Tom Tromey <tromey@adacore.com> | 2021-07-08 11:45:55 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2021-08-02 10:48:29 -0600 |
| commit | 9698f7141065f5eaea44a17331b3f29ae712a79e (patch) | |
| tree | 1682e3ac88d8901feaab0815899c56f7b3e312dc /gdb/python/py-framefilter.c | |
| parent | ba8694b650b60c29126fd958575ffa1ca4f6c415 (diff) | |
| download | gdb-9698f7141065f5eaea44a17331b3f29ae712a79e.zip gdb-9698f7141065f5eaea44a17331b3f29ae712a79e.tar.gz gdb-9698f7141065f5eaea44a17331b3f29ae712a79e.tar.bz2 | |
Remove uses of fprintf_symbol_filtered
I believe that many calls to fprintf_symbol_filtered are incorrect.
In particular, there are some that pass a symbol's print name, like:
fprintf_symbol_filtered (gdb_stdout, sym->print_name (),
current_language->la_language, DMGL_ANSI);
fprintf_symbol_filtered uses the "demangle" global to decide whether
or not to demangle -- but print_name does this as well. This can lead
to double-demangling. Normally this could be innocuous, except I also
plan to change Ada demangling in a way that causes this to fail.
Diffstat (limited to 'gdb/python/py-framefilter.c')
| -rw-r--r-- | gdb/python/py-framefilter.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/gdb/python/py-framefilter.c b/gdb/python/py-framefilter.c index 54ac907..fd0b7f9 100644 --- a/gdb/python/py-framefilter.c +++ b/gdb/python/py-framefilter.c @@ -348,16 +348,12 @@ py_print_single_arg (struct ui_out *out, { string_file stb; - fprintf_symbol_filtered (&stb, fa->sym->print_name (), - fa->sym->language (), - DMGL_PARAMS | DMGL_ANSI); + fputs_filtered (fa->sym->print_name (), &stb); if (fa->entry_kind == print_entry_values_compact) { stb.puts ("="); - fprintf_symbol_filtered (&stb, fa->sym->print_name (), - fa->sym->language (), - DMGL_PARAMS | DMGL_ANSI); + fputs_filtered (fa->sym->print_name (), &stb); } if (fa->entry_kind == print_entry_values_only || fa->entry_kind == print_entry_values_compact) |