diff options
| author | Tom Tromey <tromey@redhat.com> | 2014-07-11 08:02:03 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2014-07-18 09:48:01 -0600 |
| commit | e75fdfcad1c868eae5396a95be9dd18010406306 (patch) | |
| tree | f97ac1c4bf5bd0775578a8e38e06f549a556b839 /gdb/procfs.c | |
| parent | 83814951ff9b8f73dcf7c860ad7b4f34a31f2be6 (diff) | |
| download | gdb-e75fdfcad1c868eae5396a95be9dd18010406306.zip gdb-e75fdfcad1c868eae5396a95be9dd18010406306.tar.gz gdb-e75fdfcad1c868eae5396a95be9dd18010406306.tar.bz2 | |
clean up some target delegation cases
This patch cleans up some minor inconsistencies in target delegation.
It's primary purpose is to avoid confusion in the code. A few spots
were checking the "beneath" target; however this can only be NULL for
the dummy target, so such tests are not needed. Some other spots were
iterating over the beneath targets, looking for a method
implementation. This is not needed for methods handled by
make-target-delegates, as there is always an implementation.
2014-07-18 Tom Tromey <tromey@redhat.com>
PR gdb/17130:
* spu-multiarch.c (spu_region_ok_for_hw_watchpoint)
(spu_fetch_registers, spu_store_registers, spu_xfer_partial)
(spu_search_memory, spu_mourn_inferior): Simplify delegation.
* linux-thread-db.c (thread_db_pid_to_str): Always delegate.
* windows-nat.c (windows_xfer_partial): Always delegate.
* record-btrace.c (record_btrace_xfer_partial): Simplify
delegation.
(record_btrace_fetch_registers, record_btrace_store_registers)
(record_btrace_prepare_to_store, record_btrace_resume)
(record_btrace_wait, record_btrace_find_new_threads)
(record_btrace_thread_alive): Likewise.
* procfs.c (procfs_xfer_partial): Always delegate.
* corelow.c (core_xfer_partial): Always delegate.
* sol-thread.c (sol_find_new_threads): Simplify delegation.
Diffstat (limited to 'gdb/procfs.c')
| -rw-r--r-- | gdb/procfs.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/gdb/procfs.c b/gdb/procfs.c index 4caaf7b..5075dcd 100644 --- a/gdb/procfs.c +++ b/gdb/procfs.c @@ -3993,11 +3993,9 @@ procfs_xfer_partial (struct target_ops *ops, enum target_object object, #endif default: - if (ops->beneath != NULL) - return ops->beneath->to_xfer_partial (ops->beneath, object, annex, - readbuf, writebuf, offset, len, - xfered_len); - return TARGET_XFER_E_IO; + return ops->beneath->to_xfer_partial (ops->beneath, object, annex, + readbuf, writebuf, offset, len, + xfered_len); } } |