diff options
author | Pedro Alves <palves@redhat.com> | 2018-05-03 00:37:26 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2018-05-03 00:51:30 +0100 |
commit | 57810aa7e8032c598897454daea14ed17df0f89d (patch) | |
tree | cd8e28930fdee347b23bb33773268f66444dca15 /gdb/procfs.c | |
parent | ad6a4e2dd69f9d343864181b638e166ff1458861 (diff) | |
download | gdb-57810aa7e8032c598897454daea14ed17df0f89d.zip gdb-57810aa7e8032c598897454daea14ed17df0f89d.tar.gz gdb-57810aa7e8032c598897454daea14ed17df0f89d.tar.bz2 |
target_ops: Use bool throughout
After the previous target_ops/C++ patches are all squashed and merged,
this one can go in separately.
This patch adjusts all the target methods to return bool instead of int
when they're returning a boolean.
gdb/ChangeLog:
2018-05-02 Pedro Alves <palves@redhat.com>
* target.h (target_ops)
<stopped_by_sw_breakpoint, supports_stopped_by_sw_breakpoint,
stopped_by_hw_breakpoint, supports_stopped_by_hw_breakpoint,
stopped_by_watchpoint, have_continuable_watchpoint,
stopped_data_address, watchpoint_addr_within_range,
can_accel_watchpoint_condition, can_run, thread_alive,
has_all_memory, has_memory, has_stack, has_registers,
has_execution, can_async_p, is_async_p, supports_non_stop,
always_non_stop_p, can_execute_reverse, supports_multi_process,
supports_enable_disable_tracepoint,
supports_disable_randomization, supports_string_tracing,
supports_evaluation_of_breakpoint_conditions,
can_run_breakpoint_commands, filesystem_is_local,
can_download_tracepoint, get_trace_state_variable_value,
set_trace_notes, get_tib_address, use_agent, can_use_agent,
record_is_replaying, record_will_replay,
augmented_libraries_svr4_read>: Adjust to return bool.
* aarch64-linux-nat.c: All implementations adjusted.
* aix-thread.c: All implementations adjusted.
* arm-linux-nat.c: All implementations adjusted.
* breakpoint.c: All implementations adjusted.
* bsd-kvm.c: All implementations adjusted.
* bsd-uthread.c: All implementations adjusted.
* corelow.c: All implementations adjusted.
* ctf.c: All implementations adjusted.
* darwin-nat.c: All implementations adjusted.
* darwin-nat.h: All implementations adjusted.
* exec.c: All implementations adjusted.
* fbsd-nat.c: All implementations adjusted.
* fbsd-nat.h: All implementations adjusted.
* gnu-nat.c: All implementations adjusted.
* gnu-nat.h: All implementations adjusted.
* go32-nat.c: All implementations adjusted.
* ia64-linux-nat.c: All implementations adjusted.
* inf-child.c: All implementations adjusted.
* inf-child.h: All implementations adjusted.
* inf-ptrace.c: All implementations adjusted.
* inf-ptrace.h: All implementations adjusted.
* linux-nat.c: All implementations adjusted.
* linux-nat.h: All implementations adjusted.
* mips-linux-nat.c: All implementations adjusted.
* nto-procfs.c: All implementations adjusted.
* ppc-linux-nat.c: All implementations adjusted.
* procfs.c: All implementations adjusted.
* ravenscar-thread.c: All implementations adjusted.
* record-btrace.c: All implementations adjusted.
* record-full.c: All implementations adjusted.
* remote-sim.c: All implementations adjusted.
* remote.c: All implementations adjusted.
* s390-linux-nat.c: All implementations adjusted.
* sol-thread.c: All implementations adjusted.
* spu-multiarch.c: All implementations adjusted.
* target-delegates.c: All implementations adjusted.
* target.c: All implementations adjusted.
* target.h: All implementations adjusted.
* tracefile-tfile.c: All implementations adjusted.
* tracefile.c: All implementations adjusted.
* tracefile.h: All implementations adjusted.
* windows-nat.c: All implementations adjusted.
* x86-linux-nat.h: All implementations adjusted.
* x86-nat.h: All implementations adjusted.
Diffstat (limited to 'gdb/procfs.c')
-rw-r--r-- | gdb/procfs.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/gdb/procfs.c b/gdb/procfs.c index abae358..749b2b4 100644 --- a/gdb/procfs.c +++ b/gdb/procfs.c @@ -124,7 +124,7 @@ public: void update_thread_list () override; - int thread_alive (ptid_t ptid) override; + bool thread_alive (ptid_t ptid) override; const char *pid_to_str (ptid_t) override; @@ -145,7 +145,7 @@ public: override; #endif - int stopped_by_watchpoint () override; + bool stopped_by_watchpoint () override; int insert_watchpoint (CORE_ADDR, int, enum target_hw_bp_type, struct expression *) override; @@ -156,7 +156,7 @@ public: int region_ok_for_hw_watchpoint (CORE_ADDR, int) override; int can_use_hw_breakpoint (enum bptype, int, int) override; - int stopped_data_address (CORE_ADDR *) override; + bool stopped_data_address (CORE_ADDR *) override; }; static procfs_target the_procfs_target; @@ -3179,7 +3179,7 @@ procfs_target::update_thread_list () really seem to be doing his job. Got to investigate how to tell when a thread is really gone. */ -int +bool procfs_target::thread_alive (ptid_t ptid) { int proc, thread; @@ -3189,18 +3189,18 @@ procfs_target::thread_alive (ptid_t ptid) thread = ptid_get_lwp (ptid); /* If I don't know it, it ain't alive! */ if ((pi = find_procinfo (proc, thread)) == NULL) - return 0; + return false; /* If I can't get its status, it ain't alive! What's more, I need to forget about it! */ if (!proc_get_status (pi)) { destroy_procinfo (pi); - return 0; + return false; } /* I couldn't have got its status if it weren't alive, so it's alive. */ - return 1; + return true; } /* Convert PTID to a string. Returns the string in a static @@ -3301,7 +3301,7 @@ procfs_target::can_use_hw_breakpoint (enum bptype type, int cnt, int othertype) /* Returns non-zero if process is stopped on a hardware watchpoint fault, else returns zero. */ -int +bool procfs_target::stopped_by_watchpoint () { procinfo *pi; @@ -3313,10 +3313,10 @@ procfs_target::stopped_by_watchpoint () if (proc_why (pi) == PR_FAULTED) { if (proc_what (pi) == FLTWATCH) - return 1; + return true; } } - return 0; + return false; } /* Returns 1 if the OS knows the position of the triggered watchpoint, @@ -3325,7 +3325,7 @@ procfs_target::stopped_by_watchpoint () procfs_stopped_by_watchpoint returned 1, thus no further checks are done. The function also assumes that ADDR is not NULL. */ -int +bool procfs_target::stopped_data_address (CORE_ADDR *addr) { procinfo *pi; |