diff options
| author | Tom Tromey <tom@tromey.com> | 2018-05-10 16:23:57 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2019-01-10 07:08:15 -0700 |
| commit | 8d7bcccb82d9a7efccd75d9552d007c62031e855 (patch) | |
| tree | 3092374c65dc9b2cbc2e30d561c0579b3aa2d61a /gdb/objfiles.c | |
| parent | b596a3c77da2387d7e5a3855717d65ce33bdfb58 (diff) | |
| download | gdb-8d7bcccb82d9a7efccd75d9552d007c62031e855.zip gdb-8d7bcccb82d9a7efccd75d9552d007c62031e855.tar.gz gdb-8d7bcccb82d9a7efccd75d9552d007c62031e855.tar.bz2 | |
Move psymtabs to their own obstack
Previously, the psymtab obstack was just a pointer to the objfile
obstack. This patch changes psymtabs to use their own obstack,
instead. A gdb::optional is used to avoid unnecessary allocation when
the obstack is not needed.
After this patch, the psymtab code lifetime model is that, in the core
psymtab code, objects allocated on the psymtab obstack may point to
other such objects, or to objects on the per-BFD obstack -- but never
to the objfile obstack.
Note however that this invariant is only obeyed the core psymtab code,
and even there not quite fully: there is still a link from the psymtab
to the full symtab.
Symbol readers are free to work however they like; and in particular,
even after this patch, in practice all symbol readers violate this
invariant via the read_symtab_private field.
gdb/ChangeLog
2019-01-10 Tom Tromey <tom@tromey.com>
* objfiles.h (objfile::reset_psymtabs): Update.
* objfiles.c (objfile::objfile): Update.
* psymtab.h (psymtab_storage::obstack): Update.
(psymtab_storage::m_obstack): Use gdb::optional.
(class psymtab_storage): Update comment. Remove objfile
parameter.
* psymtab.c (psymtab_storage::psymtab_storage): Update.
Diffstat (limited to 'gdb/objfiles.c')
| -rw-r--r-- | gdb/objfiles.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/objfiles.c b/gdb/objfiles.c index 3415448..255a3d6 100644 --- a/gdb/objfiles.c +++ b/gdb/objfiles.c @@ -369,7 +369,7 @@ build_objfile_section_table (struct objfile *objfile) objfile::objfile (bfd *abfd, const char *name, objfile_flags flags_) : flags (flags_), pspace (current_program_space), - partial_symtabs (new psymtab_storage (this)), + partial_symtabs (new psymtab_storage ()), obfd (abfd) { const char *expanded_name; |