aboutsummaryrefslogtreecommitdiff
path: root/gdb/nat
diff options
context:
space:
mode:
authorVyacheslav Barinov <v.barinov@samsung.com>2018-07-04 16:13:29 +0100
committerPedro Alves <palves@redhat.com>2018-07-04 16:13:29 +0100
commit1b919490e8ba30bf1d6941df0ed112b0e557017e (patch)
tree64d78f15a4de41831739f508ab170231b2c35ee4 /gdb/nat
parent94d401b8b88a76b1372ce44e805516756a4f737b (diff)
downloadgdb-1b919490e8ba30bf1d6941df0ed112b0e557017e.zip
gdb-1b919490e8ba30bf1d6941df0ed112b0e557017e.tar.gz
gdb-1b919490e8ba30bf1d6941df0ed112b0e557017e.tar.bz2
Warn if /proc is not accessiblegdb-8.2-branchpoint
There's a buildroot where I want to debug a binary, and I tried to connect to it from outside, but got very weird errors like architecture mismatch or protocol errors. At last, after switching on '--debug' for gdbserver I found a message 'Can't open /proc/pid/' message and suddenly found that I forgot to mount procfs in my buildroot. Make discovering the problem easier by making GDB / GDBserver warn (even without --debug) if /proc can not be accessed. Native debugging: (gdb) start Temporary breakpoint 1 at 0x400835: file test.c, line 10. Starting program: /tmp/test warning: /proc is not accessible. GDBserver/remote debugging: $ ./gdbserver :9999 ./gdbserver gdbserver: /proc is not accessible. gdb/ChangeLog: 2018-07-04 Vyacheslav Barinov <v.barinov@samsung.com> Pedro Alves <palves@redhat.com> * linux-nat.c (linux_init_ptrace): Rename to ... (linux_init_ptrace_procfs): ... this. Call linux_proc_init_warnings. (linux_nat_target::post_attach) (linux_nat_target::post_startup_inferior): Adjust. * nat/linux-procfs.c (linux_proc_init_warnings): Define function. * nat/linux-procfs.h (linux_proc_init_warnings): Declare function. gdb/gdbserver/ChangeLog: 2018-07-04 Vyacheslav Barinov <v.barinov@samsung.com> Pedro Alves <palves@redhat.com> * linux-low.c (initialize_low): Call linux_proc_init_warnings.
Diffstat (limited to 'gdb/nat')
-rw-r--r--gdb/nat/linux-procfs.c17
-rw-r--r--gdb/nat/linux-procfs.h5
2 files changed, 22 insertions, 0 deletions
diff --git a/gdb/nat/linux-procfs.c b/gdb/nat/linux-procfs.c
index 1c236c5..6c15ea5 100644
--- a/gdb/nat/linux-procfs.c
+++ b/gdb/nat/linux-procfs.c
@@ -357,3 +357,20 @@ linux_proc_pid_to_exec_file (int pid)
return buf;
}
+
+/* See linux-procfs.h. */
+
+void
+linux_proc_init_warnings ()
+{
+ static bool warned = false;
+
+ if (warned)
+ return;
+ warned = true;
+
+ struct stat st;
+
+ if (stat ("/proc/self", &st) != 0)
+ warning (_("/proc is not accessible."));
+}
diff --git a/gdb/nat/linux-procfs.h b/gdb/nat/linux-procfs.h
index efb2911..2f8932e 100644
--- a/gdb/nat/linux-procfs.h
+++ b/gdb/nat/linux-procfs.h
@@ -80,4 +80,9 @@ extern int linux_proc_task_list_dir_exists (pid_t pid);
extern char *linux_proc_pid_to_exec_file (int pid);
+/* Display possible problems on this system. Display them only once
+ per GDB execution. */
+
+extern void linux_proc_init_warnings ();
+
#endif /* COMMON_LINUX_PROCFS_H */