diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-10-01 06:52:44 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-10-02 13:43:41 -0600 |
| commit | 80fd2826411c1033ec403658c5f3187bf9c1740a (patch) | |
| tree | 7f5b7411ebaee9dbd719e0f6e0f2c0667c8f1dd6 /gdb/nat | |
| parent | 700545387df82388b054947dc74cc0bb5cbd2a60 (diff) | |
| download | gdb-80fd2826411c1033ec403658c5f3187bf9c1740a.zip gdb-80fd2826411c1033ec403658c5f3187bf9c1740a.tar.gz gdb-80fd2826411c1033ec403658c5f3187bf9c1740a.tar.bz2 | |
Fix type of startup_with_shell in gdbserver
startup_with_shell was changed to be of "bool" type, but I noticed
that the definition in gdbserver disagreed. This disagreement caused
some regressions on a big-endian machine.
This patch removes the redundant declaration and definition of
startup_with_shell and ensures that such clashes will be diagnosed.
This moves the declaration to common-inferior.h, and introduces a new
common-inferior.c, as suggested by Pedro.
gdb/ChangeLog
2019-10-02 Tom Tromey <tromey@adacore.com>
* Makefile.in (COMMON_SFILES): Add common-inferior.c.
* gdbsupport/common-inferior.c: New file.
* infcmd.c (startup_with_shell): Don't define.
* nat/fork-inferior.h (startup_with_shell): Don't declare.
* gdbsupport/common-inferior.h (startup_with_shell): Declare.
* inferior.h (startup_with_shell): Don't declare.
gdb/gdbserver/ChangeLog
2019-10-02 Tom Tromey <tromey@adacore.com>
* Makefile.in (SFILES): Add common-inferior.c.
(OBS): Add common-inferior.o.
* server.c (startup_with_shell): Don't define.
Diffstat (limited to 'gdb/nat')
| -rw-r--r-- | gdb/nat/fork-inferior.h | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/gdb/nat/fork-inferior.h b/gdb/nat/fork-inferior.h index 065496c..0a76ff8 100644 --- a/gdb/nat/fork-inferior.h +++ b/gdb/nat/fork-inferior.h @@ -54,26 +54,6 @@ extern ptid_t startup_inferior (pid_t pid, int ntraps, struct target_waitstatus *mystatus, ptid_t *myptid); -/* Whether to start up the debuggee under a shell. - - If startup-with-shell is set, GDB's "run" will attempt to start up - the debuggee under a shell. This also happens when using GDBserver - under extended remote mode. - - This is in order for argument-expansion to occur. E.g., - - (gdb) run * - - The "*" gets expanded by the shell into a list of files. - - While this is a nice feature, it may be handy to bypass the shell - in some cases. To disable this feature, do "set startup-with-shell - false". - - The catch-exec traps expected during start-up will be one more if - the target is started up with a shell. */ -extern bool startup_with_shell; - /* Perform any necessary tasks before a fork/vfork takes place. ARGS is a string containing all the arguments received by the inferior. This function is mainly used by fork_inferior. */ |