aboutsummaryrefslogtreecommitdiff
path: root/gdb/nat
diff options
context:
space:
mode:
authorSzabolcs Nagy <szabolcs.nagy@arm.com>2018-12-13 17:47:17 +0000
committerSzabolcs Nagy <szabolcs.nagy@arm.com>2018-12-17 10:34:26 +0000
commit51b4f73a37c2e7eec31e932fc3c8dae879735f63 (patch)
tree7f6740d305d90bf7fee67448030fd6087200ac1a /gdb/nat
parent4ef5dbe493310e3632354d4937727a755c13c291 (diff)
downloadgdb-51b4f73a37c2e7eec31e932fc3c8dae879735f63.zip
gdb-51b4f73a37c2e7eec31e932fc3c8dae879735f63.tar.gz
gdb-51b4f73a37c2e7eec31e932fc3c8dae879735f63.tar.bz2
AArch64: Fix the gdb build with musl libc
Including asm/sigcontext.h together with libc headers is not valid. In general linux headers may not work with libc headers, so mixing them should be avoided, especially when the linux header defines types that are also exposed in libc headers. In case of asm/sigcontext.h glibc happens to work because glibc signal.h directly includes it, but e.g. in musl libc signal.h replicates the sigcontext.h definitions in an abi compatible way which are in conflict with the linux definitions when both headers are included. Since old linux headers or old libc headers may not have the necessary definitions, gdb has to replicate the definitions it relies on anyway. Which is fine since all definitions must be ABI stable. For linux apis that are not available via libc headers, replicating the definitions in gdb is the most reliable way to use them. Note: asm/ptrace.h includes asm/sigcontext.h in some versions of linux headers, which is just as problematic and should be fixed in linux. gdb/ChangeLog: * nat/aarch64-sve-linux-ptrace.h: Include signal.h instead of asm/sigcontext.h.
Diffstat (limited to 'gdb/nat')
-rw-r--r--gdb/nat/aarch64-sve-linux-ptrace.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/nat/aarch64-sve-linux-ptrace.h b/gdb/nat/aarch64-sve-linux-ptrace.h
index 029e753..172ae39 100644
--- a/gdb/nat/aarch64-sve-linux-ptrace.h
+++ b/gdb/nat/aarch64-sve-linux-ptrace.h
@@ -20,7 +20,7 @@
#ifndef AARCH64_SVE_LINUX_PTRACE_H
#define AARCH64_SVE_LINUX_PTRACE_H
-#include <asm/sigcontext.h>
+#include <signal.h>
#include <sys/utsname.h>
#include <sys/ptrace.h>
#include <asm/ptrace.h>