diff options
| author | Tom Tromey <tom@tromey.com> | 2021-12-26 13:41:36 -0700 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2021-12-29 10:40:10 -0700 |
| commit | d68510ac191cb8b4b662a5fd1f3bcf9f4b136971 (patch) | |
| tree | ab8d361f18255facf28e086d9a102515e123fa13 /gdb/moxie-tdep.c | |
| parent | 0fed74615b0f263c359a13a7a17ade36a986ddd1 (diff) | |
| download | gdb-d68510ac191cb8b4b662a5fd1f3bcf9f4b136971.zip gdb-d68510ac191cb8b4b662a5fd1f3bcf9f4b136971.tar.gz gdb-d68510ac191cb8b4b662a5fd1f3bcf9f4b136971.tar.bz2 | |
Use correct stream for process record output
The process record code often emits unfiltered output. In some cases,
this output ought to go to gdb_stderr (but see below). In other
cases, the output is guarded by a logging variable and so ought to go
to gdb_stdlog. This patch makes these changes.
Note that in many cases, the output to stderr is followed by a
"return -1", which is how process record indicates an error. It seems
to me that calling error here would be preferable, because, in many
cases, that's all the caller does when it sees a -1. However, I
haven't made this change.
This is part of PR gdb/7233.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=7233
Diffstat (limited to 'gdb/moxie-tdep.c')
| -rw-r--r-- | gdb/moxie-tdep.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/gdb/moxie-tdep.c b/gdb/moxie-tdep.c index 459bfb8..949a18d 100644 --- a/gdb/moxie-tdep.c +++ b/gdb/moxie-tdep.c @@ -279,9 +279,10 @@ moxie_process_readu (CORE_ADDR addr, gdb_byte *buf, if (target_read_memory (addr, buf, length)) { if (record_debug) - printf_unfiltered (_("Process record: error reading memory at " - "addr 0x%s len = %d.\n"), - paddress (target_gdbarch (), addr), length); + fprintf_unfiltered (gdb_stderr, + _("Process record: error reading memory at " + "addr 0x%s len = %d.\n"), + paddress (target_gdbarch (), addr), length); return -1; } |