diff options
author | Tom Tromey <tom@tromey.com> | 2017-09-10 14:19:19 -0600 |
---|---|---|
committer | Tom Tromey <tom@tromey.com> | 2017-09-11 15:46:12 -0600 |
commit | f1735a53a63040cc4b4a735bf18a3f20d308e519 (patch) | |
tree | ed2e6da354b27e174e0617a15c18a193fbaa8497 /gdb/mi | |
parent | 7d221d749c0239f06ca571be6c9452cd22b5d582 (diff) | |
download | gdb-f1735a53a63040cc4b4a735bf18a3f20d308e519.zip gdb-f1735a53a63040cc4b4a735bf18a3f20d308e519.tar.gz gdb-f1735a53a63040cc4b4a735bf18a3f20d308e519.tar.bz2 |
Rename _const functions to use overloading instead
This renames a few functions -- skip_spaces_const,
skip_to_space_const, get_number_const, extract_arg_const -- to drop
the "_const" suffix and instead rely on overloading.
This makes future const fixes simpler by reducing the number of lines
that must be changed. I think it is also not any less clear, as all
these functions have the same interface as their non-const versions by
design. Furthermore there's an example of using an overload in-tree
already, namely check_for_argument.
This patch was largely created using some perl one-liners; then a few
fixes were applied by hand.
ChangeLog
2017-09-11 Tom Tromey <tom@tromey.com>
* common/common-utils.h (skip_to_space): Remove macro, redeclare
as function.
(skip_to_space): Rename from skip_to_space_const.
* common/common-utils.c (skip_to_space): New function.
(skip_to_space): Rename from skip_to_space_const.
* cli/cli-utils.h (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
* cli/cli-utils.c (get_number): Rename from get_number_const.
(extract_arg): Rename from extract_arg_const.
(number_or_range_parser::get_number): Use ::get_number.
* aarch64-linux-tdep.c, ada-lang.c, arm-linux-tdep.c, ax-gdb.c,
break-catch-throw.c, breakpoint.c, cli/cli-cmds.c, cli/cli-dump.c,
cli/cli-script.c, cli/cli-setshow.c, compile/compile.c,
completer.c, demangle.c, disasm.c, findcmd.c, linespec.c,
linux-tdep.c, linux-thread-db.c, location.c, mi/mi-parse.c,
minsyms.c, nat/linux-procfs.c, printcmd.c, probe.c,
python/py-breakpoint.c, record.c, rust-exp.y, serial.c, stack.c,
stap-probe.c, tid-parse.c, tracepoint.c: Update all callers.
Diffstat (limited to 'gdb/mi')
-rw-r--r-- | gdb/mi/mi-parse.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/gdb/mi/mi-parse.c b/gdb/mi/mi-parse.c index fea85d5..ad1478e 100644 --- a/gdb/mi/mi-parse.c +++ b/gdb/mi/mi-parse.c @@ -119,7 +119,7 @@ mi_parse_argv (const char *args, struct mi_parse *parse) char *arg; /* Skip leading white space. */ - chp = skip_spaces_const (chp); + chp = skip_spaces (chp); /* Three possibilities: EOF, quoted string, or other text. */ switch (*chp) { @@ -242,7 +242,7 @@ mi_parse (const char *cmd, char **token) std::unique_ptr<struct mi_parse> parse (new struct mi_parse); /* Before starting, skip leading white space. */ - cmd = skip_spaces_const (cmd); + cmd = skip_spaces (cmd); /* Find/skip any token and then extract it. */ for (chp = cmd; *chp >= '0' && *chp <= '9'; chp++) @@ -254,7 +254,7 @@ mi_parse (const char *cmd, char **token) /* This wasn't a real MI command. Return it as a CLI_COMMAND. */ if (*chp != '-') { - chp = skip_spaces_const (chp); + chp = skip_spaces (chp); parse->command = xstrdup (chp); parse->op = CLI_COMMAND; @@ -279,7 +279,7 @@ mi_parse (const char *cmd, char **token) _("Undefined MI command: %s"), parse->command); /* Skip white space following the command. */ - chp = skip_spaces_const (chp); + chp = skip_spaces (chp); /* Parse the --thread and --frame options, if present. At present, some important commands, like '-break-*' are implemented by @@ -352,7 +352,7 @@ mi_parse (const char *cmd, char **token) option = "--language"; chp += ls; - lang_name = extract_arg_const (&chp); + lang_name = extract_arg (&chp); old_chain = make_cleanup (xfree, lang_name); parse->language = language_enum (lang_name); @@ -367,7 +367,7 @@ mi_parse (const char *cmd, char **token) if (*chp != '\0' && !isspace (*chp)) error (_("Invalid value for the '%s' option"), option); - chp = skip_spaces_const (chp); + chp = skip_spaces (chp); } /* For new argv commands, attempt to return the parsed argument |