diff options
| author | Tom Tromey <tom@tromey.com> | 2018-05-03 16:36:20 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-07-26 09:18:31 -0600 |
| commit | 52948f01e4a11f5fcebdca112036f907ac69e7ad (patch) | |
| tree | 08a69f99c3f028772c5f52690094d3d3c0f2ee47 /gdb/mdebugread.c | |
| parent | 4ae976d1df96aee0ecd97ea1235efc4490562932 (diff) | |
| download | gdb-52948f01e4a11f5fcebdca112036f907ac69e7ad.zip gdb-52948f01e4a11f5fcebdca112036f907ac69e7ad.tar.gz gdb-52948f01e4a11f5fcebdca112036f907ac69e7ad.tar.bz2 | |
Add validity bits for psymtab high and low fields
Right now some psymtab code checks whether a psymtab's textlow or
texthigh fields are valid by comparing against 0.
I imagine this is mildly wrong in the current environment, but once
psymtabs are relocated dynamically, it will no longer be correct,
because it will be much more normal to see a psymtab with a textlow of
zero -- this will just mean it appears at the start of the text
section.
This patch introduces validity bits to handle this situation more
nicely, and changes users of the code to follow.
gdb/ChangeLog
2018-07-26 Tom Tromey <tromey@redhat.com>
* dbxread.c (end_psymtab): Use text_high_valid and
text_low_valid.
* mdebugread.c (parse_partial_symbols): Use text_low_valid.
(psymtab_to_symtab_1): Use text_high_valid and text_low_valid.
* psympriv.h (struct partial_symtab) <m_text_low, m_text_high>:
Update comment.
<text_low_valid, text_high_valid>: New fields.
<set_text_low, set_text_high>: Update.
* xcoffread.c (scan_xcoff_symtab): Use text_low_valid.
Diffstat (limited to 'gdb/mdebugread.c')
| -rw-r--r-- | gdb/mdebugread.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gdb/mdebugread.c b/gdb/mdebugread.c index 262c619..436ef95 100644 --- a/gdb/mdebugread.c +++ b/gdb/mdebugread.c @@ -2736,7 +2736,7 @@ parse_partial_symbols (minimal_symbol_reader &reader, /* Kludge for Irix 5.2 zero fh->adr. */ if (!relocatable - && (pst->text_low () == 0 + && (!pst->text_low_valid || procaddr < pst->text_low ())) pst->set_text_low (procaddr); if (high > pst->text_high ()) @@ -3512,7 +3512,7 @@ parse_partial_symbols (minimal_symbol_reader &reader, /* Kludge for Irix 5.2 zero fh->adr. */ if (!relocatable - && (pst->text_low () == 0 + && (!pst->text_low_valid || procaddr < pst->text_low ())) pst->set_text_low (procaddr); @@ -3711,7 +3711,7 @@ parse_partial_symbols (minimal_symbol_reader &reader, other cases. */ save_pst = fdr_to_pst[f_idx].pst; if (save_pst != NULL - && save_pst->text_low () != 0 + && save_pst->text_low_valid && !(objfile->flags & OBJF_REORDERED)) { ALL_OBJFILE_PSYMTABS (objfile, pst) @@ -3922,7 +3922,7 @@ psymtab_to_symtab_1 (struct objfile *objfile, /* Do nothing if this is a dummy psymtab. */ if (pst->n_global_syms == 0 && pst->n_static_syms == 0 - && pst->text_low () == 0 && pst->text_high () == 0) + && !pst->text_low_valid && !pst->text_high_valid) return; /* Now read the symbols for this symtab. */ |