diff options
author | Pedro Alves <palves@redhat.com> | 2015-12-17 14:20:52 +0000 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2015-12-17 14:23:28 +0000 |
commit | a6904d5a6aa63e4bef7207407250d8b76b56f8a9 (patch) | |
tree | e4651001446dda94d8b8f04382b7b916028cb5ff /gdb/linux-nat.c | |
parent | 4a6ed09b0f70c79b11bc1e0973a7333d9316a287 (diff) | |
download | gdb-a6904d5a6aa63e4bef7207407250d8b76b56f8a9.zip gdb-a6904d5a6aa63e4bef7207407250d8b76b56f8a9.tar.gz gdb-a6904d5a6aa63e4bef7207407250d8b76b56f8a9.tar.bz2 |
Fix PR threads/19354: "info threads" error with multiple inferiors
Note: this applies on top of:
[PATCH] Remove support for LinuxThreads and vendor 2.4 kernels w/ backported NPTL
https://sourceware.org/ml/gdb-patches/2015-12/msg00214.html
We try to avoid using libthread_db.so to list threads in the inferior
when debugging live processes, but the code that decides whether to
use it decides incorrectly if you have more than one inferior, and the
current inferior doesn't have execution yet. The result is visible
as:
(gdb) add-inferior
Added inferior 2
(gdb) inferior 2
[Switching to inferior 2 [<null>] (<noexec>)]
(gdb) info inferiors
Num Description Executable
1 process 15397 /home/pedro/gdb/tests/threads
* 2 <null>
(gdb) info threads
Cannot find new threads: generic error
(gdb)
Fix this by checking whether each inferior has execution rather than
just the current inferior.
By moving the core updating to linux-nat.c's update_thread_list
implementation, this also ends up fixing the
lwp-last-seen-running-on-core updating in the case we're debugging a
program that uses raw clone rather than pthreads, as linux-thread-db.c
isn't pushed in the target stack in that scenario.
Tested on x86_64 Fedora 20.
gdb/ChangeLog:
2015-12-17 Pedro Alves <palves@redhat.com>
PR threads/19354
* linux-nat.c (linux_nat_update_thread_list): Update process cores
each lwp was last seen running on here.
* linux-thread-db.c (update_thread_core): Delete.
(thread_db_update_thread_list_td_ta_thr_iter): Rename to ...
(thread_db_update_thread_list): ... this. Skip inferiors with
execution. Also call the target beneath.
(thread_db_update_thread_list): Delete.
gdb/testsuite/ChangeLog:
2015-12-17 Pedro Alves <palves@redhat.com>
PR threads/19354
* gdb.multi/info-threads.exp: New file.
Diffstat (limited to 'gdb/linux-nat.c')
-rw-r--r-- | gdb/linux-nat.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index af1b764..1f9bb47 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -3719,10 +3719,17 @@ linux_nat_thread_alive (struct target_ops *ops, ptid_t ptid) static void linux_nat_update_thread_list (struct target_ops *ops) { + struct lwp_info *lwp; + /* We add/delete threads from the list as clone/exit events are processed, so just try deleting exited threads still in the thread list. */ delete_exited_threads (); + + /* Update the processor core that each lwp/thread was last seen + running on. */ + ALL_LWPS (lwp) + lwp->core = linux_common_core_of_thread (lwp->ptid); } static char * |