diff options
| author | Pedro Alves <palves@redhat.com> | 2013-10-24 16:10:05 +0100 |
|---|---|---|
| committer | Tom Tromey <tromey@sourceware.org> | 2013-10-25 14:02:59 +0000 |
| commit | 98882a26513e25b2161b41dfd4bed97b59b2c01a (patch) | |
| tree | b93c6f85e6e42780f974f82faff02d1eaf9d6db5 /gdb/infcmd.c | |
| parent | c9737c08e7f804dfa80f71b74cb5678d0b69308e (diff) | |
| download | gdb-98882a26513e25b2161b41dfd4bed97b59b2c01a.zip gdb-98882a26513e25b2161b41dfd4bed97b59b2c01a.tar.gz gdb-98882a26513e25b2161b41dfd4bed97b59b2c01a.tar.bz2 | |
Make STARTUP_WITH_SHELL a runtime toggle -- add new "set/show startup-with-shell" option.
Occasionaly we hear about people having problems with GDB not being
able to start programs (with "run"/"start"). GDB spawns a shell to
start the program, and most often, it'll be the case that the problem
is actually with the user's shell setup.
GDB has code to disable the use of the shell to start programs.
That's the STARTUP_WITH_SHELL macro that native targets could set to 0
in their nm.h file (though no target actually uses it nowadays).
This patch makes that setting a run-time knob instead. This will be
useful to quickly diagnose such shell issues, and might also come in
handy at other times (such as when debugging the shell itself, if you
don't have a different shell handy).
gdb/
2013-10-24 Pedro Alves <palves@redhat.com>
* NEWS (New options): Mention set/show startup-with-shell.
* config/alpha/nm-osf3.h (START_INFERIOR_TRAPS_EXPECTED): Set to 2
instead of 3.
* fork-child.c (fork_inferior, startup_inferior): Handle 'set
startup-with-shell'.
(show_startup_with_shell): New function.
(_initialize_fork_child): Register the set/show startup-with-shell
commands.
* inf-ptrace.c (inf_ptrace_create_inferior): Remove comment.
* inf-ttrace.c (inf_ttrace_him): Remove comment.
* procfs.c (procfs_init_inferior): Remove comment.
* infcmd.c (startup_with_shell): New global.
* inferior.h (startup_with_shell): Declare global.
(STARTUP_WITH_SHELL): Delete.
(START_INFERIOR_TRAPS_EXPECTED): Set to 1 by default instead of 2.
gdb/doc/
2013-10-24 Pedro Alves <palves@redhat.com>
* gdb.texinfo (Starting): Document set/show startup-with-shell.
Diffstat (limited to 'gdb/infcmd.c')
| -rw-r--r-- | gdb/infcmd.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 20f8857..4ad8ad3 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -147,6 +147,10 @@ enum stop_stack_kind stop_stack_dummy; int stopped_by_random_signal; +/* See inferior.h. */ + +int startup_with_shell = 1; + /* Accessor routines. */ @@ -255,7 +259,7 @@ construct_inferior_arguments (int argc, char **argv) { char *result; - if (STARTUP_WITH_SHELL) + if (startup_with_shell) { #ifdef __MINGW32__ /* This holds all the characters considered special to the |