diff options
| author | Jan Kratochvil <jan.kratochvil@redhat.com> | 2010-02-15 17:35:50 +0000 |
|---|---|---|
| committer | Jan Kratochvil <jan.kratochvil@redhat.com> | 2010-02-15 17:35:50 +0000 |
| commit | 74164c5624c276e97cf9cb01876ef908745cd185 (patch) | |
| tree | 8c1a196ff9b052b0f8adda3aa6b0d4b045d0aada /gdb/inf-ptrace.c | |
| parent | 01a8201190286f181bea5731495123ea465c6251 (diff) | |
| download | gdb-74164c5624c276e97cf9cb01876ef908745cd185.zip gdb-74164c5624c276e97cf9cb01876ef908745cd185.tar.gz gdb-74164c5624c276e97cf9cb01876ef908745cd185.tar.bz2 | |
gdb/
* defs.h (parse_pid_to_attach): New.
* utils.c (parse_pid_to_attach): New.
* darwin-nat.c (darwin_attach): Replace ARGS parsing by parse_pid.
* gnu-nat.c (gnu_attach): Likewise.
* nto-procfs.c (procfs_attach): Likewise.
* procfs.c (procfs_attach): Likewise.
* windows-nat.c (windows_attach): Likewise.
* inf-ptrace.c (inf_ptrace_attach): Likewise. Remove variable dummy.
* inf-ttrace.c (inf_ttrace_attach): Likewise.
* remote.c (extended_remote_attach_1): Likewise. New comment on getpid
check.
gdb/testsuite/
* gdb.base/attach.exp (attach to nonsense is prohibited): Make the
"Illegal process-id" expect string more exact.
(attach to digits-starting nonsense is prohibited): New.
Diffstat (limited to 'gdb/inf-ptrace.c')
| -rw-r--r-- | gdb/inf-ptrace.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/gdb/inf-ptrace.c b/gdb/inf-ptrace.c index f8050d4..ba9d8a8 100644 --- a/gdb/inf-ptrace.c +++ b/gdb/inf-ptrace.c @@ -187,17 +187,9 @@ inf_ptrace_attach (struct target_ops *ops, char *args, int from_tty) { char *exec_file; pid_t pid; - char *dummy; struct inferior *inf; - if (!args) - error_no_arg (_("process-id to attach")); - - dummy = args; - pid = strtol (args, &dummy, 0); - /* Some targets don't set errno on errors, grrr! */ - if (pid == 0 && args == dummy) - error (_("Illegal process-id: %s."), args); + pid = parse_pid_to_attach (args); if (pid == getpid ()) /* Trying to masturbate? */ error (_("I refuse to debug myself!")); |