diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2022-10-03 11:15:14 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2023-01-05 14:38:51 -0500 |
| commit | 2b16913cdca20ae1dafdbd816b025a6efdc6c06f (patch) | |
| tree | e1b7e91c6e5f57f605ea37cf868f4987eedf078e /gdb/i386-tdep.c | |
| parent | cabd67874a6ef7aaed41490d9eaddc4a4869a452 (diff) | |
| download | gdb-2b16913cdca20ae1dafdbd816b025a6efdc6c06f.zip gdb-2b16913cdca20ae1dafdbd816b025a6efdc6c06f.tar.gz gdb-2b16913cdca20ae1dafdbd816b025a6efdc6c06f.tar.bz2 | |
gdb: make gdbarch_alloc take ownership of the tdep
It's currently not clear how the ownership of gdbarch_tdep objects
works. In fact, nothing ever takes ownership of it. This is mostly
fine because we never free gdbarch objects, and thus we never free
gdbarch_tdep objects. There is an exception to that however: when
initialization fails, we do free the gdbarch object that is not going to
be used, and we free the tdep too. Currently, i386 and s390 do it.
To make things clearer, change gdbarch_alloc so that it takes ownership
of the tdep. The tdep is thus automatically freed if the gdbarch is
freed.
Change all gdbarch initialization functions to pass a new gdbarch_tdep
object to gdbarch_alloc and then retrieve a non-owning reference from
the gdbarch object.
Before this patch, the xtensa architecture had a single global instance
of xtensa_gdbarch_tdep. Since we need to pass a dynamically allocated
gdbarch_tdep_base instance to gdbarch_alloc, remove this global
instance, and dynamically allocate one as needed, like we do for all
other architectures. Make the `rmap` array externally visible and
rename it to the less collision-prone `xtensa_rmap` name.
Change-Id: Id3d70493ef80ce4bdff701c57636f4c79ed8aea2
Approved-By: Andrew Burgess <aburgess@redhat.com>
Diffstat (limited to 'gdb/i386-tdep.c')
| -rw-r--r-- | gdb/i386-tdep.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index dc3cbed..580664d 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -8452,7 +8452,6 @@ i386_type_align (struct gdbarch *gdbarch, struct type *type) static struct gdbarch * i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) { - struct gdbarch *gdbarch; const struct target_desc *tdesc; int mm0_regnum; int ymm0_regnum; @@ -8465,8 +8464,9 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) return arches->gdbarch; /* Allocate space for the new architecture. Assume i386 for now. */ - i386_gdbarch_tdep *tdep = new i386_gdbarch_tdep; - gdbarch = gdbarch_alloc (&info, tdep); + gdbarch *gdbarch + = gdbarch_alloc (&info, gdbarch_tdep_up (new i386_gdbarch_tdep)); + i386_gdbarch_tdep *tdep = gdbarch_tdep<i386_gdbarch_tdep> (gdbarch); /* General-purpose registers. */ tdep->gregset_reg_offset = NULL; @@ -8709,7 +8709,6 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) if (!i386_validate_tdesc_p (tdep, tdesc_data.get ())) { - delete tdep; gdbarch_free (gdbarch); return NULL; } |