diff options
| author | Pedro Alves <palves@redhat.com> | 2010-02-22 23:35:17 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2010-02-22 23:35:17 +0000 |
| commit | 85d721b88f7efe93142bb8aa8de6f5181830d1dc (patch) | |
| tree | 4b1400e76058dff90370a63a36fe88680ba41d39 /gdb/i386-nat.c | |
| parent | 4c7f0517f37d925f3e1174cef660bef7e102695c (diff) | |
| download | gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.zip gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.tar.gz gdb-85d721b88f7efe93142bb8aa8de6f5181830d1dc.tar.bz2 | |
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/
* breakpoint.c (insert_bp_location): If inserting the read
watchpoint failed, fallback to an access watchpoint.
(bpstat_check_watchpoint): Stop for read watchpoint triggers even
if the value changed, if not watching the same memory for writes.
(watchpoint_locations_match): Add comment.
(update_global_location_list): Copy the location's watchpoint type.
* i386-nat.c (i386_length_and_rw_bits): It's an internal error to
handle read watchpoints here.
(i386_insert_watchpoint): Read watchpoints aren't supported.
* remote.c (remote_insert_watchpoint): Return 1 for unsupported
packets.
* target.h (target_insert_watchpoint): Update description.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdbserver/
* i386-low.c (i386_length_and_rw_bits): Throw a fatal error if
handing a read watchpoint.
(i386_low_insert_watchpoint): Read watchpoints aren't supported.
2010-02-22 Pedro Alves <pedro@codesourcery.com>
PR9605
gdb/testsuite/
* gdb.base/watch-read.c, gdb.base/watch-read.exp: New files.
Diffstat (limited to 'gdb/i386-nat.c')
| -rw-r--r-- | gdb/i386-nat.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gdb/i386-nat.c b/gdb/i386-nat.c index fa0cce6..82c51d7 100644 --- a/gdb/i386-nat.c +++ b/gdb/i386-nat.c @@ -268,7 +268,8 @@ i386_length_and_rw_bits (int len, enum target_hw_bp_type type) rw = DR_RW_WRITE; break; case hw_read: - /* The i386 doesn't support data-read watchpoints. */ + internal_error (__FILE__, __LINE__, + _("The i386 doesn't support data-read watchpoints.\n")); case hw_access: rw = DR_RW_READ; break; @@ -487,6 +488,9 @@ i386_insert_watchpoint (CORE_ADDR addr, int len, int type) { int retval; + if (type == hw_read) + return 1; /* unsupported */ + if (((len != 1 && len !=2 && len !=4) && !(TARGET_HAS_DR_LEN_8 && len == 8)) || addr % len != 0) retval = i386_handle_nonaligned_watchpoint (WP_INSERT, addr, len, type); |