diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2020-02-14 15:29:08 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2020-02-14 15:29:08 -0500 |
| commit | e8217e61f5952ccfdabb0c4ee0c237a363e9bd99 (patch) | |
| tree | 19aca9edacd70c4cfb8e8d6333ccaddb536b3584 /gdb/i386-linux-tdep.c | |
| parent | d8d83535e6d3dbb3fb8664f6a98a37470c091f01 (diff) | |
| download | gdb-e8217e61f5952ccfdabb0c4ee0c237a363e9bd99.zip gdb-e8217e61f5952ccfdabb0c4ee0c237a363e9bd99.tar.gz gdb-e8217e61f5952ccfdabb0c4ee0c237a363e9bd99.tar.bz2 | |
gdb: make gdbarch_displaced_step_copy_insn return an std::unique_ptr
This callback dynamically allocates a specialized displaced_step_closure, and
gives the ownership of the object to its caller. So I think it would make
sense for the callback to return an std::unique_ptr, this is what this patch
implements.
gdb/ChangeLog:
* gdbarch.sh (displaced_step_copy_insn): Change return type to an
std::unique_ptr.
* gdbarch.c: Re-generate.
* gdbarch.h: Re-generate.
* infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
change.
* aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
type to std::unique_ptr.
* aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
* amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
* amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
* arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
* i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
* i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
* i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
* rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
* s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
Diffstat (limited to 'gdb/i386-linux-tdep.c')
| -rw-r--r-- | gdb/i386-linux-tdep.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/i386-linux-tdep.c b/gdb/i386-linux-tdep.c index f4a5f0a..7170687 100644 --- a/gdb/i386-linux-tdep.c +++ b/gdb/i386-linux-tdep.c @@ -797,12 +797,12 @@ i386_linux_iterate_over_regset_sections (struct gdbarch *gdbarch, which does not seem worth it. The same effect is achieved by patching that 'nop' instruction there instead. */ -static struct displaced_step_closure * +static std::unique_ptr<displaced_step_closure> i386_linux_displaced_step_copy_insn (struct gdbarch *gdbarch, CORE_ADDR from, CORE_ADDR to, struct regcache *regs) { - displaced_step_closure *closure_ + std::unique_ptr<displaced_step_closure> closure_ = i386_displaced_step_copy_insn (gdbarch, from, to, regs); if (i386_linux_get_syscall_number_from_regcache (regs) != -1) @@ -810,7 +810,7 @@ i386_linux_displaced_step_copy_insn (struct gdbarch *gdbarch, /* The closure returned by i386_displaced_step_copy_insn is simply a buffer with a copy of the instruction. */ i386_displaced_step_closure *closure - = (i386_displaced_step_closure *) closure_; + = (i386_displaced_step_closure *) closure_.get (); /* Fake nop. */ closure->buf[0] = 0x90; |