diff options
| author | Simon Marchi <simon.marchi@polymtl.ca> | 2021-06-28 11:49:22 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-06-28 11:49:22 -0400 |
| commit | b447dd03c16d51c7b41c9af0756fc9db4ad95f0d (patch) | |
| tree | 4cff1537b99c800351a42d293650b7c51459e710 /gdb/i386-darwin-nat.c | |
| parent | c87c999c511f0484de53fa616b0bf6b00c753434 (diff) | |
| download | gdb-b447dd03c16d51c7b41c9af0756fc9db4ad95f0d.zip gdb-b447dd03c16d51c7b41c9af0756fc9db4ad95f0d.tar.gz gdb-b447dd03c16d51c7b41c9af0756fc9db4ad95f0d.tar.bz2 | |
gdb: remove gdbarch_info_init
While reviewing another patch, I realized that gdbarch_info_init could
easily be removed in favor of initializing gdbarch_info fields directly
in the struct declaration. The only odd part is the union. I don't
know if it's actually important for it to be zero-initialized, but I
presume it is. I added a constructor to gdbarch_info to take care of
that. A proper solution would be to use std::variant. Or, these could
also be separate fields, the little extra space required wouldn't
matter.
gdb/ChangeLog:
* gdbarch.sh (struct gdbarch_info): Initialize fields, add
constructor.
* gdbarch.h: Re-generate.
* arch-utils.h (gdbarch_info_init): Remove, delete all usages.
* arch-utils.c (gdbarch_info_init): Remove.
Change-Id: I7502e08fe0f278d84eef1667a072e8a97bda5ab5
Diffstat (limited to 'gdb/i386-darwin-nat.c')
| -rw-r--r-- | gdb/i386-darwin-nat.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/gdb/i386-darwin-nat.c b/gdb/i386-darwin-nat.c index 922d7a6..c1d6139 100644 --- a/gdb/i386-darwin-nat.c +++ b/gdb/i386-darwin-nat.c @@ -479,7 +479,6 @@ darwin_check_osabi (darwin_inferior *inf, thread_t thread) { /* Attaching to a process. Let's figure out what kind it is. */ x86_thread_state_t gp_regs; - struct gdbarch_info info; unsigned int gp_count = x86_THREAD_STATE_COUNT; kern_return_t ret; @@ -491,7 +490,7 @@ darwin_check_osabi (darwin_inferior *inf, thread_t thread) return; } - gdbarch_info_init (&info); + gdbarch_info info; gdbarch_info_fill (&info); info.byte_order = gdbarch_byte_order (target_gdbarch ()); info.osabi = GDB_OSABI_DARWIN; |