diff options
author | Pedro Alves <palves@redhat.com> | 2015-02-09 13:22:27 +0000 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2015-02-27 17:31:45 +0000 |
commit | 7cf99fb1c72769c17eed0a62951698bf56432108 (patch) | |
tree | d5a1add0bce7cbe9b49fe34a4f88a1ba17f2010b /gdb/guile | |
parent | 1424c16eab1a96de054991c346c2bbf3eac82dec (diff) | |
download | gdb-7cf99fb1c72769c17eed0a62951698bf56432108.zip gdb-7cf99fb1c72769c17eed0a62951698bf56432108.tar.gz gdb-7cf99fb1c72769c17eed0a62951698bf56432108.tar.bz2 |
Exported const objects
const works different in C vs C++. In C++, a global "const" variable
has internal linkage by default, resulting in link errors like:
...
extension.o: In function `get_ext_lang_defn(extension_language)':
gdb/extension.c:126: undefined reference to `extension_language_guile'
gdb/extension.c:124: undefined reference to `extension_language_guile'
...
The fix is to define exported const objects with "extern const". But
that in C would not be a definition. So we need to #ifdef C vs C++ in
this case.
EXPORTED_CONST comes from include/ansidecl.h, but in the
feature_to_c.sh case I think it's better to leave the script with no
dependencies.
gdb/ChangeLog:
2015-02-27 Pedro Alves <palves@redhat.com>
* cp-valprint.c (vtbl_ptr_name): Use EXPORTED_CONST.
* guile/guile.c (extension_language_guile): Use EXPORTED_CONST.
* features/feature_to_c.sh: Tag the generated xml_builtin array
with extern const in C++ mode.
Diffstat (limited to 'gdb/guile')
-rw-r--r-- | gdb/guile/guile.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/guile/guile.c b/gdb/guile/guile.c index 3e0d11a..1895118 100644 --- a/gdb/guile/guile.c +++ b/gdb/guile/guile.c @@ -77,7 +77,7 @@ extern const struct extension_language_ops guile_extension_ops; /* The main struct describing GDB's interface to the Guile extension language. */ -const struct extension_language_defn extension_language_guile = +EXPORTED_CONST struct extension_language_defn extension_language_guile = { EXT_LANG_GUILE, "guile", |