diff options
author | Simon Marchi <simon.marchi@ericsson.com> | 2017-12-05 16:05:34 -0500 |
---|---|---|
committer | Simon Marchi <simon.marchi@ericsson.com> | 2017-12-05 16:05:50 -0500 |
commit | 798a7429f980a00844c22dfdda9475c451c635d4 (patch) | |
tree | 8cf5089dcc794abeb52f70ec62204e11dc57f4e0 /gdb/guile | |
parent | da02107a39f3eff5e0b6d6321da4e88f9564350a (diff) | |
download | gdb-798a7429f980a00844c22dfdda9475c451c635d4.zip gdb-798a7429f980a00844c22dfdda9475c451c635d4.tar.gz gdb-798a7429f980a00844c22dfdda9475c451c635d4.tar.bz2 |
Remove some unused variables
This patch removes some unused variables, found with -Wunused. I have
not removed everything reported by -Wunused, because some expressions
such as
struct type *arg_type = check_typedef (value_type);
in bfin-tdep.c could have an unexpected but important side-effect. I
removed others that I considered more low-risk, such as:
struct gdbarch *gdbarch = get_objfile_arch (objfile);
I tested building with Python 2/Python 3/no Python, with/without expat,
with/without libipt and with/without babeltrace.
gdb/ChangeLog:
* ada-lang.c (ada_collect_symbol_completion_matches): Remove
unused variables.
(ada_is_redundant_range_encoding): Likewise.
* ada-varobj.c (ada_varobj_get_value_of_array_variable):
Likewise.
* alpha-tdep.c (alpha_software_single_step): Likewise.
* arm-tdep.c (_initialize_arm_tdep): Likewise.
* auto-load.c (info_auto_load_cmd): Likewise.
* break-catch-syscall.c (insert_catch_syscall): Likewise.
(remove_catch_syscall): Likewise.
* breakpoint.c (condition_completer): Likewise.
(clear_command): Likewise.
(update_breakpoint_locations): Likewise.
* btrace.c (btrace_disable): Likewise.
(btrace_teardown): Likewise.
(btrace_maint_update_pt_packets): Likewise.
(maint_btrace_clear_cmd): Likewise.
* cli/cli-decode.c (lookup_cmd_1): Likewise.
(lookup_cmd_composition): Likewise.
* cli/cli-dump.c (scan_filename): Likewise.
(restore_command): Likewise.
* compile/compile-loc2c.c (compute_stack_depth): Likewise.
* compile/compile-object-load.c (compile_object_load): Likewise.
* compile/compile-object-run.c (compile_object_run): Likewise.
* compile/compile.c (compile_to_object): Likewise.
* completer.c (filename_completer): Likewise.
(complete_files_symbols): Likewise.
(complete_expression): Likewise.
* corelow.c (core_open): Likewise.
* ctf.c (ctf_start): Likewise.
(ctf_write_status): Likewise.
(ctf_write_uploaded_tsv): Likewise.
(ctf_write_definition_end): Likewise.
(ctf_open_dir): Likewise.
(ctf_xfer_partial): Likewise.
(ctf_trace_find): Likewise.
* disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
Likewise.
* dwarf2loc.c (allocate_piece_closure): Likewise.
(indirect_pieced_value): Likewise.
(dwarf2_evaluate_loc_desc_full): Likewise.
* dwarf2read.c (dw2_expand_marked_cus): Likewise.
(dw2_expand_symtabs_matching): Likewise.
(dw2_map_symbol_filenames): Likewise.
(read_and_check_comp_unit_head): Likewise.
(read_cutu_die_from_dwo): Likewise.
(lookup_dwo_unit): Likewise.
(read_comp_units_from_section): Likewise.
(dwarf2_compute_name): Likewise.
(handle_DW_AT_stmt_list): Likewise.
(create_cus_hash_table): Likewise.
(create_dwp_v2_section): Likewise.
(dwarf2_rnglists_process): Likewise.
(dwarf2_ranges_process): Likewise.
(dwarf2_record_block_ranges): Likewise.
(is_vtable_name): Likewise.
(read_formatted_entries): Likewise.
(skip_form_bytes): Likewise.
* elfread.c (elf_symtab_read): Likewise.
* exec.c (exec_file_command): Likewise.
* f-valprint.c (f_val_print): Likewise.
(info_common_command_for_block): Likewise.
* guile/guile.c (initialize_scheme_side): Likewise.
* guile/scm-breakpoint.c (gdbscm_breakpoint_commands): Likewise.
* guile/scm-cmd.c (cmdscm_completer): Likewise.
(gdbscm_register_command_x): Likewise.
* guile/scm-frame.c (gdbscm_frame_read_var): Likewise.
* guile/scm-param.c (gdbscm_parameter_value): Likewise.
* guile/scm-ports.c (file_port_magic): Likewise.
* guile/scm-pretty-print.c (ppscm_search_pp_list): Likewise.
(ppscm_pretty_print_one_value): Likewise.
(ppscm_print_children): Likewise.
* guile/scm-string.c (gdbscm_string_to_argv): Likewise.
* guile/scm-symtab.c (gdbscm_sal_symtab): Likewise.
* guile/scm-type.c (gdbscm_type_next_field_x): Likewise.
* guile/scm-utils.c (gdbscm_parse_function_args): Likewise.
* i386-tdep.c (i386_register_reggroup_p): Likewise.
* infcmd.c (run_command_1): Likewise.
(until_next_fsm_clean_up): Likewise.
* linespec.c (linespec_complete): Likewise.
(find_label_symbols): Likewise.
* m2-valprint.c (m2_val_print): Likewise.
* memattr.c (require_user_regions): Likewise.
(lookup_mem_region): Likewise.
(disable_mem_command): Likewise.
(mem_delete): Likewise.
* mep-tdep.c (mep_register_name): Likewise.
(mep_analyze_prologue): Likewise.
* mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Likewise.
* mi/mi-interp.c (mi_on_sync_execution_done): Likewise.
* mi/mi-main.c (mi_cmd_trace_frame_collected): Likewise.
* microblaze-linux-tdep.c (microblaze_linux_init_abi): Likewise.
* minidebug.c (lzma_open): Likewise.
* minsyms.c (lookup_minimal_symbol): Likewise.
* mips-linux-tdep.c (mips64_fill_fpregset): Likewise.
* mips-tdep.c (mips_stub_frame_sniffer): Likewise.
(mips_o64_return_value): Likewise.
(mips_single_step_through_delay): Likewise.
(_initialize_mips_tdep): Likewise.
* nios2-tdep.c (nios2_push_dummy_call): Likewise.
(nios2_software_single_step): Likewise.
* parse.c (find_minsym_type_and_address): Likewise.
* psymtab.c (psym_relocate): Likewise.
* python/py-breakpoint.c (bppy_get_commands): Likewise.
(gdbpy_breakpoint_modified): Likewise.
* python/py-infevents.c (create_inferior_call_event_object):
Likewise.
* python/py-record-btrace.c (btpy_list_item): Likewise.
* python/py-type.c (typy_str): Likewise.
* python/py-value.c (valpy_call): Likewise.
* python/python.c (do_start_initialization): Likewise.
* record-btrace.c (record_btrace_insn_history_range): Likewise.
(record_btrace_call_history_range): Likewise.
(record_btrace_record_method): Likewise.
(record_btrace_xfer_partial): Likewise.
(btrace_get_frame_function): Likewise.
* record-full.c (record_full_open): Likewise.
* record.c (get_context_size): Likewise.
* registry.h (DEFINE_REGISTRY): Likewise.
* remote-fileio.c (remote_fileio_request): Likewise.
* remote.c (remote_update_thread_list): Likewise.
(remote_check_symbols): Likewise.
(remote_commit_resume): Likewise.
(remote_interrupt): Likewise.
(remote_insert_breakpoint): Likewise.
(compare_sections_command): Likewise.
* rust-exp.y (super_name): Likewise.
(lex_string): Likewise.
(convert_ast_to_type): Likewise.
(convert_ast_to_expression): Likewise.
* rust-lang.c (rust_print_struct_def): Likewise.
(rust_print_type): Likewise.
(rust_evaluate_subexp): Likewise.
* rx-tdep.c (rx_register_type): Likewise.
* ser-event.c (serial_event_clear): Likewise.
* serial.c (serial_open): Likewise.
* spu-tdep.c (spu_overlay_new_objfile): Likewise.
* symfile.c (section_is_overlay): Likewise.
(overlay_unmapped_address): Likewise.
(overlay_mapped_address): Likewise.
(simple_overlay_update_1): Likewise.
(simple_overlay_update): Likewise.
* symtab.c (symbol_find_demangled_name): Likewise.
(search_symbols): Likewise.
* target-descriptions.c (tdesc_predefined_type): Likewise.
* target.c (target_commit_resume): Likewise.
* thread.c (print_selected_thread_frame): Likewise.
* top.c (new_ui_command): Likewise.
(gdb_readline_no_editing): Likewise.
* tracefile-tfile.c (tfile_open): Likewise.
* tracepoint.c (create_tsv_from_upload): Likewise.
* utils.c (quit): Likewise.
(defaulted_query): Likewise.
* valarith.c (value_concat): Likewise.
* xml-syscall.c (xml_list_syscalls_by_group): Likewise.
* xml-tdesc.c (target_fetch_description_xml): Likewise.
* xtensa-tdep.c (xtensa_pseudo_register_read): Likewise.
(xtensa_pseudo_register_write): Likewise.
gdb/gdbserver/ChangeLog:
* regcache.c (registers_to_string): Remove unused variable.
Diffstat (limited to 'gdb/guile')
-rw-r--r-- | gdb/guile/guile.c | 1 | ||||
-rw-r--r-- | gdb/guile/scm-breakpoint.c | 1 | ||||
-rw-r--r-- | gdb/guile/scm-cmd.c | 4 | ||||
-rw-r--r-- | gdb/guile/scm-frame.c | 1 | ||||
-rw-r--r-- | gdb/guile/scm-param.c | 1 | ||||
-rw-r--r-- | gdb/guile/scm-ports.c | 4 | ||||
-rw-r--r-- | gdb/guile/scm-pretty-print.c | 5 | ||||
-rw-r--r-- | gdb/guile/scm-string.c | 1 | ||||
-rw-r--r-- | gdb/guile/scm-symtab.c | 1 | ||||
-rw-r--r-- | gdb/guile/scm-type.c | 2 | ||||
-rw-r--r-- | gdb/guile/scm-utils.c | 2 |
11 files changed, 5 insertions, 18 deletions
diff --git a/gdb/guile/guile.c b/gdb/guile/guile.c index bc3c45f..af1f9ae 100644 --- a/gdb/guile/guile.c +++ b/gdb/guile/guile.c @@ -605,7 +605,6 @@ static void initialize_scheme_side (void) { char *boot_scm_path; - char *msg; guile_datadir = concat (gdb_datadir, SLASH_STRING, "guile", (char *) NULL); boot_scm_path = concat (guile_datadir, SLASH_STRING, "gdb", diff --git a/gdb/guile/scm-breakpoint.c b/gdb/guile/scm-breakpoint.c index f84815e..c2d5c77 100644 --- a/gdb/guile/scm-breakpoint.c +++ b/gdb/guile/scm-breakpoint.c @@ -975,7 +975,6 @@ gdbscm_breakpoint_commands (SCM self) breakpoint_smob *bp_smob = bpscm_get_valid_breakpoint_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME); struct breakpoint *bp; - long length; SCM result; bp = bp_smob->bp; diff --git a/gdb/guile/scm-cmd.c b/gdb/guile/scm-cmd.c index 4745def..bcc7462 100644 --- a/gdb/guile/scm-cmd.c +++ b/gdb/guile/scm-cmd.c @@ -385,7 +385,7 @@ cmdscm_completer (struct cmd_list_element *command, { command_smob *c_smob/*obj*/ = (command_smob *) get_cmd_context (command); SCM completer_result_scm; - SCM text_scm, word_scm, result_scm; + SCM text_scm, word_scm; gdb_assert (c_smob != NULL); gdb_assert (gdbscm_is_procedure (c_smob->complete)); @@ -746,7 +746,7 @@ gdbscm_register_command_x (SCM self) { command_smob *c_smob = cmdscm_get_command_smob_arg_unsafe (self, SCM_ARG1, FUNC_NAME); - char *cmd_name, *pfx_name; + char *cmd_name; struct cmd_list_element **cmd_list; struct cmd_list_element *cmd = NULL; diff --git a/gdb/guile/scm-frame.c b/gdb/guile/scm-frame.c index 594d16e..fd5a60e 100644 --- a/gdb/guile/scm-frame.c +++ b/gdb/guile/scm-frame.c @@ -840,7 +840,6 @@ static SCM gdbscm_frame_read_var (SCM self, SCM symbol_scm, SCM rest) { SCM keywords[] = { block_keyword, SCM_BOOL_F }; - int rc; frame_smob *f_smob; int block_arg_pos = -1; SCM block_scm = SCM_UNDEFINED; diff --git a/gdb/guile/scm-param.c b/gdb/guile/scm-param.c index 9478778..79b5bb4 100644 --- a/gdb/guile/scm-param.c +++ b/gdb/guile/scm-param.c @@ -1062,7 +1062,6 @@ gdbscm_parameter_value (SCM self) char *name; SCM except_scm; struct cmd_list_element *alias, *prefix, *cmd; - const char *arg; char *newarg; int found = -1; struct gdb_exception except = exception_none; diff --git a/gdb/guile/scm-ports.c b/gdb/guile/scm-ports.c index a7c0bd4..340f505 100644 --- a/gdb/guile/scm-ports.c +++ b/gdb/guile/scm-ports.c @@ -98,10 +98,6 @@ static SCM input_port_scm; static SCM output_port_scm; static SCM error_port_scm; -/* Magic number to identify port ui-files. - Actually, the address of this variable is the magic number. */ -static int file_port_magic; - /* Internal enum for specifying output port. */ enum oport { GDB_STDOUT, GDB_STDERR }; diff --git a/gdb/guile/scm-pretty-print.c b/gdb/guile/scm-pretty-print.c index a28e4e6..45edcf1 100644 --- a/gdb/guile/scm-pretty-print.c +++ b/gdb/guile/scm-pretty-print.c @@ -381,7 +381,6 @@ ppscm_search_pp_list (SCM list, SCM value) SCM matcher = scm_car (list); SCM worker; pretty_printer_smob *pp_smob; - int rc; if (!ppscm_is_pretty_printer (matcher)) { @@ -534,7 +533,6 @@ ppscm_pretty_print_one_value (SCM printer, struct value **out_value, *out_value = NULL; TRY { - int rc; pretty_printer_worker_smob *w_smob = (pretty_printer_worker_smob *) SCM_SMOB_DATA (printer); @@ -744,7 +742,7 @@ ppscm_print_children (SCM printer, enum display_hint hint, = (pretty_printer_worker_smob *) SCM_SMOB_DATA (printer); int is_map, is_array, done_flag, pretty; unsigned int i; - SCM children, status; + SCM children; SCM iter = SCM_BOOL_F; /* -Wall */ struct cleanup *cleanups; @@ -799,7 +797,6 @@ ppscm_print_children (SCM printer, enum display_hint hint, done_flag = 0; for (i = 0; i < options->print_max; ++i) { - int rc; SCM scm_name, v_scm; char *name; SCM item = itscm_safe_call_next_x (iter, gdbscm_memory_error_p); diff --git a/gdb/guile/scm-string.c b/gdb/guile/scm-string.c index 4e495eb..5adac4e 100644 --- a/gdb/guile/scm-string.c +++ b/gdb/guile/scm-string.c @@ -241,7 +241,6 @@ static SCM gdbscm_string_to_argv (SCM string_scm) { char *string; - int i; SCM result = SCM_EOL; gdbscm_parse_function_args (FUNC_NAME, SCM_ARG1, NULL, "s", diff --git a/gdb/guile/scm-symtab.c b/gdb/guile/scm-symtab.c index 755ea67..e5278a7 100644 --- a/gdb/guile/scm-symtab.c +++ b/gdb/guile/scm-symtab.c @@ -578,7 +578,6 @@ static SCM gdbscm_sal_symtab (SCM self) { sal_smob *s_smob = stscm_get_valid_sal_smob_arg (self, SCM_ARG1, FUNC_NAME); - const struct symtab_and_line *sal = &s_smob->sal; return s_smob->symtab_scm; } diff --git a/gdb/guile/scm-type.c b/gdb/guile/scm-type.c index 704be88..922351d 100644 --- a/gdb/guile/scm-type.c +++ b/gdb/guile/scm-type.c @@ -1090,7 +1090,7 @@ gdbscm_type_next_field_x (SCM self) type_smob *t_smob; struct type *type; SCM it_scm, result, progress, object; - int field, rc; + int field; it_scm = itscm_get_iterator_arg_unsafe (self, SCM_ARG1, FUNC_NAME); i_smob = (iterator_smob *) SCM_SMOB_DATA (it_scm); diff --git a/gdb/guile/scm-utils.c b/gdb/guile/scm-utils.c index b7c955d..c0557dd 100644 --- a/gdb/guile/scm-utils.c +++ b/gdb/guile/scm-utils.c @@ -381,7 +381,7 @@ gdbscm_parse_function_args (const char *func_name, { va_list args; const char *p; - int i, have_rest, num_keywords, length, position; + int i, have_rest, num_keywords, position; int have_optional = 0; SCM status; SCM rest = SCM_EOL; |