diff options
| author | Marco Barisione <mbarisione@undo.io> | 2021-05-12 11:19:22 +0100 |
|---|---|---|
| committer | Marco Barisione <mbarisione@undo.io> | 2021-05-12 11:19:22 +0100 |
| commit | 2f822da535ba9b159174d02d7114b4fc4f7c8818 (patch) | |
| tree | 7014b48d9f7893385ed27091caa75c28964c3514 /gdb/go32-nat.c | |
| parent | f0bbe8bab84e9b9dc5367a5fe1d0b8d233bf213c (diff) | |
| download | gdb-2f822da535ba9b159174d02d7114b4fc4f7c8818.zip gdb-2f822da535ba9b159174d02d7114b4fc4f7c8818.tar.gz gdb-2f822da535ba9b159174d02d7114b4fc4f7c8818.tar.bz2 | |
gdb: generate the prefix name for prefix commands on demand
Previously, the prefixname field of struct cmd_list_element was manually
set for prefix commands. This seems verbose and error prone as it
required every single call to functions adding prefix commands to
specify the prefix name while the same information can be easily
generated.
Historically, this was not possible as the prefix field was null for
many commands, but this was fixed in commit
3f4d92ebdf7f848b5ccc9e8d8e8514c64fde1183 by Philippe Waroquiers, so
we can rely on the prefix field being set when generating the prefix
name.
This commit also fixes a use after free in this scenario:
* A command gets created via Python (using the gdb.Command class).
The prefix name member is dynamically allocated.
* An alias to the new command is created. The alias's prefixname is set
to point to the prefixname for the original command with a direct
assignment.
* A new command with the same name as the Python command is created.
* The object for the original Python command gets freed and its
prefixname gets freed as well.
* The alias is updated to point to the new command, but its prefixname
is not updated so it keeps pointing to the freed one.
gdb/ChangeLog:
* command.h (add_prefix_cmd): Remove the prefixname argument as
it can now be generated automatically. Update all callers.
(add_basic_prefix_cmd): Ditto.
(add_show_prefix_cmd): Ditto.
(add_prefix_cmd_suppress_notification): Ditto.
(add_abbrev_prefix_cmd): Ditto.
* cli/cli-decode.c (add_prefix_cmd): Ditto.
(add_basic_prefix_cmd): Ditto.
(add_show_prefix_cmd): Ditto.
(add_prefix_cmd_suppress_notification): Ditto.
(add_prefix_cmd_suppress_notification): Ditto.
(add_abbrev_prefix_cmd): Ditto.
* cli/cli-decode.h (struct cmd_list_element): Replace the
prefixname member variable with a method which generates the
prefix name at runtime. Update all code reading the prefix
name to use the method, and remove all code setting it.
* python/py-cmd.c (cmdpy_destroyer): Remove code to free the
prefixname member as it's now a method.
(cmdpy_function): Determine if the command is a prefix by
looking at prefixlist, not prefixname.
Diffstat (limited to 'gdb/go32-nat.c')
| -rw-r--r-- | gdb/go32-nat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c index 9899545..5aae340 100644 --- a/gdb/go32-nat.c +++ b/gdb/go32-nat.c @@ -2099,7 +2099,7 @@ _initialize_go32_nat () add_basic_prefix_cmd ("dos", class_info, _("\ Print information specific to DJGPP (aka MS-DOS) debugging."), - &info_dos_cmdlist, "info dos ", 0, &infolist); + &info_dos_cmdlist, 0, &infolist); add_cmd ("sysinfo", class_info, go32_sysinfo, _("\ Display information about the target system, including CPU, OS, DPMI, etc."), |