diff options
| author | Yao Qi <yao.qi@linaro.org> | 2016-03-03 09:28:19 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2016-03-03 09:28:19 +0000 |
| commit | c40c8d4b6793b71eed7cf9fa7467edda2271dc86 (patch) | |
| tree | bde70f72f27129104544a85dea84cbfae36d6654 /gdb/gdbserver | |
| parent | 4719d415b9908d3c7981163b47be5096d03656f9 (diff) | |
| download | gdb-c40c8d4b6793b71eed7cf9fa7467edda2271dc86.zip gdb-c40c8d4b6793b71eed7cf9fa7467edda2271dc86.tar.gz gdb-c40c8d4b6793b71eed7cf9fa7467edda2271dc86.tar.bz2 | |
Update comments to start_step_over
I happen to see that comments to start_step_over isn't in sync with
code, so this patch is to update the comments.
gdb/gdbserver:
2016-03-03 Yao Qi <yao.qi@linaro.org>
* linux-low.c: Update comments to start_step_over.
Diffstat (limited to 'gdb/gdbserver')
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-low.c | 16 |
2 files changed, 8 insertions, 12 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 6c23574..11e1c4f 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,9 @@ 2016-03-03 Yao Qi <yao.qi@linaro.org> + * linux-low.c: Update comments to start_step_over. + +2016-03-03 Yao Qi <yao.qi@linaro.org> + PR server/19736 * linux-low.c (handle_extended_wait): Set child suspended if event_lwp->bp_reinsert isn't zero. diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 6b07c90..c008847 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -4625,18 +4625,10 @@ need_step_over_p (struct inferior_list_entry *entry, void *dummy) of the way. If we let other threads run while we do that, they may pass by the breakpoint location and miss hitting it. To avoid that, a step-over momentarily stops all threads while LWP is - single-stepped while the breakpoint is temporarily uninserted from - the inferior. When the single-step finishes, we reinsert the - breakpoint, and let all threads that are supposed to be running, - run again. - - On targets that don't support hardware single-step, we don't - currently support full software single-stepping. Instead, we only - support stepping over the thread event breakpoint, by asking the - low target where to place a reinsert breakpoint. Since this - routine assumes the breakpoint being stepped over is a thread event - breakpoint, it usually assumes the return address of the current - function is a good enough place to set the reinsert breakpoint. */ + single-stepped by either hardware or software while the breakpoint + is temporarily uninserted from the inferior. When the single-step + finishes, we reinsert the breakpoint, and let all threads that are + supposed to be running, run again. */ static int start_step_over (struct lwp_info *lwp) |