diff options
| author | Yao Qi <yao.qi@linaro.org> | 2016-01-26 14:08:26 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2016-01-26 14:08:26 +0000 |
| commit | 4d18591be953e2faeaaa280484d375fe05857770 (patch) | |
| tree | 4c5bbcc7514ab016e52fb52f655f940d05fb2b08 /gdb/gdbserver | |
| parent | d80209703ec2fc85e0a4b3d4d23e7ed448987aca (diff) | |
| download | gdb-4d18591be953e2faeaaa280484d375fe05857770.zip gdb-4d18591be953e2faeaaa280484d375fe05857770.tar.gz gdb-4d18591be953e2faeaaa280484d375fe05857770.tar.bz2 | |
Remove argument pc in get_next_pcs
Nowadays, get_next_pcs in linux_target_ops has two parameters PC
and REGCACHE. Parameter PC looks redundant because it can be go
from REGCACHE. The patch is to remove PC from the arguments for
various functions.
gdb:
2016-01-26 Yao Qi <yao.qi@linaro.org>
* arch/arm-get-next-pcs.c (thumb_deal_with_atomic_sequence_raw):
Remove argument pc. Get pc by regcache_read_pc. Callers updated.
(arm_deal_with_atomic_sequence_raw): Likewise.
(thumb_get_next_pcs_raw): Likewise.
(arm_get_next_pcs_raw): Likewise.
(arm_get_next_pcs): Remove argument pc. Callers updated.
* arch/arm-get-next-pcs.h (arm_get_next_pcs): Update declaration.
gdb/gdbserver:
2016-01-26 Yao Qi <yao.qi@linaro.org>
* linux-arm-low.c (arm_gdbserver_get_next_pcs): Remove argument pc.
* linux-low.c (install_software_single_step_breakpoints): Don't
call regcache_read_pc.
* linux-low.h (struct linux_target_ops) <get_next_pcs>: Remove
argument pc.
Diffstat (limited to 'gdb/gdbserver')
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 8 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-arm-low.c | 4 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-low.c | 4 | ||||
| -rw-r--r-- | gdb/gdbserver/linux-low.h | 2 |
4 files changed, 12 insertions, 6 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 8c1677d..e511de9 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,5 +1,13 @@ 2016-01-26 Yao Qi <yao.qi@linaro.org> + * linux-arm-low.c (arm_gdbserver_get_next_pcs): Remove argument pc. + * linux-low.c (install_software_single_step_breakpoints): Don't + call regcache_read_pc. + * linux-low.h (struct linux_target_ops) <get_next_pcs>: Remove + argument pc. + +2016-01-26 Yao Qi <yao.qi@linaro.org> + * linux-low.c (install_software_single_step_breakpoints): Call regcache_read_pc instead of get_pc. diff --git a/gdb/gdbserver/linux-arm-low.c b/gdb/gdbserver/linux-arm-low.c index c4f43bb..0f62706 100644 --- a/gdb/gdbserver/linux-arm-low.c +++ b/gdb/gdbserver/linux-arm-low.c @@ -923,7 +923,7 @@ arm_arch_setup (void) /* Fetch the next possible PCs after the current instruction executes. */ static VEC (CORE_ADDR) * -arm_gdbserver_get_next_pcs (CORE_ADDR pc, struct regcache *regcache) +arm_gdbserver_get_next_pcs (struct regcache *regcache) { struct arm_get_next_pcs next_pcs_ctx; VEC (CORE_ADDR) *next_pcs = NULL; @@ -936,7 +936,7 @@ arm_gdbserver_get_next_pcs (CORE_ADDR pc, struct regcache *regcache) 1, regcache); - next_pcs = arm_get_next_pcs (&next_pcs_ctx, pc); + next_pcs = arm_get_next_pcs (&next_pcs_ctx); return next_pcs; } diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index b35b569..bce7580 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -4103,9 +4103,7 @@ install_software_single_step_breakpoints (struct lwp_info *lwp) VEC (CORE_ADDR) *next_pcs = NULL; struct cleanup *old_chain = make_cleanup (VEC_cleanup (CORE_ADDR), &next_pcs); - pc = regcache_read_pc (regcache); - - next_pcs = (*the_low_target.get_next_pcs) (pc, regcache); + next_pcs = (*the_low_target.get_next_pcs) (regcache); for (i = 0; VEC_iterate (CORE_ADDR, next_pcs, i, pc); ++i) set_reinsert_breakpoint (pc); diff --git a/gdb/gdbserver/linux-low.h b/gdb/gdbserver/linux-low.h index 4845862..0d9eb40 100644 --- a/gdb/gdbserver/linux-low.h +++ b/gdb/gdbserver/linux-low.h @@ -154,7 +154,7 @@ struct linux_target_ops const gdb_byte *(*sw_breakpoint_from_kind) (int kind, int *size); /* Find the next possible PCs after the current instruction executes. */ - VEC (CORE_ADDR) *(*get_next_pcs) (CORE_ADDR pc, struct regcache *regcache); + VEC (CORE_ADDR) *(*get_next_pcs) (struct regcache *regcache); int decr_pc_after_break; int (*breakpoint_at) (CORE_ADDR pc); |