diff options
| author | Christian Biesinger <cbiesinger@google.com> | 2019-12-18 15:03:07 -0600 |
|---|---|---|
| committer | Christian Biesinger <cbiesinger@google.com> | 2019-12-19 13:30:50 -0600 |
| commit | 0ad6b8ee70dd18ab1f956800ea3494ea790c8a55 (patch) | |
| tree | f43745b1301338285b8cabc0e6c0ecc9462bb093 /gdb/gdbserver | |
| parent | 1ee7b812e778e4fddcfaa5f0be023dfdfb5a4d6e (diff) | |
| download | gdb-0ad6b8ee70dd18ab1f956800ea3494ea790c8a55.zip gdb-0ad6b8ee70dd18ab1f956800ea3494ea790c8a55.tar.gz gdb-0ad6b8ee70dd18ab1f956800ea3494ea790c8a55.tar.bz2 | |
Consistently quote variables used with "test"
This ensures that empty variables and variables with spaces are handled
correctly.
Code was inconsistent on whether the constant string (e.g. yes/no)
should also be quoted; I tried to be consistent with surrounding code.
This fixes the error Eli reported during configure with mingw (though that
was not fatal).
gdb/ChangeLog:
2019-12-19 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Quote variable arguments of test.
* gdbsupport/common.m4: Likewise.
gdb/gdbserver/ChangeLog:
2019-12-19 Christian Biesinger <cbiesinger@google.com>
* configure: Regenerate.
* configure.ac: Quote variable arguments of test.
Change-Id: I220e78b52c7db88b9dd058eda604635b03464fac
Diffstat (limited to 'gdb/gdbserver')
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 5 | ||||
| -rwxr-xr-x | gdb/gdbserver/configure | 8 | ||||
| -rw-r--r-- | gdb/gdbserver/configure.ac | 4 |
3 files changed, 11 insertions, 6 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 8ab1f07..028d1e9 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2019-12-19 Christian Biesinger <cbiesinger@google.com> + + * configure: Regenerate. + * configure.ac: Quote variable arguments of test. + 2019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de> * Makefile.in: Fix build with GNU Make 3.81 diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure index ccffde8..4de751b 100755 --- a/gdb/gdbserver/configure +++ b/gdb/gdbserver/configure @@ -7731,7 +7731,7 @@ done LIBS="$save_LIBS" CXXFLAGS="$save_CXXFLAGS" fi - if test $gdb_cv_cxx_std_thread = yes; then + if test "$gdb_cv_cxx_std_thread" = "yes"; then $as_echo "#define CXX_STD_THREAD 1" >>confdefs.h @@ -7770,7 +7770,7 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext fi { $as_echo "$as_me:${as_lineno-$LINENO}: result: $gdb_cv_func_sigsetjmp" >&5 $as_echo "$gdb_cv_func_sigsetjmp" >&6; } -if test $gdb_cv_func_sigsetjmp = yes; then +if test "$gdb_cv_func_sigsetjmp" = "yes"; then $as_echo "#define HAVE_SIGSETJMP 1" >>confdefs.h @@ -9198,7 +9198,7 @@ rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext fi { $as_echo "$as_me:${as_lineno-$LINENO}: result: $gdbsrv_cv_have_td_version" >&5 $as_echo "$gdbsrv_cv_have_td_version" >&6; } - if test $gdbsrv_cv_have_td_version = yes; then + if test "$gdbsrv_cv_have_td_version" = yes; then $as_echo "#define HAVE_TD_VERSION 1" >>confdefs.h @@ -9263,7 +9263,7 @@ rm -f core conftest.err conftest.$ac_objext \ fi { $as_echo "$as_me:${as_lineno-$LINENO}: result: $gdbsrv_cv_have_sync_builtins" >&5 $as_echo "$gdbsrv_cv_have_sync_builtins" >&6; } -if test $gdbsrv_cv_have_sync_builtins = yes; then +if test "$gdbsrv_cv_have_sync_builtins" = yes; then $as_echo "#define HAVE_SYNC_BUILTINS 1" >>confdefs.h diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac index 4a6d88e..c24ce82 100644 --- a/gdb/gdbserver/configure.ac +++ b/gdb/gdbserver/configure.ac @@ -363,7 +363,7 @@ if test "$srv_linux_thread_db" = "yes"; then [AC_TRY_COMPILE([#include <thread_db.h>], [TD_VERSION;], [gdbsrv_cv_have_td_version=yes], [gdbsrv_cv_have_td_version=no])]) - if test $gdbsrv_cv_have_td_version = yes; then + if test "$gdbsrv_cv_have_td_version" = yes; then AC_DEFINE(HAVE_TD_VERSION, 1, [Define if TD_VERSION is available.]) fi fi @@ -398,7 +398,7 @@ AC_CACHE_CHECK([whether the target supports __sync_*_compare_and_swap], AC_TRY_LINK([], [int foo, bar; bar = __sync_val_compare_and_swap(&foo, 0, 1);], gdbsrv_cv_have_sync_builtins=yes, gdbsrv_cv_have_sync_builtins=no)]) -if test $gdbsrv_cv_have_sync_builtins = yes; then +if test "$gdbsrv_cv_have_sync_builtins" = yes; then AC_DEFINE(HAVE_SYNC_BUILTINS, 1, [Define to 1 if the target supports __sync_*_compare_and_swap]) fi |