diff options
author | Patrick Palka <patrick@parcs.ath.cx> | 2015-05-13 16:26:48 -0400 |
---|---|---|
committer | Patrick Palka <patrick@parcs.ath.cx> | 2015-05-14 08:18:06 -0400 |
commit | e3555239e04fa6dba2a165b3b52598a880474a22 (patch) | |
tree | 157984015f197084d85dd271980d254c1278a3c6 /gdb/gdbserver | |
parent | fdc3b1b1ef461fb81a53c9ce95117e5f134fc828 (diff) | |
download | gdb-e3555239e04fa6dba2a165b3b52598a880474a22.zip gdb-e3555239e04fa6dba2a165b3b52598a880474a22.tar.gz gdb-e3555239e04fa6dba2a165b3b52598a880474a22.tar.bz2 |
Remove buggy xterm workaround in tui_dispatch_ctrl_char()
The function tui_dispatch_ctrl_char() has an old workaround (from 1999)
for buggy terminals and/or ncurses library that don't return page
up/down keys as single characters. Because the workaround is so old, I
think the bug it is targetting is no longer relevant anymore.
But more importantly, the workaround is itself buggy: it 1) performs a
blocking call to wgetch() and 2) if the key returned by wgetch() does
not make up a relevant key sequence it throws away the input instead of
pushing it back via ungetch(). And indeed the workaround breaks Alt-key
sequences under TERM=xterm because of bug #2.
So this patch removes the buggy workaround and tidies up the function
accordingly.
I personally tested this change on a recent xterm (with TERM=xterm) in
Fedora 20 and had no problems with having ncurses properly interpret
page up/down keys. And Alt-key sequences now work when TERM=xterm too.
gdb/ChangeLog:
* tui/tui-command.c: Remove include of <ctype.h>.
(tui_dispatch_ctrl_char): Remove workaround for xterm terminals.
Diffstat (limited to 'gdb/gdbserver')
0 files changed, 0 insertions, 0 deletions