diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2015-06-18 13:12:39 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2015-06-18 13:12:39 -0400 |
| commit | 124e13d9e753ef307d6fe478e2cd6dd738de1a0f (patch) | |
| tree | 1e3ded1039355e3d4e2e5c3d7df1a591d4b73b6f /gdb/gdbserver | |
| parent | 74bd41ce65c6c2c30ff67519bfc1d00b61826d96 (diff) | |
| download | gdb-124e13d9e753ef307d6fe478e2cd6dd738de1a0f.zip gdb-124e13d9e753ef307d6fe478e2cd6dd738de1a0f.tar.gz gdb-124e13d9e753ef307d6fe478e2cd6dd738de1a0f.tar.bz2 | |
remote: consider addressable unit size when reading/writing memory
Adapt code in remote.c to take into account addressable unit size when
reading/writing memory.
A few variables are renamed and suffixed with _bytes or _units. This
way, it's more obvious if there is any place where we add or compare
values of different kinds (which would be a mistake).
gdb/ChangeLog:
* common/rsp-low.c (needs_escaping): New.
(remote_escape_output): Add unit_size parameter. Refactor to
support multi-byte addressable units. Rename parameters.
* common/rsp-low.h (remote_escape_output): Add unit_size
parameter and rename others. Update doc.
* remote.c (align_for_efficient_write): New.
(remote_write_bytes_aux): Add unit_size parameter and use it.
Rename some variables. Update doc.
(remote_xfer_partial): Get unit size and use it.
(remote_read_bytes_1): Add unit_size parameter and use it.
Rename some variables. Update doc.
(remote_write_bytes): Same.
(remote_xfer_live_readonly_partial): Same.
(remote_read_bytes): Same.
(remote_flash_write): Update call to remote_write_bytes_aux.
(remote_write_qxfer): Update call to remote_escape_output.
(remote_search_memory): Same.
(remote_hostio_pwrite): Same.
gdb/gdbserver/ChangeLog:
* server.c (write_qxfer_response): Update call to
remote_escape_output.
Diffstat (limited to 'gdb/gdbserver')
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/gdbserver/server.c | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index c1d589a..7c380c1 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2015-06-18 Simon Marchi <simon.marchi@ericsson.com> + + * server.c (write_qxfer_response): Update call to + remote_escape_output. + 2015-06-15 Aleksandar Ristovski <aristovski@qnx.com Jan Kratochvil <jan.kratochvil@redhat.com> diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c index 01b9c96..c9effc2 100644 --- a/gdb/gdbserver/server.c +++ b/gdb/gdbserver/server.c @@ -387,8 +387,8 @@ write_qxfer_response (char *buf, const void *data, int len, int is_more) else buf[0] = 'l'; - return remote_escape_output (data, len, (unsigned char *) buf + 1, &out_len, - PBUFSIZ - 2) + 1; + return remote_escape_output (data, len, 1, (unsigned char *) buf + 1, + &out_len, PBUFSIZ - 2) + 1; } /* Handle btrace enabling in BTS format. */ |