diff options
| author | Pedro Alves <palves@redhat.com> | 2015-10-29 12:55:02 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2015-10-29 12:55:02 +0000 |
| commit | add67df84c59a6c28111d65e8d0a7e6b4994cdb1 (patch) | |
| tree | e82b78a8fef40902bc40de79b88def588371a9d9 /gdb/gdbserver/target.h | |
| parent | 50bc912a2074c974c9c5074e674e9149a33b64c2 (diff) | |
| download | gdb-add67df84c59a6c28111d65e8d0a7e6b4994cdb1.zip gdb-add67df84c59a6c28111d65e8d0a7e6b4994cdb1.tar.gz gdb-add67df84c59a6c28111d65e8d0a7e6b4994cdb1.tar.bz2 | |
gdbserver: btrace enums
Fixes:
../../../src/gdb/gdbserver/linux-low.c: In function ‘int linux_low_read_btrace(btrace_target_info*, buffer*, int)’:
../../../src/gdb/gdbserver/linux-low.c:6827:48: error: invalid conversion from ‘int’ to ‘btrace_read_type’ [-fpermissive]
err = linux_read_btrace (&btrace, tinfo, type);
^
In file included from ../../../src/gdb/gdbserver/linux-low.c:98:0:
../../../src/gdb/gdbserver/../nat/linux-btrace.h:116:26: error: initializing argument 3 of ‘btrace_error linux_read_btrace(btrace_data*, btrace_target_info*, btrace_read_type)’ [-fpermissive]
extern enum btrace_error linux_read_btrace (struct btrace_data *btrace,
^
The cyclic dependency the comment talks about is no longer relevant:
https://sourceware.org/ml/gdb-patches/2015-10/msg00643.html
gdb/gdbserver/ChangeLog:
2015-10-29 Pedro Alves <palves@redhat.com>
* linux-low.c (linux_low_read_btrace): Change type of 'type'
parameter.
* server.c (handle_qxfer_btrace): Change type of 'type'
local.
* target.h (struct target_ops) <read_btrace>: Change type of
'type' parameter. Update comment.
Diffstat (limited to 'gdb/gdbserver/target.h')
| -rw-r--r-- | gdb/gdbserver/target.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/gdb/gdbserver/target.h b/gdb/gdbserver/target.h index a14c6ff..769c876 100644 --- a/gdb/gdbserver/target.h +++ b/gdb/gdbserver/target.h @@ -399,11 +399,11 @@ struct target_ops Returns zero on success, non-zero otherwise. */ int (*disable_btrace) (struct btrace_target_info *tinfo); - /* Read branch trace data into buffer. We use an int to specify the type - to break a cyclic dependency. + /* Read branch trace data into buffer. Return 0 on success; print an error message into BUFFER and return -1, otherwise. */ - int (*read_btrace) (struct btrace_target_info *, struct buffer *, int type); + int (*read_btrace) (struct btrace_target_info *, struct buffer *, + enum btrace_read_type type); /* Read the branch trace configuration into BUFFER. Return 0 on success; print an error message into BUFFER and return -1 |