diff options
| author | Gary Benson <gbenson@redhat.com> | 2014-08-06 11:56:25 +0100 |
|---|---|---|
| committer | Gary Benson <gbenson@redhat.com> | 2014-08-28 15:06:45 +0100 |
| commit | 38e08fcac0966f52dac0ec97870fdea4de304d86 (patch) | |
| tree | aab65459f955f6622d7544965c141af8b5785926 /gdb/gdbserver/regcache.c | |
| parent | 6aefca7e4978b93f502ff8123a6c3cab6e0171f1 (diff) | |
| download | gdb-38e08fcac0966f52dac0ec97870fdea4de304d86.zip gdb-38e08fcac0966f52dac0ec97870fdea4de304d86.tar.gz gdb-38e08fcac0966f52dac0ec97870fdea4de304d86.tar.bz2 | |
Straightforward fatal to internal_error conversions
This commit replaces most of the calls to fatal that represent
internal errors with calls to internal_error, either directly
or via gdb_assert and gdb_assert_not_reached.
gdb/gdbserver/ChangeLog:
* inferiors.c (get_thread_process): Replace check with gdb_assert.
* linux-low.c (linux_wait_for_event_filtered): Replace fatal with
internal_error.
(linux_resume_one_lwp): Likewise.
* linux-x86-low.c (x86_siginfo_fixup): Replace checks with
gdb_assert.
* mem-break.c (raw_bkpt_type_to_target_hw_bp_type): Replace fatal
with internal_error.
* regcache.c (get_thread_regcache): Replace check with gdb_assert.
(init_register_cache): Replace fatal with gdb_assert_not_reached.
(find_register_by_name): Replace fatal with internal_error.
(find_regno): Likewise.
* tdesc.c (init_target_desc): Replace check with gdb_assert.
* thread-db.c (thread_db_create_event): Likewise.
(thread_db_load_search): Likewise.
(try_thread_db_load_1): Likewise.
* tracepoint.c (get_jump_space_head): Replace fatal with
internal_error.
(claim_trampoline_space): Likewise.
(have_fast_tracepoint_trampoline_buffer): Likewise.
(cmd_qtstart): Likewise.
(stop_tracing): Likewise.
(fast_tracepoint_collecting): Likewise.
(target_malloc): Likewise.
(download_tracepoint): Likewise.
(download_trace_state_variables): Replace check with gdb_assert.
(upload_fast_traceframes): Replace fatal with internal_error.
Diffstat (limited to 'gdb/gdbserver/regcache.c')
| -rw-r--r-- | gdb/gdbserver/regcache.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/gdb/gdbserver/regcache.c b/gdb/gdbserver/regcache.c index 916a479..fda2069 100644 --- a/gdb/gdbserver/regcache.c +++ b/gdb/gdbserver/regcache.c @@ -41,8 +41,7 @@ get_thread_regcache (struct thread_info *thread, int fetch) { struct process_info *proc = get_thread_process (thread); - if (proc->tdesc == NULL) - fatal ("no target description"); + gdb_assert (proc->tdesc != NULL); regcache = new_register_cache (proc->tdesc); set_inferior_regcache_data (thread, regcache); @@ -126,7 +125,7 @@ init_register_cache (struct regcache *regcache, regcache->register_status = xcalloc (1, tdesc->num_registers); gdb_assert (REG_UNAVAILABLE == 0); #else - fatal ("init_register_cache: can't allocate memory from the heap"); + gdb_assert_not_reached ("can't allocate memory from the heap"); #endif } else @@ -239,8 +238,8 @@ find_register_by_name (const struct target_desc *tdesc, const char *name) for (i = 0; i < tdesc->num_registers; i++) if (strcmp (name, tdesc->reg_defs[i].name) == 0) return &tdesc->reg_defs[i]; - fatal ("Unknown register %s requested", name); - return 0; + internal_error (__FILE__, __LINE__, "Unknown register %s requested", + name); } int @@ -251,8 +250,8 @@ find_regno (const struct target_desc *tdesc, const char *name) for (i = 0; i < tdesc->num_registers; i++) if (strcmp (name, tdesc->reg_defs[i].name) == 0) return i; - fatal ("Unknown register %s requested", name); - return -1; + internal_error (__FILE__, __LINE__, "Unknown register %s requested", + name); } struct reg * |