diff options
author | Doug Evans <dje@google.com> | 2009-12-21 21:23:43 +0000 |
---|---|---|
committer | Doug Evans <dje@google.com> | 2009-12-21 21:23:43 +0000 |
commit | c5f62d5ff9f52f2170a401631240af7bf7a850e3 (patch) | |
tree | 079fddc53cc70fd018f2e5e7716cf5a0f8375142 /gdb/gdbserver/linux-low.c | |
parent | 10e86dd77848e00024b5de420c18e13db9a103c9 (diff) | |
download | gdb-c5f62d5ff9f52f2170a401631240af7bf7a850e3.zip gdb-c5f62d5ff9f52f2170a401631240af7bf7a850e3.tar.gz gdb-c5f62d5ff9f52f2170a401631240af7bf7a850e3.tar.bz2 |
gdb/
* linux-nat.c (kill_lwp): Minor cleanup, move definition of
tkill_failed into ifdef HAVE_TKILL_SYSCALL. Move setting of errno
there too. Delete unnecessary resetting of errno after syscall.
Minor comment changes to match gdbserver/linux-low.c:kill_lwp.
gdbserver/
* linux-low.c (kill_lwp): Use __NR_tkill instead of SYS_tkill.
Move definition of tkill_failed to ifdef __NR_tkill to avoid gcc
warning ifndef __NR_tkill. Move setting of errno there too.
Delete unnecessary resetting of errno after syscall.
Minor comment changes to match gdb/linux-nat.c:kill_lwp.
Diffstat (limited to 'gdb/gdbserver/linux-low.c')
-rw-r--r-- | gdb/gdbserver/linux-low.c | 30 |
1 files changed, 17 insertions, 13 deletions
diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c index 8b7d9e8..8e91d2b 100644 --- a/gdb/gdbserver/linux-low.c +++ b/gdb/gdbserver/linux-low.c @@ -1572,25 +1572,29 @@ linux_wait (ptid_t ptid, return event_ptid; } -/* Send a signal to an LWP. For LinuxThreads, kill is enough; however, if - thread groups are in use, we need to use tkill. */ +/* Send a signal to an LWP. */ static int kill_lwp (unsigned long lwpid, int signo) { - static int tkill_failed; + /* Use tkill, if possible, in case we are using nptl threads. If tkill + fails, then we are not using nptl threads and we should be using kill. */ - errno = 0; +#ifdef __NR_tkill + { + static int tkill_failed; -#ifdef SYS_tkill - if (!tkill_failed) - { - int ret = syscall (SYS_tkill, lwpid, signo); - if (errno != ENOSYS) - return ret; - errno = 0; - tkill_failed = 1; - } + if (!tkill_failed) + { + int ret; + + errno = 0; + ret = syscall (__NR_tkill, lwpid, signo); + if (errno != ENOSYS) + return ret; + tkill_failed = 1; + } + } #endif return kill (lwpid, signo); |