diff options
| author | Pedro Alves <palves@redhat.com> | 2015-08-24 19:58:31 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2015-08-24 19:58:31 +0100 |
| commit | 3d40fbb53b4478d94b6fa5abad0796cec5d5db49 (patch) | |
| tree | b1f26e12ccd56508e42196293e671abf05b0f7a0 /gdb/gdbserver/inferiors.h | |
| parent | 73b8c1fda9f3759874a9a1a7e7402276da057153 (diff) | |
| download | gdb-3d40fbb53b4478d94b6fa5abad0796cec5d5db49.zip gdb-3d40fbb53b4478d94b6fa5abad0796cec5d5db49.tar.gz gdb-3d40fbb53b4478d94b6fa5abad0796cec5d5db49.tar.bz2 | |
gdbserver crashes when multiprocess extensions aren't supported
Ref: https://sourceware.org/ml/gdb-patches/2015-08/msg00675.html
If multiprocess extensions are off (because specific gdbserver port
doesn't support them), then when gdbserver doesn't have a thread
selected yet, and GDB sends Hg packet to select one, gdbserver
crashes. That's because extracting the desired thread id out of the
packet that GDB sent depends on the current thread to fill in the
missing process id ... Fix this by getting the process id from the
first (and only) process in the processes list instead.
The GNU/Linux port doesn't trip on this because it always runs with
multiprocess extensions enabled. To make it easier to catch such
regressions going forward, this commit also adds a new smoke test that
spawns gdbserver, connects to it and runs to main with the
multiprocess extensions force-disabled.
gdb/gdbserver/ChangeLog:
2015-08-24 Pedro Alves <palves@redhat.com>
* inferiors.c (get_first_process): New function.
* inferiors.h (get_first_process): New declaration.
* remote-utils.c (read_ptid): Default to the first process in the
list, instead of to the current thread's process.
gdb/testsuite/ChangeLog:
2015-08-24 Pedro Alves <palves@redhat.com>
* gdb.server/connect-without-multi-process.c: New file.
* gdb.server/connect-without-multi-process.exp: New file.
Diffstat (limited to 'gdb/gdbserver/inferiors.h')
| -rw-r--r-- | gdb/gdbserver/inferiors.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/gdb/gdbserver/inferiors.h b/gdb/gdbserver/inferiors.h index 88ebbe3..d722616 100644 --- a/gdb/gdbserver/inferiors.h +++ b/gdb/gdbserver/inferiors.h @@ -128,6 +128,9 @@ void remove_inferior (struct inferior_list *list, struct inferior_list_entry *get_first_inferior (struct inferior_list *list); +/* Return the first process in the processes list. */ +struct process_info *get_first_process (void); + struct process_info *add_process (int pid, int attached); void remove_process (struct process_info *process); struct process_info *find_process_pid (int pid); |