New gdbserver option --debug-format=timestamp.

	* NEWS: Mention it.

	gdbserver/
	* configure.ac (AC_CHECK_FUNCS): Add test for gettimeofday.
	* configure: Regenerate.
	* config.in: Regenerate.
	* Makefile.in (SFILES): Add debug.c.
	(OBS): Add debug.o.
	* debug.c: New file.
	* debug.h: New file.
	* linux-aarch64-low.c (*): Update all debugging printfs to use
	debug_printf instead of fprintf.
	* linux-arm-low.c (*): Ditto.
	* linux-cris-low.c (*): Ditto.
	* linux-crisv32-low.c (*): Ditto.
	* linux-m32r-low.c (*): Ditto.
	* linux-sparc-low.c (*): Ditto.
	* linux-x86.c (*): Ditto.
	* linux-low.c (*): Ditto.
	(linux_wait_1): Add calls to debug_enter, debug_exit.
	(linux_wait): Remove redundant debugging printf.
	(stop_all_lwps): Add calls to debug_enter, debug_exit.
	(linux_resume, unstop_all_lwps): Ditto.
	* mem-break.c (*): Update all debugging printfs to use
	debug_printf instead of fprintf.
	* remote-utils.c (*): Ditto.
	* thread-db.c (*): Ditto.
	* server.c #include <ctype.h>, "gdb_vecs.h".
	(debug_threads): Moved to debug.c.
	(*): Update all debugging printfs to use debug_printf instead of
	fprintf.
	(start_inferior): Replace call to fflush with call to debug_flush.
	(monitor_show_help): Mention set debug-format.
	(parse_debug_format_options): New function.
	(handle_monitor_command): Handle "monitor set debug-format".
	(gdbserver_usage): Mention --debug-format.
	(main): Parse --debug-format.
	* server.h (debug_threads): Declaration moved to debug.h.
	#include "debug.h".
	* tracepoint.c (trace_debug_1) [!IN_PROCESS_AGENT]: Add version of
	trace_debug_1 that uses debug_printf.
	(tracepoint_look_up_symbols): Update all debugging printfs to use
	debug_printf instead of fprintf.

	doc/
	* gdb.texinfo (Server): Mention --debug-format=all|none|timestamp.
	(gdbserver man): Ditto.

	testsuite/
	* gdb.server/server-mon.exp: Add tests for "set debug-format".

1 files changed, 98 insertions, 0 deletions

diff --git a/gdb/gdbserver/debug.c b/gdb/gdbserver/debug.c
new file mode 100644
index 0000000..6f4d531
--- /dev/null
+++ b/gdb/gdbserver/debug.c
@@ -0,0 +1,98 @@
+/* Debugging routines for the remote server for GDB.
+   Copyright (C) 2014 Free Software Foundation, Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include "server.h"
+#include <sys/time.h>
+
+/* Enable miscellaneous debugging output.  The name is historical - it
+   was originally used to debug LinuxThreads support.  */
+int debug_threads;
+
+/* Include timestamps in debugging output.  */
+int debug_timestamp;
+
+/* Print a debugging message.
+   If the text begins a new line it is preceded by a timestamp, if the
+   system has gettimeofday.
+   We don't get fancy with newline checking, we just check whether the
+   previous call ended with "\n".  */
+
+void
+debug_printf (const char *msg, ...)
+{
+  va_list args;
+#if defined (HAVE_GETTIMEOFDAY) && !defined (IN_PROCESS_AGENT)
+  /* N.B. Not thread safe, and can't be used, as is, with IPA.  */
+  static int new_line = 1;
+
+  if (debug_timestamp && new_line)
+    {
+      struct timeval tm;
+
+      gettimeofday (&tm, NULL);
+
+      /* If gettimeofday doesn't exist, and as a portability solution it has
+	 been replaced with, e.g., time, then it doesn't make sense to print
+	 the microseconds field.  Is there a way to check for that?  */
+      fprintf (stderr, "%ld:%06ld ", (long) tm.tv_sec, (long) tm.tv_usec);
+    }
+#endif
+
+  va_start (args, msg);
+  vfprintf (stderr, msg, args);
+  va_end (args);
+
+#if defined (HAVE_GETTIMEOFDAY) && !defined (IN_PROCESS_AGENT)
+  if (*msg)
+    new_line = msg[strlen (msg) - 1] == '\n';
+#endif
+}
+
+/* Flush debugging output.
+   This is called, for example, when starting an inferior to ensure all debug
+   output thus far appears before any inferior output.  */
+
+void
+debug_flush (void)
+{
+  fflush (stderr);
+}
+
+/* Notify the user that the code is entering FUNCTION_NAME.
+   FUNCTION_NAME is the name of the calling function, or NULL if unknown.
+
+   This is intended to be called via the debug_enter macro.  */
+
+void
+do_debug_enter (const char *function_name)
+{
+  if (function_name != NULL)
+    debug_printf (">>>> entering %s\n", function_name);
+}
+
+/* Notify the user that the code is exiting FUNCTION_NAME.
+   FUNCTION_NAME is the name of the calling function, or NULL if unknown.
+
+   This is intended to be called via the debug_exit macro.  */
+
+void
+do_debug_exit (const char *function_name)
+{
+  if (function_name != NULL)
+    debug_printf ("<<<< exiting %s\n", function_name);
+}