diff options
| author | Kevin Buettner <kevinb@redhat.com> | 2019-05-06 10:28:44 -0700 |
|---|---|---|
| committer | Kevin Buettner <kevinb@redhat.com> | 2019-05-06 11:00:48 -0700 |
| commit | e90a813d9660bb9d951963fd7ae03ce004a52ad6 (patch) | |
| tree | b5a4de7e8eea14d9c779a02bec66579155f80d12 /gdb/gdbserver/ChangeLog | |
| parent | 41cee0897b670168e0d6f455c9bc45c73f8023df (diff) | |
| download | gdb-e90a813d9660bb9d951963fd7ae03ce004a52ad6.zip gdb-e90a813d9660bb9d951963fd7ae03ce004a52ad6.tar.gz gdb-e90a813d9660bb9d951963fd7ae03ce004a52ad6.tar.bz2 | |
Fix regression caused by recently added syscall restart code
This line of code...
*(int64_t *) ptr = *(int32_t *) ptr;
...in linux-x86-low.c is not needed (and does not work correctly)
within a 32-bit executable. I added an __x86_64__ ifdef (which is
used extensively elsewhere in the file for like purposes) to prevent
this code from being included in 32-bit builds.
It fixes the following regressions when running on native
i686-pc-linux-gnu:
FAIL: gdb.server/abspath.exp: continue to main
FAIL: gdb.server/connect-without-multi-process.exp: multiprocess=auto: continue to main
FAIL: gdb.server/connect-without-multi-process.exp: multiprocess=off: continue to main
FAIL: gdb.server/ext-restart.exp: restart: run to main
FAIL: gdb.server/ext-restart.exp: run to main
FAIL: gdb.server/ext-run.exp: continue to main
FAIL: gdb.server/ext-wrapper.exp: print d
FAIL: gdb.server/ext-wrapper.exp: restart: print d
FAIL: gdb.server/ext-wrapper.exp: restart: run to marker
FAIL: gdb.server/ext-wrapper.exp: run to marker
FAIL: gdb.server/no-thread-db.exp: continue to breakpoint: after tls assignment
FAIL: gdb.server/reconnect-ctrl-c.exp: first: stop with control-c
FAIL: gdb.server/reconnect-ctrl-c.exp: second: stop with control-c
FAIL: gdb.server/run-without-local-binary.exp: run test program until the end
FAIL: gdb.server/server-kill.exp: continue to breakpoint: after server_pid assignment
FAIL: gdb.server/server-kill.exp: tstatus
FAIL: gdb.server/server-run.exp: continue to main
gdb/gdbserver/ChangeLog:
* linux-x86-low.c (x86_fill_gregset): Don't compile 64-bit
sign extension code on 32-bit builds.
Diffstat (limited to 'gdb/gdbserver/ChangeLog')
| -rw-r--r-- | gdb/gdbserver/ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 82278e7..2e98158 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2019-05-06 Kevin Buettner <kevinb@redhat.com> + + * linux-x86-low.c (x86_fill_gregset): Don't compile 64-bit + sign extension code on 32-bit builds. + 2019-05-03 Eli Zaretskii <eliz@gnu.org> * remote-utils.c: |