diff options
| author | Tom Tromey <tom@tromey.com> | 2017-10-08 12:40:07 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2017-10-08 23:16:42 -0600 |
| commit | 30a9c02feff56bd58a276c2a7262f364baa558ac (patch) | |
| tree | 653735bbd531718449106195009cede65ffa1a0b /gdb/frame.h | |
| parent | 757325a3f24e01bf8e7b7214f33c546bc52d1d12 (diff) | |
| download | gdb-30a9c02feff56bd58a276c2a7262f364baa558ac.zip gdb-30a9c02feff56bd58a276c2a7262f364baa558ac.tar.gz gdb-30a9c02feff56bd58a276c2a7262f364baa558ac.tar.bz2 | |
Remove cleanup from frame_prepare_for_sniffer
Currently frame_prepare_for_sniffer returns a cleanup. This patch
changes it to return void, and exposes frame_cleanup_after_sniffer to
the caller.
Normally I would write an RAII class for this sort of thing; but
because there was just a single caller of frame_prepare_for_sniffer,
and because this caller is already using try/catch, I thought it
seemed ok to require explicit calls in this instance.
Regression tested by the buildbot.
gdb/ChangeLog
2017-10-08 Tom Tromey <tom@tromey.com>
* frame-unwind.c (frame_unwind_try_unwinder): Update.
* frame.h (frame_cleanup_after_sniffer): Declare.
(frame_prepare_for_sniffer): Return void.
* frame.c (frame_cleanup_after_sniffer): No longer static. Change
type of argument.
(frame_prepare_for_sniffer): Return void.
Diffstat (limited to 'gdb/frame.h')
| -rw-r--r-- | gdb/frame.h | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/gdb/frame.h b/gdb/frame.h index 1b72610..190ce76 100644 --- a/gdb/frame.h +++ b/gdb/frame.h @@ -791,11 +791,16 @@ extern void info_locals_command (char *, int); extern void return_command (char *, int); /* Set FRAME's unwinder temporarily, so that we can call a sniffer. - Return a cleanup which should be called if unwinding fails, and - discarded if it succeeds. */ + If sniffing fails, the caller should be sure to call + frame_cleanup_after_sniffer. */ -struct cleanup *frame_prepare_for_sniffer (struct frame_info *frame, - const struct frame_unwind *unwind); +extern void frame_prepare_for_sniffer (struct frame_info *frame, + const struct frame_unwind *unwind); + +/* Clean up after a failed (wrong unwinder) attempt to unwind past + FRAME. */ + +extern void frame_cleanup_after_sniffer (struct frame_info *frame); /* Notes (cagney/2002-11-27, drow/2003-09-06): |