aboutsummaryrefslogtreecommitdiff
path: root/gdb/frame.c
diff options
context:
space:
mode:
authorAndrew Burgess <andrew.burgess@embecosm.com>2018-05-18 17:45:16 +0100
committerAndrew Burgess <andrew.burgess@embecosm.com>2018-05-24 18:01:31 +0100
commit45f25d6c83c31a48a01ef8293bb3978f5e58e653 (patch)
tree3eddbff0a9ff77faa031e6180f985b60774583a7 /gdb/frame.c
parentd9f6d7f8b636a2b32004273143d72a77d82b40de (diff)
downloadgdb-45f25d6c83c31a48a01ef8293bb3978f5e58e653.zip
gdb-45f25d6c83c31a48a01ef8293bb3978f5e58e653.tar.gz
gdb-45f25d6c83c31a48a01ef8293bb3978f5e58e653.tar.bz2
gdb: Restore selected frame in print_frame_local_vars
PR gdb/23203 reports 'bt full' causing the currently selected frame to change, this issue is fixed in this commit. Add a new class scoped_restore_selected_frame that saves and restores the selected frame. Make use of this in print_frame_local_vars to restore the selected frame on exit. gdb/ChangeLog: PR gdb/23203 * frame.c (scoped_restore_selected_frame::scoped_restore_selected_frame): Define. (scoped_restore_selected_frame::~scoped_restore_selected_frame): Define. * frame.h (class scoped_restore_selected_frame): New class. * stack.c (print_frame_local_vars): Remove catching and rethrowing of any exception, use scoped_restore_selected_frame to restore the frame instead. gdb/testsuite/ChangeLog: PR gdb/23203 * gdb.base/bt-selected-frame.c: New file. * gdb.base/bt-selected-frame.exp: New file. * lib/gdb.exp (get_current_frame_number): New function.
Diffstat (limited to 'gdb/frame.c')
-rw-r--r--gdb/frame.c16
1 files changed, 16 insertions, 0 deletions
diff --git a/gdb/frame.c b/gdb/frame.c
index 07fa2bc..1d0eb72 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -269,6 +269,22 @@ frame_stash_invalidate (void)
htab_empty (frame_stash);
}
+/* See frame.h */
+scoped_restore_selected_frame::scoped_restore_selected_frame ()
+{
+ m_fid = get_frame_id (get_selected_frame (NULL));
+}
+
+/* See frame.h */
+scoped_restore_selected_frame::~scoped_restore_selected_frame ()
+{
+ frame_info *frame = frame_find_by_id (m_fid);
+ if (frame == NULL)
+ warning (_("Unable to restore previously selected frame."));
+ else
+ select_frame (frame);
+}
+
/* Flag to control debugging. */
unsigned int frame_debug;