diff options
| author | Yao Qi <yao.qi@linaro.org> | 2018-02-21 11:20:03 +0000 |
|---|---|---|
| committer | Yao Qi <yao.qi@linaro.org> | 2018-02-21 11:20:03 +0000 |
| commit | fc5b87361580d915e28ae5f3cc4794b75b671b5a (patch) | |
| tree | 467350f5b0a6a236ec88f665f3eb8cfbe941f3fb /gdb/frame.c | |
| parent | 849d0ba802323fe05e3039ed5b22957db2c85a67 (diff) | |
| download | gdb-fc5b87361580d915e28ae5f3cc4794b75b671b5a.zip gdb-fc5b87361580d915e28ae5f3cc4794b75b671b5a.tar.gz gdb-fc5b87361580d915e28ae5f3cc4794b75b671b5a.tar.bz2 | |
Remove regcache_save and regcache_cpy
... instead we start to use regcache methods save and restore. It is
quite straightforward to replace regcache_save with regcache->save.
regcache_cpy has some asserts, some of them not necessary, like
gdb_assert (src != dst);
because we already assert !m_readonly_p and src->m_readonly_p, so
src isn't dst. Some of the asserts are moved to ::restore.
gdb:
2018-02-21 Yao Qi <yao.qi@linaro.org>
* frame.c (frame_save_as_regcache): Use regcache method save.
(frame_pop): Use regcache method restore.
* infrun.c (restore_infcall_suspend_state): Likewise.
* linux-fork.c (fork_load_infrun_state): Likewise.
* ppc-linux-tdep.c (ppu2spu_sniffer): User regcache method
save.
* regcache.c (regcache_save): Remove.
(regcache::restore): More asserts.
(regcache_cpy): Remove.
* regcache.h (regcache_save): Remove the declaration.
(regcache::restore): Move from private to public.
Remove the friend declaration of regcache_cpy.
(regcache_cpy): Remove declaration.
Diffstat (limited to 'gdb/frame.c')
| -rw-r--r-- | gdb/frame.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/gdb/frame.c b/gdb/frame.c index 1384ecc..773fd04 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -1023,7 +1023,7 @@ frame_save_as_regcache (struct frame_info *this_frame) std::unique_ptr<struct regcache> regcache (new struct regcache (get_frame_arch (this_frame))); - regcache_save (regcache.get (), do_frame_register_read, this_frame); + regcache->save (do_frame_register_read, this_frame); return regcache; } @@ -1068,9 +1068,8 @@ frame_pop (struct frame_info *this_frame) Unfortunately, they don't implement it. Their lack of a formal definition can lead to targets writing back bogus values (arguably a bug in the target code mind). */ - /* Now copy those saved registers into the current regcache. - Here, regcache_cpy() calls regcache_restore(). */ - regcache_cpy (get_current_regcache (), scratch.get ()); + /* Now copy those saved registers into the current regcache. */ + get_current_regcache ()->restore (scratch.get ()); /* We've made right mess of GDB's local state, just discard everything. */ |