diff options
| author | Tom Tromey <tromey@adacore.com> | 2019-04-24 06:50:06 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2019-04-25 12:59:35 -0600 |
| commit | 94aeb44b001ab2d632806242a3bacb0a879abe15 (patch) | |
| tree | edff0a78beb11b19021e0679c1168e14c96bd84a /gdb/exceptions.h | |
| parent | 680d7fd5fcff860a31021845389d4dfeb7b42e3c (diff) | |
| download | gdb-94aeb44b001ab2d632806242a3bacb0a879abe15.zip gdb-94aeb44b001ab2d632806242a3bacb0a879abe15.tar.gz gdb-94aeb44b001ab2d632806242a3bacb0a879abe15.tar.bz2 | |
Make exception handling more efficient
This makes exception handling more efficient in a few spots, through
the use of const- and rvalue-references.
I wrote this patch by commenting out the gdb_exception copy
constructor and then examining the resulting error messages one by
one, introducing the use of std::move where appropriate.
gdb/ChangeLog
2019-04-25 Tom Tromey <tromey@adacore.com>
* xml-support.c (struct gdb_xml_parser) <set_error>: Take an
rvalue reference.
(gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
(gdb_xml_parser::parse): Use std::move.
* python/python-internal.h (gdbpy_convert_exception): Take a const
reference.
* python/py-value.c (valpy_getitem, valpy_nonzero): Use
std::move.
* python/py-utils.c (gdbpy_convert_exception): Take a const
reference.
* python/py-inferior.c (infpy_write_memory, infpy_search_memory):
Use std::move.
* python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
Use std::move.
* mi/mi-main.c (mi_print_exception): Take a const reference.
* main.c (handle_command_errors): Take a const reference.
* linespec.c (parse_linespec): Use std::move.
* infcall.c (run_inferior_call): Use std::move.
(call_function_by_hand_dummy): Use std::move.
* exec.c (try_open_exec_file): Use std::move.
* exceptions.h (exception_print, exception_fprintf)
(exception_print_same): Update.
* exceptions.c (print_exception, exception_print)
(exception_fprintf, exception_print_same): Change parameters to
const reference.
* event-top.c (gdb_rl_callback_read_char_wrapper): Update.
* common/new-op.c: Use std::move.
* common/common-exceptions.h (struct gdb_exception): Add move
constructor.
(struct gdb_exception_error, struct gdb_exception_quit, struct
gdb_quit_bad_alloc): Change constructor to move constructor.
(throw_exception): Change parameter to rvalue reference.
* common/common-exceptions.c (throw_exception): Take rvalue
reference.
* cli/cli-interp.c (safe_execute_command): Use std::move.
* breakpoint.c (insert_bp_location, location_to_sals): Use
std::move.
Diffstat (limited to 'gdb/exceptions.h')
| -rw-r--r-- | gdb/exceptions.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/gdb/exceptions.h b/gdb/exceptions.h index 083313b..e169b25 100644 --- a/gdb/exceptions.h +++ b/gdb/exceptions.h @@ -24,12 +24,14 @@ /* If E is an exception, print it's error message on the specified stream. For _fprintf, prefix the message with PREFIX... */ -extern void exception_print (struct ui_file *file, struct gdb_exception e); -extern void exception_fprintf (struct ui_file *file, struct gdb_exception e, +extern void exception_print (struct ui_file *file, + const struct gdb_exception &e); +extern void exception_fprintf (struct ui_file *file, + const struct gdb_exception &e, const char *prefix, ...) ATTRIBUTE_PRINTF (3, 4); /* Compare two exception objects for print equality. */ -extern int exception_print_same (struct gdb_exception e1, - struct gdb_exception e2); +extern int exception_print_same (const struct gdb_exception &e1, + const struct gdb_exception &e2); #endif |