diff options
| author | Tom Tromey <tom@tromey.com> | 2016-08-22 16:56:52 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2016-09-02 11:33:00 -0600 |
| commit | 4aa4e28bdcf5f0d733def62b542fea11d5f219d5 (patch) | |
| tree | 3a5f878a8dd275ea370cf6e8172f8ed7f92accd1 /gdb/dwarf2expr.c | |
| parent | 1b2d85b255f11d0fce6c323f9e113673445c961a (diff) | |
| download | gdb-4aa4e28bdcf5f0d733def62b542fea11d5f219d5.zip gdb-4aa4e28bdcf5f0d733def62b542fea11d5f219d5.tar.gz gdb-4aa4e28bdcf5f0d733def62b542fea11d5f219d5.tar.bz2 | |
Handle DW_OP_form_tls_address
Currently gdb supports DW_OP_GNU_push_tls_address, but not
DW_OP_form_tls_address. I think it would be better if the toolchain
as a whole moved to using the standard opcode, and the prerequisite to
this is getting gdb to recognize it.
GCC can sometimes emit DW_OP_form_tls_address for emultls targets. As
far as I know, nobody has ever tried this with gdb (since it wouldn't
work at all).
I don't think there's a major drawback to using a single opcode for
all targets, because computing the location of a thread-local is
already target specific.
This is PR gdb/11616.
I don't know how to write a test case for this; though it's worth
noting that there aren't explicit tests for DW_OP_GNU_push_tls_address
either -- and if I change GCC, these paths will be tested to the same
extent they are now.
2016-09-02 Tom Tromey <tom@tromey.com>
PR gdb/11616:
* dwarf2read.c (decode_locdesc): Handle DW_OP_form_tls_address.
* dwarf2loc.c (dwarf2_compile_expr_to_ax): Handle
DW_OP_form_tls_address.
(locexpr_describe_location_piece): Likewise.
* dwarf2expr.h (struct dwarf_expr_context_funcs): Update comment.
* dwarf2expr.c (execute_stack_op): Handle DW_OP_form_tls_address.
(ctx_no_get_tls_address): Mention DW_OP_form_tls_address.
* compile/compile-loc2c.c (struct insn_info): Update comment.
(compute_stack_depth_worker): Handle DW_OP_form_tls_address.
Diffstat (limited to 'gdb/dwarf2expr.c')
| -rw-r--r-- | gdb/dwarf2expr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/dwarf2expr.c b/gdb/dwarf2expr.c index 7bf3c78..7eb1982 100644 --- a/gdb/dwarf2expr.c +++ b/gdb/dwarf2expr.c @@ -1257,6 +1257,7 @@ execute_stack_op (struct dwarf_expr_context *ctx, break; case DW_OP_GNU_push_tls_address: + case DW_OP_form_tls_address: /* Variable is at a constant offset in the thread-local storage block into the objfile for the current thread and the dynamic linker module containing this expression. Here @@ -1533,7 +1534,7 @@ ctx_no_get_frame_pc (void *baton) CORE_ADDR ctx_no_get_tls_address (void *baton, CORE_ADDR offset) { - error (_("%s is invalid in this context"), "DW_OP_GNU_push_tls_address"); + error (_("%s is invalid in this context"), "DW_OP_form_tls_address"); } /* Stub dwarf_expr_context_funcs.dwarf_call implementation. */ |