diff options
author | Tom de Vries <tdevries@suse.de> | 2021-02-05 09:14:25 +0100 |
---|---|---|
committer | Tom de Vries <tdevries@suse.de> | 2021-02-05 09:14:25 +0100 |
commit | d3b54e63f4866551953a03f512049741b0e776c4 (patch) | |
tree | a9a06d6a6e6d973a2404fca6177894919ecb73ff /gdb/dwarf2 | |
parent | fc9a13fbdd7005c93f9d16d33f861594008fc440 (diff) | |
download | gdb-d3b54e63f4866551953a03f512049741b0e776c4.zip gdb-d3b54e63f4866551953a03f512049741b0e776c4.tar.gz gdb-d3b54e63f4866551953a03f512049741b0e776c4.tar.bz2 |
[gdb/symtab] Fix duplicate CUs in create_cus_from_debug_names_list
When running test-case gdb.dwarf2/clang-debug-names.exp, I run into the
following warning:
...
(gdb) file clang-debug-names^M
Reading symbols from clang-debug-names...^M
warning: Section .debug_aranges in clang-debug-names has duplicate \
debug_info_offset 0xc7, ignoring .debug_aranges.^M
...
This is caused by a missing return in commit 3ee6bb113af "[gdb/symtab] Fix
incomplete CU list assert in .debug_names".
Fix this by adding the missing return, such that we have instead this warning:
...
(gdb) file clang-debug-names^M
Reading symbols from clang-debug-names...^M
warning: Section .debug_aranges in clang-debug-names \
entry at offset 0 debug_info_offset 0 does not exists, \
ignoring .debug_aranges.^M
...
which is a known problem filed as PR25969 - "Ignoring .debug_aranges with
clang .debug_names".
Tested on x86_64-linux.
gdb/ChangeLog:
2021-02-05 Tom de Vries <tdevries@suse.de>
PR symtab/27307
* dwarf2/read.c (create_cus_from_debug_names_list): Add missing
return.
gdb/testsuite/ChangeLog:
2021-02-05 Tom de Vries <tdevries@suse.de>
PR symtab/27307
* gdb.dwarf2/clang-debug-names.exp: Check file command warnings.
Diffstat (limited to 'gdb/dwarf2')
-rw-r--r-- | gdb/dwarf2/read.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index eb05851..f60e418 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -5350,6 +5350,7 @@ create_cus_from_debug_names_list (dwarf2_per_bfd *per_bfd, sect_off, 0); per_bfd->all_comp_units.push_back (per_cu); } + return; } sect_offset sect_off_prev; |