aboutsummaryrefslogtreecommitdiff
path: root/gdb/doc
diff options
context:
space:
mode:
authorLuis Machado <luis.machado@arm.com>2022-03-31 16:45:53 +0100
committerLuis Machado <luis.machado@arm.com>2022-04-05 08:44:19 +0100
commitd5ce6f2dcacf9809fb7a29a69c4b98e0320c3c94 (patch)
treedf1744e789b12e5b1fc4a55e55c9b48269fd0f72 /gdb/doc
parent27f9f649753b8c4bd4c40bde0f49d916c222a16a (diff)
downloadgdb-d5ce6f2dcacf9809fb7a29a69c4b98e0320c3c94.zip
gdb-d5ce6f2dcacf9809fb7a29a69c4b98e0320c3c94.tar.gz
gdb-d5ce6f2dcacf9809fb7a29a69c4b98e0320c3c94.tar.bz2
Fix qRcmd error code parsing
Someone at IRC spotted a bug in qRcmd handling. This looks like an oversight or it is that way for historical reasons. The code in gdb/remote.c:remote_target::rcmd uses isdigit instead of isxdigit. One could argue that we are expecting decimal numbers, but further below we use fromhex (). Update the function to use isxdigit instead and also update the documentation. I see there are lots of other cases of undocumented number format for error messages, mostly described as NN instead of nn. For now I'll just update this particular function.
Diffstat (limited to 'gdb/doc')
-rw-r--r--gdb/doc/gdb.texinfo3
1 files changed, 2 insertions, 1 deletions
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index b7da5e1..e50618f 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -42157,7 +42157,8 @@ A command response with no output.
@item @var{OUTPUT}
A command response with the hex encoded output string @var{OUTPUT}.
@item E @var{NN}
-Indicate a badly formed request.
+Indicate a badly formed request. The error number @var{NN} is given as
+hex digits.
@item @w{}
An empty reply indicates that @samp{qRcmd} is not recognized.
@end table