diff options
author | Simon Marchi <simon.marchi@efficios.com> | 2021-01-04 11:56:10 -0500 |
---|---|---|
committer | Simon Marchi <simon.marchi@polymtl.ca> | 2021-01-04 12:00:25 -0500 |
commit | e71daf80d338e536597fa1c3cd1029aadbaa2a67 (patch) | |
tree | 7f47bbfd089a5274f2e67fca6718681665982915 /gdb/debug.c | |
parent | 335709bc5a6dc4778e9931cfa0ed55cb0c516d7a (diff) | |
download | gdb-e71daf80d338e536597fa1c3cd1029aadbaa2a67.zip gdb-e71daf80d338e536597fa1c3cd1029aadbaa2a67.tar.gz gdb-e71daf80d338e536597fa1c3cd1029aadbaa2a67.tar.bz2 |
gdb: use infrun_debug_printf in print_target_wait_results
The code in print_target_wait_results uses a single call to debug_printf
in order to make sure a single timestamp is emitted, despite printing
multiple lines. The result is:
941502.043284 [infrun] target_wait (-1.0.0, status) =
[infrun] 649832.649832.0 [process 649832],
[infrun] status->kind = stopped, signal = GDB_SIGNAL_TRAP
I find this decision a bit counter productive, because it messes up the
alignment of the three lines. We don't care that three (slightly
different) timestamps are printed.
I suggest to change this function to use infrun_debug_printf, with this
result:
941601.425771 [infrun] print_target_wait_results: target_wait (-1.0.0 [process -1], status) =
941601.425824 [infrun] print_target_wait_results: 651481.651481.0 [process 651481],
941601.425867 [infrun] print_target_wait_results: status->kind = stopped, signal = GDB_SIGNAL_TRAP
Note that the current code only prints the waiton_ptid as a string
between square brackets if pid != -1. I don't think this complexity is
needed in a debug print. I made it so it's always printed, which I
think results in a much simpler function.
gdb/ChangeLog:
* infrun.c (print_target_wait_results): Use infrun_debug_printf.
Change-Id: I817bd10286b8e641a6c751ac3a1bd1ddf9b18ce0
Diffstat (limited to 'gdb/debug.c')
0 files changed, 0 insertions, 0 deletions