diff options
| author | Simon Marchi <simon.marchi@efficios.com> | 2020-05-22 16:55:14 -0400 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@efficios.com> | 2020-05-22 16:55:14 -0400 |
| commit | 5e33d5f4e1a5f2c3556ee31715ddc030d039b597 (patch) | |
| tree | e58db956a72805d8a2a800cf0b913fd5808933ed /gdb/ctfread.c | |
| parent | 9392ebb3bbe4a43726ee8939c5447d88c7d3c1e4 (diff) | |
| download | gdb-5e33d5f4e1a5f2c3556ee31715ddc030d039b597.zip gdb-5e33d5f4e1a5f2c3556ee31715ddc030d039b597.tar.gz gdb-5e33d5f4e1a5f2c3556ee31715ddc030d039b597.tar.bz2 | |
gdb: add type::num_fields / type::set_num_fields
Add the `num_fields` and `set_num_fields` methods on `struct type`, in
order to remove the `TYPE_NFIELDS` macro. In this patch, the
`TYPE_NFIELDS` macro is changed to use `type::num_fields`, so all the
call sites that are used to set the number of fields are changed to use
`type::set_num_fields`. The next patch will remove `TYPE_NFIELDS`
completely.
I think that in the future, we should consider making the interface of
`struct type` better. For example, right now it's possible for the
number of fields property and the actual number of fields set to be out
of sync. However, I want to keep the existing behavior in this patch,
just translate from macros to methods.
gdb/ChangeLog:
* gdbtypes.h (struct type) <num_fields, set_num_fields>: New
methods.
(TYPE_NFIELDS): Use type::num_fields. Change all call sites
that modify the number of fields to use type::set_num_fields
instead.
Change-Id: I5ad9de5be4097feaf942d111077434bf91d13dc5
Diffstat (limited to 'gdb/ctfread.c')
| -rw-r--r-- | gdb/ctfread.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/ctfread.c b/gdb/ctfread.c index b5bdb5f..31f927e 100644 --- a/gdb/ctfread.c +++ b/gdb/ctfread.c @@ -308,7 +308,7 @@ attach_fields_to_type (struct ctf_field_info *fip, struct type *type) return; /* Record the field count, allocate space for the array of fields. */ - TYPE_NFIELDS (type) = nfields; + type->set_num_fields (nfields); TYPE_FIELDS (type) = (struct field *) TYPE_ZALLOC (type, sizeof (struct field) * nfields); @@ -1139,7 +1139,7 @@ add_stt_func (struct ctf_context *ccp, unsigned long idx) ftype = get_tid_type (ccp->of, tid); if (finfo.ctc_flags & CTF_FUNC_VARARG) TYPE_VARARGS (ftype) = 1; - TYPE_NFIELDS (ftype) = argc; + ftype->set_num_fields (argc); /* If argc is 0, it has a "void" type. */ if (argc != 0) |