diff options
| author | Pedro Alves <palves@redhat.com> | 2017-06-29 15:52:37 +0100 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2017-06-29 15:52:37 +0100 |
| commit | 195bcdd5183f2c137399db23a68a26a4e4193f8f (patch) | |
| tree | 3651bb5b2e4170b2d8b0da259c9c7b2cd59efe36 /gdb/completer.c | |
| parent | 2e74f9dd8ae79ddfe7f0f84b890c962016fc8f15 (diff) | |
| download | gdb-195bcdd5183f2c137399db23a68a26a4e4193f8f.zip gdb-195bcdd5183f2c137399db23a68a26a4e4193f8f.tar.gz gdb-195bcdd5183f2c137399db23a68a26a4e4193f8f.tar.bz2 | |
Remove old stale expression_completer hack
The code in question was introduced by:
https://sourceware.com/ml/gdb-patches/2008-06/msg00143.html
"The fix is to make sure that the entire expression is passed to
expression_completer, then duplicate some logic there in the case
where location_completer is called."
The logic that was duplicated was much later on removed by the
original explicit locations patch:
commit 87f0e7204722a986f79f245eee716f0870832d47
Author: Keith Seitz <keiths@redhat.com>
AuthorDate: Tue Aug 11 17:09:36 2015 -0700
Commit: Keith Seitz <keiths@redhat.com>
CommitDate: Tue Aug 11 17:09:36 2015 -0700
Explicit locations: add UI features for CLI
@@ -688,16 +880,6 @@ complete_line_internal (const char *text,
rl_completer_word_break_characters =
gdb_completer_file_name_break_characters;
}
- else if (c->completer == location_completer)
- {
- /* Commands which complete on locations want to
- see the entire argument. */
- for (p = word;
- p > tmp_command
- && p[-1] != ' ' && p[-1] != '\t';
- p--)
- ;
- }
However this case in expression_completer was left behind.
I couldn't come up with a test where this currently makes any
difference.
gdb/ChangeLog:
2017-06-29 Pedro Alves <palves@redhat.com>
* completer.c (expression_completer): Remove code that recomputes
'text' from 'word'.
Diffstat (limited to 'gdb/completer.c')
| -rw-r--r-- | gdb/completer.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/gdb/completer.c b/gdb/completer.c index 6acf115..f152dd5 100644 --- a/gdb/completer.c +++ b/gdb/completer.c @@ -587,7 +587,6 @@ expression_completer (struct cmd_list_element *ignore, { struct type *type = NULL; char *fieldname; - const char *p; enum type_code code = TYPE_CODE_UNDEF; /* Perform a tentative parse of the expression, to see whether a @@ -635,15 +634,8 @@ expression_completer (struct cmd_list_element *ignore, } xfree (fieldname); - /* Commands which complete on locations want to see the entire - argument. */ - for (p = word; - p > text && p[-1] != ' ' && p[-1] != '\t'; - p--) - ; - /* Not ideal but it is what we used to do before... */ - return location_completer (ignore, p, word); + return location_completer (ignore, text, word); } /* See definition in completer.h. */ |