diff options
author | Alan Modra <amodra@gmail.com> | 2023-08-27 12:57:16 +0930 |
---|---|---|
committer | Alan Modra <amodra@gmail.com> | 2023-08-27 13:57:42 +0930 |
commit | 26d0081b52dc482c59abba23ca495304e698ce4b (patch) | |
tree | 23ccfa86012bdb77d33e7d52b71344bdc0dbe366 /gdb/complaints.h | |
parent | 398f1ddf5e89e066aeee242ea854dcbaa8eb9539 (diff) | |
download | gdb-26d0081b52dc482c59abba23ca495304e698ce4b.zip gdb-26d0081b52dc482c59abba23ca495304e698ce4b.tar.gz gdb-26d0081b52dc482c59abba23ca495304e698ce4b.tar.bz2 |
Confusion in coff_object_cleanup
A bfd_cleanup function needs to run when only tdata is correct for the
bfd. The xvec may have changed during bfd_check_format and thus the
flavour may be incorrect. The format won't have changed but checking
is superfluous. (In contrast to _bfd_free_cached_info or
_close_and_cleanup where we do need to check things.)
Not getting this correct leaked comdat_hash.
Also, pe_ILF_cleanup ought to call coff_object_cleanup as do all PE
files.
* coffgen.c (coff_object_cleanup): Don't check bfd flavour or
format.
* peicode.h (pe_ILF_cleanup): Call coff_object_cleanup.
Diffstat (limited to 'gdb/complaints.h')
0 files changed, 0 insertions, 0 deletions