diff options
| author | Tom Tromey <tom@tromey.com> | 2018-05-27 21:31:14 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2018-10-04 13:40:10 -0600 |
| commit | 5ca8c39f059b30991b7090e7a662e4eb35d11133 (patch) | |
| tree | dbbce58d49054e2ccc981fae5f2cdc66a4fab0ea /gdb/complaints.h | |
| parent | e79497a160f38368688107520d7d1bd0aeafc1c7 (diff) | |
| download | gdb-5ca8c39f059b30991b7090e7a662e4eb35d11133.zip gdb-5ca8c39f059b30991b7090e7a662e4eb35d11133.tar.gz gdb-5ca8c39f059b30991b7090e7a662e4eb35d11133.tar.bz2 | |
Simplify complaints even more
This removes the SHORT_FIRST_MESSAGE case from complaints, leaving
only a single case. This allows for the removal of the last argument
to clear_complaints, and also simplifies complaint_internal, removing
an extra allocation in the process.
After this, the "./gdb -iex 'set complaint 1' -nx ./gdb" example will
show:
Reading symbols from ./gdb...
During symbol reading: .debug_ranges entry has start address of zero [in module /home/tromey/gdb/build/gdb/gdb]
During symbol reading: DW_AT_low_pc 0x0 is zero for DIE at 0x17116c1 [in module /home/tromey/gdb/build/gdb/gdb]
During symbol reading: .debug_line address at offset 0xa22f5 is 0 [in module /home/tromey/gdb/build/gdb/gdb]
During symbol reading: unsupported tag: 'DW_TAG_unspecified_type'
During symbol reading: const value length mismatch for 'std::ratio<1, 1000000000>::num', got 8, expected 0
This is a bit wordier but, I think, a bit more clear, as the form of
the message no longer depends on precisely when it was emitted. In
particular if you compare to the output from the 'Clean up "Reading
symbols" output' patch, you can see that earlier gdb would switch from
the prefix-less form to the "During symbol reading" form at a point
that is meaningless to the user (specifically, after psymtab reading
is done and gdb tries to expand a CU).
2018-10-04 Tom Tromey <tom@tromey.com>
* symfile.c (syms_from_objfile_1, finish_new_objfile)
(reread_symbols): Update.
* complaints.h (clear_complaints): Remove argument.
* complaints.c (enum complaint_series): Remove.
(series): Remove global.
(complaint_internal): Update.
(clear_complaints): Remove argument.
gdb/testsuite/ChangeLog
2018-10-04 Tom Tromey <tom@tromey.com>
* gdb.cp/maint.exp (test_invalid_name): Update expected output.
* gdb.gdb/complaints.exp (test_short_complaints): Remove.
(test_initial_complaints, test_empty_complaints): Update.
* gdb.dwarf2/dw2-stack-boundary.exp: Update.
Diffstat (limited to 'gdb/complaints.h')
| -rw-r--r-- | gdb/complaints.h | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/gdb/complaints.h b/gdb/complaints.h index 243eaed..edb007f 100644 --- a/gdb/complaints.h +++ b/gdb/complaints.h @@ -40,14 +40,9 @@ extern void complaint_internal (const char *fmt, ...) while (0) /* Clear out / initialize all complaint counters that have ever been - incremented. If LESS_VERBOSE is 1, be less verbose about - successive complaints, since the messages are appearing all - together during a command that is reporting a contiguous block of - complaints (rather than being interleaved with other messages). If - noisy is 1, we are in a noisy command, and our caller will print - enough context for the user to figure it out. */ - -extern void clear_complaints (int less_verbose); + incremented. */ + +extern void clear_complaints (); #endif /* !defined (COMPLAINTS_H) */ |