diff options
| author | Tom Tromey <tom@tromey.com> | 2022-08-02 09:55:32 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2022-08-03 13:26:58 -0600 |
| commit | 98badbfdc222d1d7f346046f23a64522b88d22a0 (patch) | |
| tree | a57a95b75f64a0e318e0b1bd31dd6b246e4797d8 /gdb/compile | |
| parent | 4d44946794e68cf79cfba467fa414a958dba2185 (diff) | |
| download | gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.zip gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.tar.gz gdb-98badbfdc222d1d7f346046f23a64522b88d22a0.tar.bz2 | |
Use gdb_bfd_ref_ptr in objfile
This changes struct objfile to use a gdb_bfd_ref_ptr. In addition to
removing some manual memory management, this fixes a use-after-free
that was introduced by the registry rewrite series. The issue there
was that, in some cases, registry shutdown could refer to memory that
had already been freed. This help fix the bug by delaying the
destruction of the BFD reference (and thus the per-bfd object) until
after the registry has been shut down.
Diffstat (limited to 'gdb/compile')
| -rw-r--r-- | gdb/compile/compile-object-load.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/compile/compile-object-load.c b/gdb/compile/compile-object-load.c index d393091..06e8c85 100644 --- a/gdb/compile/compile-object-load.c +++ b/gdb/compile/compile-object-load.c @@ -643,7 +643,7 @@ compile_object_load (const compile_file_names &file_names, /* SYMFILE_VERBOSE is not passed even if FROM_TTY, user is not interested in "Reading symbols from ..." message for automatically generated file. */ - objfile_up objfile_holder (symbol_file_add_from_bfd (abfd.get (), + objfile_up objfile_holder (symbol_file_add_from_bfd (abfd, filename.get (), 0, NULL, 0, NULL)); objfile = objfile_holder.get (); |